Re: [hibernate-dev] Some minor improvements to Hibernate Search
Hi, welcome,
2)
I didn't need it so far, but it seems reasonable to provide this access.
Out of curiosity, what are you needing it for?
Seems a bit weird that nobody asked before.
3)
Nice, but because of a problem in namespaces with compass I guess
you're not using their implementation of Lucene Directory?
The problem being that they have some packages named
org.hibernate.search so in practice you'll have to be carefull in
having both projects on classpath.
4)
I'd expect it to be built in in Spring, not the other way around?
Would be nice if you could contribute an integration to them.
Regards,
Sanne
2009/10/23 Hardy Ferentschik <hibernate(a)ferentschik.de>:
Hi,
On Fri, 23 Oct 2009 16:47:48 +0200, Amin Mohammed-Coleman
<aminmc(a)gmail.com> wrote:
> I have been looking at the Hibernate Search codebase and I am very keen
> to help out.
Great. Help is always welcome :)
> 1) Remove cyclic reference in JmsBackEndQueueProcessor and
> JmsBackEndQueueProcessorFactory. It seems as though the factory creates
> a
> processor and the processor depends on the factory. The processor only
> needs the queueConnection factory and jms queue which I think should be
> passed to the processor instead of passing the factory. The object being
> created should not know about the factory.
I haven't really looked at the code yet, but what you say seems reasonable.
Why do you not create a Jira issue in
http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH
and provide a patch for this?
> 2) Create a convienence method (not sure where) that enables a user to
> get
> the lucene document using either the fulltextsession. So for example the
> method would loook something like:
> fullTextSession.getDocument(Class<?> clazz, Serializable id);
> Under the hood it would delegate the work to the directory providers
> and close the index readers.
I can see how this could be useful. What do the others think?
> 3) Provide integration with GigaSpaces which I had started but not
> completed.
I guess this relates to this forum thread -
https://forum.hibernate.org/viewtopic.php?f=9&t=990867
It seems you even have already an implementation :) I am just wondering
whether this
directory implementation is also testable without having a running
Gigaspace instance?
Would this new implementation introduce additional dependencies?
> 4) Integration with Spring and maybe Spring Integration.
Hmm, that sort of thing seems to belong to the Spring side. At least in my
eyes.
--Hardy
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev