On Thu, Aug 27, 2015 at 11:34:19AM +0100, Sanne Grinovero wrote:
Regarding "strong reason", my doubt is just that the method
seems
wrong for the purpose: keyWORD(), and it seems to imply we override an
explicit user choice.
Right. I also think some sort of understanding is necessary. Obviously you
can try to hide everything away, but this will only make it harder for the users
wanted to go a bit below the surface.
But I wonder that - in case people just want something which works
for
equality - if we shouldn't make a better named method for that.
+1
Also, I hate it when frameworks "know better" and for some
automagic
reason it overrides an explicit user request. It seems to me the user
is explicitly demanding to build a keyword-based query, and we
override that because of some metadata we happen to have in this case.
This whole logic might even work in this case but it's certainly
inconsistent with other DSL usage, as often we don't have the full
picture of metadata and just rely on the user to build the right query
type and set the correct options.
+1
--Hardy