Well the discussion of disabling the tests completely grew from the
fact that the tests as they are are not stable. Inconsequential
changes would often cause them to fail. Thats why I qualified my
response with "Of course this means making these tests stable" ;)
In general I am not a fan of having code in one repo and then having
its tests in another repo. We can have comprehensive tests in another
repo, thats fine. But the project that defines the code should at
least have basic "it works" testing.
On Fri 13 Dec 2013 09:06:04 AM CST, Brett Meyer wrote:
Our current Arquillian-based test in hibernate-osgi demonstrates:
1.) the core/em/osgi and client bundles started
2.) SF/EMF can be created through the OSGi services
3.) basic CRUD
4.) our internal extension points registered themselves through OSGi blueprint services
and core discovered them (ex: Envers' Integrator)
5.) core discovered extension point services registered by the client bundle (Integrator,
TypeContributor, StrategyRegistration)
That provides somewhat adequate coverage of typical issues presented by the OSGi
environment. I'm completely fine with leaving those there (and prefer to). Steve, I
originally brought this up due to past discussions about disabling the tests entirely.
Regardless, there are certainly more "advanced" integration tests, matrices,
etc. that could be demonstrated through a new combined project and CI job.
Brett Meyer
Red Hat, Hibernate ORM
----- Original Message -----
From: "Steve Ebersole" <steve(a)hibernate.org>
To: "Brett Meyer" <brmeyer(a)redhat.com>, "Emmanuel Bernard"
<emmanuel(a)hibernate.org>, "Gunnar Morling" <gunnar(a)hibernate.org>
Cc: "Hibernate" <hibernate-dev(a)lists.jboss.org>
Sent: Friday, December 13, 2013 9:54:04 AM
Subject: Re: [hibernate-dev] Create OSGi integration test project for all of Hibernate?
I think it sounds great... in theory. But I believe you will hit the
matrix problem Emmanuel discusses.
However, I also want to make sure we are not removing "smoke tests" from
the projects themselves. I don't care what you call them: smoke tests,
integration tests, unit tests, regression tests, etc. But there needs to
be tests in ORM (for example) that ensure that basic OSGi functionality
is not broken when we make changes. More importantly, these tests are
needed for contributors so they can verify that they are not breaking
something when they make changes. Expecting them to check out some
"other project" for "full testing" is simply unreasonable. Of
course
this means making these tests stable.
On 12/13/2013 08:40 AM, Brett Meyer wrote:
> Exactly. And the matrix can become even more complicated if we attempt multiple
instances/versions of our bundles and client bundles.
>
> Gunnar, what are your thoughts, since Validator already has a PAX EXAM test?
>
> Brett Meyer
> Red Hat, Hibernate ORM
>
> ----- Original Message -----
> From: "Emmanuel Bernard" <emmanuel(a)hibernate.org>
> To: "Brett Meyer" <brmeyer(a)redhat.com>
> Cc: "Hibernate" <hibernate-dev(a)lists.jboss.org>
> Sent: Friday, December 13, 2013 2:48:23 AM
> Subject: Re: [hibernate-dev] Create OSGi integration test project for all of
Hibernate?
>
> This sounds like a good idea. You will hit the more general problem of the
compatibility matrix and snapshot against snapshot issue we need to address to avoid the
micro version incompatibilities that have hit Search and ORM recently.
>
>> On 12 déc. 2013, at 19:29, Brett Meyer <brmeyer(a)redhat.com> wrote:
>>
>> ORM currently uses Arquillian to test hibernate-osgi (and afaik Validator does
the same). Since at least ORM, Validator, and Search have moved or are moving towards
supporting OSGi environments, would it make more sense to create
hibernate/hibernate-osgi-integration-tests and wire it to a new CI job? Arguably, they
shouldn't be considered a "unit test" to begin with, but that's up for
debate. Thoughts?
>>
>> Brett Meyer
>> Red Hat, Hibernate ORM
>>
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev(a)lists.jboss.org
>>
https://lists.jboss.org/mailman/listinfo/hibernate-dev
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/hibernate-dev