9:37 a.m.
We would like to update WildFly (14) to Javassist 3.23.1, has anyone
tried using Javassist 3.23.1 with Hibernate ORM 5.3? I'd like to know
that we at least can pass the Javassist tests with the ORM testsuite,
preferably on JDK11 (since that is why we want to upgrade Javassist on
WildFly).
Thanks,
Scott
9:56 a.m.
Hi Scott,
send a PR, the bots will trigger test runs at least for Java 8.
For proper JDK11 testing that will have to wait as other things aren't
working yet, but if the Javassist update works flawlessly on Java 8
there is no reason to not update this point already.
Thanks,
Sanne
On Mon, 9 Jul 2018 at 15:38, Scott Marlow <smarlow(a)redhat.com> wrote:
We would like to update WildFly (14) to Javassist 3.23.1, has anyone
tried using Javassist 3.23.1 with Hibernate ORM 5.3? I'd like to know
that we at least can pass the Javassist tests with the ORM testsuite,
preferably on JDK11 (since that is why we want to upgrade Javassist on
WildFly).
Thanks,
Scott
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
10:12 a.m.
On Mon, 9 Jul 2018 at 16:09, Guillaume Smet <guillaume.smet(a)gmail.com> wrote:
On Mon, Jul 9, 2018 at 4:56 PM Sanne Grinovero <sanne(a)hibernate.org> wrote:
>
> send a PR, the bots will trigger test runs at least for Java 8.
Do we run all the tests with Javassist now that Bytebuddy is the default?
No, but there are some tests which are specific to Javassist.
--
Guillaume
10:27 a.m.
On Mon, Jul 9, 2018 at 5:12 PM Sanne Grinovero <sanne(a)hibernate.org> wrote:
No, but there are some tests which are specific to Javassist.
That's what I suspected. Let's run the full test suite with the new version
of Javassist then. I prefer to be on the safe side, especially because I'm
not sure all the bugs in the bytebuddy implementation have been fixed.
Scott, I'll take care of running the tests tomorrow and provide feedback.
Not sure about Java 11 but let's at least check we don't have any
regressions.
To be very clear, while I can run the tests and tell you if they pass or
not, if there are any issues, we will need some extra support to fix them.
I created https://hibernate.atlassian.net/browse/HHH-12781 to track this
effort and tentatively scheduled it for 5.3.3, released on July 19th.
--
Guillaume
3:15 p.m.
On 07/09/2018 11:27 AM, Guillaume Smet wrote:
On Mon, Jul 9, 2018 at 5:12 PM Sanne Grinovero
<sanne(a)hibernate.org
<mailto:sanne@hibernate.org>> wrote:
No, but there are some tests which are specific to Javassist.
That's what I suspected. Let's run the full test suite with the new
version of Javassist then. I prefer to be on the safe side, especially
because I'm not sure all the bugs in the bytebuddy implementation have
been fixed.
Scott, I'll take care of running the tests tomorrow and provide
feedback. Not sure about Java 11 but let's at least check we don't have
any regressions.
To be very clear, while I can run the tests and tell you if they pass or
not, if there are any issues, we will need some extra support to fix them.
I created https://hibernate.atlassian.net/browse/HHH-12781 to track this
effort and tentatively scheduled it for 5.3.3, released on July 19th.
Thanks, I created https://issues.jboss.org/browse/WFLY-10683 for the
WildFly update to Javassist 3.23.1-GA (if your ORM testing passes).
Scott
--
Guillaume
6:24 a.m.
On Mon, Jul 9, 2018 at 10:15 PM Scott Marlow <smarlow(a)redhat.com> wrote:
Thanks, I created https://issues.jboss.org/browse/WFLY-10683 for the
WildFly update to Javassist 3.23.1-GA (if your ORM testing passes).
So, the bad news is our Javassist support was completely broken. See
https://hibernate.atlassian.net/browse/HHH-12784 for more details.
The good news is that the Javassist upgrade is OK. I also ran the tests
with JDK 11: quite a lot of tests are failing on our part (mostly because
of Mockito but not only: there are a few other issues that we will need to
dig in) but not the ones related to enhancement.
PR is here: https://github.com/hibernate/hibernate-orm/pull/2407 .
I also opened an issue to restore Javassist testing, which is something
that had me worried for quite a while:
https://hibernate.atlassian.net/browse/HHH-12785 . If someone more familiar
with the build environment and Gradle could take this task as part of his
"one day a week on 5.3" day, that would be greatly appreciated.
Thanks.
--
Guillaume
2280
days inactive
2281
days old
6 comments
3 participants
participants (3)
-
Guillaume Smet -
Sanne Grinovero -
Scott Marlow