My rule for library/framework development has always been that you should use at least 20% of a dependencies functionality if you want to add it as a dependency (rather than just copy the source to your code base). If you are using >50% you should add it, no question, and in between you have to make a decision case-by-case. So I definitely think this is a good idea. Though of course I think we should put it in a distinct package :-) On 24 Jan 2011, at 13:52, Galder Zamarreño wrote: > Hi all, > > Looking at Infinispan's dependencies, core seems to depend on JBoss Common Core simply to take advantage of org.jboss.util.StringPropertyReplacer. > > Test code also depends for org.jboss.util.naming.NonSerializableFactory. > > What about we make our own org.jboss.util.StringPropertyReplacer and remove JBoss Common Core from being a main dependency? We could still keep it as a test dependency for org.jboss.util.naming.NonSerializableFactory. > > Cheers, > -- > Galder Zamarreño > Sr. Software Engineer > Infinispan, JBoss Cache > > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

p.s. Bela will love this thread :) On Jan 24, 2011, at 3:21 PM, Galder Zamarreño wrote: > Totally agree with that. Sounds like a good rule to follow. > > https://issues.jboss.org/browse/ISPN-889 > > On Jan 24, 2011, at 3:07 PM, Pete Muir wrote: > >> My rule for library/framework development has always been that you should use at least 20% of a dependencies functionality if you want to add it as a dependency (rather than just copy the source to your code base). If you are using>50% you should add it, no question, and in between you have to make a decision case-by-case. So I definitely think this is a good idea. >> >> Though of course I think we should put it in a distinct package :-) >> >> On 24 Jan 2011, at 13:52, Galder Zamarreño wrote: >> >>> Hi all, >>> >>> Looking at Infinispan's dependencies, core seems to depend on JBoss Common Core simply to take advantage of org.jboss.util.StringPropertyReplacer. >>> >>> Test code also depends for org.jboss.util.naming.NonSerializableFactory. >>> >>> What about we make our own org.jboss.util.StringPropertyReplacer and remove JBoss Common Core from being a main dependency? We could still keep it as a test dependency for org.jboss.util.naming.NonSerializableFactory. >>> >>> Cheers, >>> -- >>> Galder Zamarreño >>> Sr. Software Engineer >>> Infinispan, JBoss Cache >>> >>> >>> _______________________________________________ >>> infinispan-dev mailing list >>> infinispan-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> >> >> >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > > -- > Galder Zamarreño > Sr. Software Engineer > Infinispan, JBoss Cache > > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev -- Galder Zamarreño Sr. Software Engineer Infinispan, JBoss Cache _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev