Policy: PR with failing test as a reproducer
by Tomas Sykora
Hello all,
I'd like to know what is our policy in a following matter:
I've wrote a new test which is failing. (local branch)
1) Do we want to integrate also failing test into our test-suite? To see the test failing regularly until the issue is fixed? I suppose no.
2) The other and clearly better "solution" is to push failing test into my own remote branch, create JIRA, let others to try out the issue from my remote branch and wait for fix, then, integrate (already passing) test into upstream.
Is here any possible place for 1) as well? Or we strictly follow 2)?
The only reason which I can see for a policy 1) is that the test would by failing regularly and wouldn't be easily overlooked.
Thank you for your thoughts!
Tomas
9 years, 11 months
Re: [infinispan-dev] book on Infinispan
by Mircea Markus
Thanks, really looking forward to it!
On Jun 3, 2014, at 2:38, Wagner Santos <wrsconsulting(a)gmail.com> wrote:
> Hi Mircea,
>
> Nice to meet you,
>
> It's a honor for me to know you, I have to congratulate you for the awesome work with Infinispan.
>
> I sent the draft of the last chapter today, and I think that it would be great if you (or anyone that you may be working with.) could review it!
>
> If you have any query, just let me know!
>
> Thanks and Kind Regards,
Cheers,
--
Mircea Markus
Infinispan lead (www.infinispan.org)
9 years, 11 months
Re: [infinispan-dev] JDK8 master failures
by Sanne Grinovero
I also have a failure in infinispan-core, so not getting beyond to
test other modules:
Failed tests:
ThreadLocalLeakTest.testCheckThreadLocalLeaks:87 IllegalState Thread
locals st...
testCheckThreadLocalLeaks(org.infinispan.util.ThreadLocalLeakTest)
Time elapsed: 0.544 sec <<< FAILURE!
java.lang.IllegalStateException: Thread locals still present:
{ForkThread-1,ThreadLocalLeakTest={java.lang.ThreadLocal@2978515=org.infinispan.commons.util.concurrent.jdk8backported.EquivalentConcurrentHashMapV8$CounterHashCode(a)29a22707}}
at org.infinispan.util.ThreadLocalLeakTest.testCheckThreadLocalLeaks(ThreadLocalLeakTest.java:87)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:80)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
at org.testng.TestRunner.privateRun(TestRunner.java:767)
at org.testng.TestRunner.run(TestRunner.java:617)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
at org.testng.SuiteRunner.access$000(SuiteRunner.java:37)
at org.testng.SuiteRunner$SuiteWorker.run(SuiteRunner.java:368)
at org.testng.internal.thread.ThreadUtil$2.call(ThreadUtil.java:64)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
Results :
Failed tests:
ThreadLocalLeakTest.testCheckThreadLocalLeaks:87 IllegalState Thread
locals st...
Tests run: 5389, Failures: 1, Errors: 0, Skipped: 0
On 2 June 2014 15:07, Galder Zamarreño <galder(a)redhat.com> wrote:
> Seems like there are tons of JDK8 failures on master:
>
> Caused by: java.lang.NoSuchMethodException: org.infinispan.security.SecureCacheTestDriver.testReplaceAll_BiFunction(org.infinispan.security.SecureCache)
>
> @Tristan, ring a bell?
>
> Cheers,
> --
> Galder Zamarreño
> galder(a)redhat.com
> twitter.com/galderz
>
9 years, 11 months
book on Infinispan
by Mircea Markus
Hi Wagner,
How's the book progressing? If you want someone to review it happy to take a look.
Cheers,
--
Mircea Markus
Infinispan lead (www.infinispan.org)
9 years, 11 months
