2:50 p.m.
.. and from who.
It's sometimes unclear which PRs are there in need for review, or
which have been commented on and are waiting for fixes / polishing /
rebase / denial.
Hope these labels help:
https://github.com/infinispan/infinispan/pulls
And you can bookmark them!
https://github.com/infinispan/infinispan/pulls?q=is%3Aopen+is%3Apr+label%...
Cheers,
Sanne
3:02 a.m.
Great, thanks, Sanne! I was often in-doubt what's the actual status of
my PR, now I will check these :)
Btw., "Ready for review" suggests that I think that it could be
integrated after a proper review. There are situations (such as my [1])
where I need some advice about the PR - should that be considered "Ready
for review", or would be some label "Advice/Review requested" fit
better? Of course, having thousand labels is not desirable, that's why I
am asking how coarse grained this should be.
Radim
[1] https://github.com/infinispan/infinispan/pull/2585
On 08/01/2014 09:50 PM, Sanne Grinovero wrote:
.. and from who.
It's sometimes unclear which PRs are there in need for review, or
which have been commented on and are waiting for fixes / polishing /
rebase / denial.
Hope these labels help:
https://github.com/infinispan/infinispan/pulls
And you can bookmark them!
https://github.com/infinispan/infinispan/pulls?q=is%3Aopen+is%3Apr+label%...
Cheers,
Sanne
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Radim Vansa <rvansa(a)redhat.com>
JBoss DataGrid QA
6:54 a.m.
Nice idea! I am using [1] to monitor the PRs I was involved in, which does
a pretty good job, but it's annoying that it misses some updates (like the
build status, most of the time).
I have one suggestion: most PRs are ready for review the moment they are
issued, so I think that should be the default - no label required.
I would add instead a "Do not integrate yet" label :)
[1] https://prs.paas.allizom.org/infinispan/infinispan
On Mon, Aug 4, 2014 at 11:02 AM, Radim Vansa <rvansa(a)redhat.com> wrote:
Great, thanks, Sanne! I was often in-doubt what's the actual
status of
my PR, now I will check these :)
Btw., "Ready for review" suggests that I think that it could be
integrated after a proper review. There are situations (such as my [1])
where I need some advice about the PR - should that be considered "Ready
for review", or would be some label "Advice/Review requested" fit
better? Of course, having thousand labels is not desirable, that's why I
am asking how coarse grained this should be.
Radim
[1] https://github.com/infinispan/infinispan/pull/2585
On 08/01/2014 09:50 PM, Sanne Grinovero wrote:
> .. and from who.
>
> It's sometimes unclear which PRs are there in need for review, or
> which have been commented on and are waiting for fixes / polishing /
> rebase / denial.
>
> Hope these labels help:
> https://github.com/infinispan/infinispan/pulls
>
> And you can bookmark them!
>
https://github.com/infinispan/infinispan/pulls?q=is%3Aopen+is%3Apr+label%...
>
> Cheers,
> Sanne
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Radim Vansa <rvansa(a)redhat.com>
JBoss DataGrid QA
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
10:23 a.m.
On 4 August 2014 12:54, Dan Berindei <dan.berindei(a)gmail.com> wrote:
Nice idea! I am using [1] to monitor the PRs I was involved in, which
does a
pretty good job, but it's annoying that it misses some updates (like the
build status, most of the time).
Nice thing. Were you keeping that for yourself? :-)
A bit slowish to load though, and doesn't give me the quick overview I
need, which is to answer the question: "Any PR I can help merging in
short time?"
I have one suggestion: most PRs are ready for review the moment they
are
issued, so I think that should be the default - no label required.
I would add instead a "Do not integrate yet" label :)
Yes it would be nice to have them added the "Ready for Review" label
by default, still I highly prefer having a bold green label so that we
can quickly find one to merge..
it's more about the colour codes personally, I don't usually have time
for Infinispan PRs and since you all tend to leave them lingering for
a long time, it's often hard to find one which I could merge.
Normally by the time I find one, my time slot on Infinispan is over so
your opportunity to get a merge done is gone ;-)
Another problem we have is that sometimes after a couple of comments
it's unclear who needs to act next. Is the PR crap and needs to be
rewritten? Is the reviewer done with comments, or was he distracted?
etc.. so better flag things visually for the others to be able to
help.
I'd prefer to leave the "no label" case to means something like "needs
to be categorised"(labelled), for example what we'd do for a first
high level screening for new contributors PRs.
Cheers,
Sanne
[1] https://prs.paas.allizom.org/infinispan/infinispan
On Mon, Aug 4, 2014 at 11:02 AM, Radim Vansa <rvansa(a)redhat.com> wrote:
>
> Great, thanks, Sanne! I was often in-doubt what's the actual status of
> my PR, now I will check these :)
>
> Btw., "Ready for review" suggests that I think that it could be
> integrated after a proper review. There are situations (such as my [1])
> where I need some advice about the PR - should that be considered "Ready
> for review", or would be some label "Advice/Review requested" fit
> better? Of course, having thousand labels is not desirable, that's why I
> am asking how coarse grained this should be.
>
> Radim
>
> [1] https://github.com/infinispan/infinispan/pull/2585
>
> On 08/01/2014 09:50 PM, Sanne Grinovero wrote:
> > .. and from who.
> >
> > It's sometimes unclear which PRs are there in need for review, or
> > which have been commented on and are waiting for fixes / polishing /
> > rebase / denial.
> >
> > Hope these labels help:
> > https://github.com/infinispan/infinispan/pulls
> >
> > And you can bookmark them!
> >
> >
https://github.com/infinispan/infinispan/pulls?q=is%3Aopen+is%3Apr+label%...
> >
> > Cheers,
> > Sanne
> > _______________________________________________
> > infinispan-dev mailing list
> > infinispan-dev(a)lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
>
> --
> Radim Vansa <rvansa(a)redhat.com>
> JBoss DataGrid QA
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
10:09 a.m.
On 4 August 2014 09:02, Radim Vansa <rvansa(a)redhat.com> wrote:
Great, thanks, Sanne! I was often in-doubt what's the actual
status of
my PR, now I will check these :)
Btw., "Ready for review" suggests that I think that it could be
integrated after a proper review. There are situations (such as my [1])
where I need some advice about the PR - should that be considered "Ready
for review", or would be some label "Advice/Review requested" fit
better? Of course, having thousand labels is not desirable, that's why I
am asking how coarse grained this should be.
Good point, I've created an intense blue label for that.
+1 to not have many labels but we're free to experiment a bit.
Sanne
Radim
[1] https://github.com/infinispan/infinispan/pull/2585
On 08/01/2014 09:50 PM, Sanne Grinovero wrote:
> .. and from who.
>
> It's sometimes unclear which PRs are there in need for review, or
> which have been commented on and are waiting for fixes / polishing /
> rebase / denial.
>
> Hope these labels help:
> https://github.com/infinispan/infinispan/pulls
>
> And you can bookmark them!
>
https://github.com/infinispan/infinispan/pulls?q=is%3Aopen+is%3Apr+label%...
>
> Cheers,
> Sanne
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Radim Vansa <rvansa(a)redhat.com>
JBoss DataGrid QA
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
5:13 a.m.
Great use of the new PR labels, thanks a lot Sanne!! :)
On 01 Aug 2014, at 21:50, Sanne Grinovero <sanne(a)infinispan.org> wrote:
.. and from who.
It's sometimes unclear which PRs are there in need for review, or
which have been commented on and are waiting for fixes / polishing /
rebase / denial.
Hope these labels help:
https://github.com/infinispan/infinispan/pulls
And you can bookmark them!
https://github.com/infinispan/infinispan/pulls?q=is%3Aopen+is%3Apr+label%...
Cheers,
Sanne
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Galder Zamarreño
galder(a)redhat.com
twitter.com/galderz
5:14 a.m.
Also great to see that you can finally see at a glance to whom a PR is assigned.
On 01 Aug 2014, at 21:50, Sanne Grinovero <sanne(a)infinispan.org> wrote:
.. and from who.
It's sometimes unclear which PRs are there in need for review, or
which have been commented on and are waiting for fixes / polishing /
rebase / denial.
Hope these labels help:
https://github.com/infinispan/infinispan/pulls
And you can bookmark them!
https://github.com/infinispan/infinispan/pulls?q=is%3Aopen+is%3Apr+label%...
Cheers,
Sanne
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Galder Zamarreño
galder(a)redhat.com
twitter.com/galderz
3590
days inactive
3594
days old
infinispan-dev@lists.jboss.org
6 comments
4 participants
participants (4)
-
Dan Berindei -
Galder Zamarreño -
Radim Vansa -
Sanne Grinovero