Hi, Re: https://github.com/galderz/infinispan/commit/fa419a1b22f56faa49e66588728f... and https://issues.jboss.org/browse/ISPN-1652 Back when Infinispan started, flags travelled down via thread locals and the context. Now these flags are even part of the commands in order to travel accross different nodes. As indicated in the JIRA and my comment, solving this problem by recreating context for each command is complex (what type of context? remote? local?… I had a rather hacky looking solution but broke tx recovery). I do see however commands a more natural fit for flags. We use flags to invoke an operation with those flags. To me, flags should really be migrated off context into command and read them consistenly from command which btw solves this problem rather easily. I'm aware that I might be missing some odd use case where flags need to be in context but can't think of it right now, hence this email thread, to see if someone else can spot it. Cheers, -- Galder Zamarreño Sr. Software Engineer Infinispan, JBoss Cache _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

On 3 Jan 2012, at 17:10, Sanne Grinovero wrote: > Hi Galder, > I agree with you, the command looks like a better place to place the > Flags. +1. The InvocationContext is something local, so if we need remote propagation the flags should be associated with the command. > The only mismatch is with the origin where flags are enabled, > but I consider this as a convenience rather than a source of > surprising mismatches as I don't see how this API could lead to > unexpected results. > > So the idea is in the future to avoid checking for flags in the > context but rather look in the command directly? So that we can avoid > copying them in the invocation context. can't we just drop the flags from the invocation context entirely?

On 3 Jan 2012, at 15:40, Mircea Markus wrote: >> >> So the idea is in the future to avoid checking for flags in the >> context but rather look in the command directly? So that we can avoid >> copying them in the invocation context. > can't we just drop the flags from the invocation context entirely? That would involve changing quite a lot of code, wouldn't it?

-- Manik Surtani manik(a)jboss.org twitter.com/maniksurtani Lead, Infinispan http://www.infinispan.org _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

Indeed but I had no plans to do this in time for 5.1, it's too short notice and too bigger risk. Something for 5.2 IMO. What we can do is apply the suggested change in the pull req to fix the issue at hand, and leave further changes that we all seem to agree on for 5.2.