11:02 a.m.
Hi Pete,
Whilst the 'read(template)' method does make sense in the case of cache level
configurations(AbstractConfigurationChildBuilder) in order to override the values from the
default cache, is 'read(template)' in the global configuration also
needed(AbstractGlobalConfigurationBuilder)? We don't use any override mechanism for
global configuration; it also doesn't seem to be used anywhere in the code.
Cheers,
Mircea
9:33 a.m.
Mircea, I think the idea was to allow users to create a new CacheManager
based on an existing CacheManager, but with some global configuration
changes.
For instance, we could have used it in TestCacheManagerFactory, to allow
the user to pass in a GlobalConfiguration instead of a
GlobalConfigurationBuilder to when creating CacheManagers. Of course, for
us it was easy enough to change all the tests to pass in a
GlobalConfigurationBuilder, but I don't really like the caller having to
know that the global configuration will be modified before creating the
CacheManager.
Cheers
Dan
On Fri, Jul 13, 2012 at 12:02 PM, Mircea Markus <mircea.markus(a)jboss.com>wrote:
Hi Pete,
Whilst the 'read(template)' method does make sense in the case of cache
level configurations(AbstractConfigurationChildBuilder) in order to
override the values from the default cache, is 'read(template)' in the
global configuration also needed(AbstractGlobalConfigurationBuilder)? We
don't use any override mechanism for global configuration; it also doesn't
seem to be used anywhere in the code.
Cheers,
Mircea
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
1:59 p.m.
As Dan says :-)
IIRC this was added at a user request.
On 16 Jul 2012, at 08:33, Dan Berindei wrote:
Mircea, I think the idea was to allow users to create a new
CacheManager based on an existing CacheManager, but with some global configuration
changes.
For instance, we could have used it in TestCacheManagerFactory, to allow the user to pass
in a GlobalConfiguration instead of a GlobalConfigurationBuilder to when creating
CacheManagers. Of course, for us it was easy enough to change all the tests to pass in a
GlobalConfigurationBuilder, but I don't really like the caller having to know that the
global configuration will be modified before creating the CacheManager.
Cheers
Dan
On Fri, Jul 13, 2012 at 12:02 PM, Mircea Markus <mircea.markus(a)jboss.com> wrote:
Hi Pete,
Whilst the 'read(template)' method does make sense in the case of cache level
configurations(AbstractConfigurationChildBuilder) in order to override the values from the
default cache, is 'read(template)' in the global configuration also
needed(AbstractGlobalConfigurationBuilder)? We don't use any override mechanism for
global configuration; it also doesn't seem to be used anywhere in the code.
Cheers,
Mircea
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
3:58 p.m.
Thanks Dan, got you.
It would be nice to expose that functionality through an constructor
GlobalConfiguationBuilder:: GlobalConfiguationBuilder(GlobalConfiguration gc);
Currently it is available through the use of the
GlobalConfiguationBuilder:read(GlobalConfiguration) but that's a bit less intuitive
(for me at least).
Wdyt?
On 16 Jul 2012, at 08:33, Dan Berindei wrote:
Mircea, I think the idea was to allow users to create a new
CacheManager based on an existing CacheManager, but with some global configuration
changes.
For instance, we could have used it in TestCacheManagerFactory, to allow the user to pass
in a GlobalConfiguration instead of a GlobalConfigurationBuilder to when creating
CacheManagers. Of course, for us it was easy enough to change all the tests to pass in a
GlobalConfigurationBuilder, but I don't really like the caller having to know that the
global configuration will be modified before creating the CacheManager.
Cheers
Dan
On Fri, Jul 13, 2012 at 12:02 PM, Mircea Markus <mircea.markus(a)jboss.com> wrote:
Hi Pete,
Whilst the 'read(template)' method does make sense in the case of cache level
configurations(AbstractConfigurationChildBuilder) in order to override the values from the
default cache, is 'read(template)' in the global configuration also
needed(AbstractGlobalConfigurationBuilder)? We don't use any override mechanism for
global configuration; it also doesn't seem to be used anywhere in the code.
Cheers,
Mircea
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
4323
days inactive
4327
days old
infinispan-dev@lists.jboss.org
3 comments
3 participants
participants (3)
-
Dan Berindei -
Mircea Markus -
Pete Muir