Ok, regarding today's build failure, please do not add those
dependencies to server in order to fix it as the proper fix should be in
infinispan. This PR solves it:
On Sep 13, 2013, at 10:05 AM, Adrian Nistor
<anistor(a)redhat.com> wrote:
> Hi Galder,
>
> Regarding those two dependencies, the issue appeared after I've made
infinispan-remote-query-client optional in HotRod client this week (see email with subject
"HotRod client dependencies in 6.0.0.Alpha4" [1]).
>
> To fix this now we need to add infinispan-remote-query-client dependency in
testsuite/example-configs/pom.xml as you said, but I don't think we need to add
protostream explicitly because that is a transitive dep of
> infinispan-remote-query-client.
^ That might cos of the order in which errors appeared.
Also IIRC, transitive dependencies might disabled in AS-based builds.
> So the real problem here is that infinispan-remote-query-client is not actually
optional. I believe RemoteCacheManager or RemoteCacheImpl still has a hard dependency to
it. Will investigate asap.
I think you might be missing the point of my email focusing on the specific issue
discovered.
Regardless of what the problem is underneath, anything that's not
infinispan/infinispan is lagging behind when it comes to finding issues with code
submitted by people. That's what really needs addressing, indepedent of the individual
issues.
Cheers,
> Cheers,
> Adrian
>
> [1]
http://markmail.org/message/whumtx7qtvzpdnxf
>
> On 09/13/2013 10:30 AM, Galder Zamarreño wrote:
>> Hey,
>>
>> Infinispan Server CI is failing because REST cache store is not installed. I
guess we need to modify the CI script to build REST cache store before hand too? [1]
>>
>> Also, while trying to replicate some JIRAs in Server, I've spotted two errors
[2] and once that was fixed by adding the dependency to the testsuite pom, then [3]. The
fix is simple, just add these dependencies to testsuite/example-configs/pom.xml:
>>
>> <dependency>
>> <groupId>org.infinispan.protostream</groupId>
>> <artifactId>protostream</artifactId>
>> </dependency>
>> <dependency>
>> <groupId>org.infinispan</groupId>
>> <artifactId>infinispan-remote-query-client</artifactId>
>> </dependency>
>>
>> However, this is very frustrating and slows down resolution of other issues. This
fix is something that should have done when remote querying was added, but it wasn't
because the CI/PR integration didn't caught it.
>>
>> So, we need to rethink CI/PR integration in such way that whenever a PR is sent
to infinispan/infinispan, all potentially depending CIs need to run, which are:
>> - infinispan/infinispan
>> - infinispan/infinispan-server
>> - infinispan/cachestore-*
>>
>> Until that happens, infinispan/infinispan-server and infinispan/cachestore-* are
always gonna be playing catch up :(
>>
>> WRT REST cache store dependency miss, when a PR is sent to
infinispan/infinispan-server, it probably needs to build (but not test)
infinispan/infinispan and infinispan/cachestore-* to make sure all the latest artifacts
are available.
>>
>> Does this make sense? Is this doable in our TeamCity installation?
>>
>> Cheers,
>>
>> [1]
http://ci.infinispan.org/viewLog.html?buildId=3141&buildTypeId=bt11&a...
>> [2]
https://gist.github.com/galderz/61985831e87780cb2ca2
>> [3]
https://gist.github.com/galderz/6897fd8ddfa187754b36
>> --
>> Galder Zamarreño
>> galder(a)redhat.com
>>
twitter.com/galderz
>>
>> Project Lead, Escalante
>>
http://escalante.io
>>
>> Engineer, Infinispan
>>
http://infinispan.org
>>
>>
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev(a)lists.jboss.org
>>
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Galder Zamarreño
galder(a)redhat.com
twitter.com/galderz
Project Lead, Escalante
http://escalante.io
Engineer, Infinispan
http://infinispan.org