On 08/04/2009 12:21 PM, Galder Zamarreno wrote: > Hi, > > I see that Vladimir has started to use things like this in the > javadoc > of some classes: > > @version $Id$ > > In the past, I had loads of issues with this when trying to apply > patches because this information varies from commit to commit and > hence > they cannot be matched :( And personally, I don't they add anything that cannot be retrieved with svn history... > > Thoughts? -- Galder Zamarreño Sr. Software Engineer Infinispan, JBoss Cache _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

I've gone and removed @version javadoc annotations from files containing them.

On 08/04/2009 02:00 PM, Manik Surtani wrote: > Yeah I agree. Lets not use $Id$ as they are pretty meaningless. Any > meaningful info $Id$ exposes can be gleaned using svn log anyway. > > On 4 Aug 2009, at 11:23, Galder Zamarreno wrote: > >> >> >> On 08/04/2009 12:21 PM, Galder Zamarreno wrote: >>> Hi, >>> >>> I see that Vladimir has started to use things like this in the >>> javadoc >>> of some classes: >>> >>> @version $Id$ >>> >>> In the past, I had loads of issues with this when trying to apply >>> patches because this information varies from commit to commit and >>> hence >>> they cannot be matched :( >> >> And personally, I don't they add anything that cannot be retrieved >> with >> svn history... >> >>> >>> Thoughts? >> >> -- >> Galder Zamarreño >> Sr. Software Engineer >> Infinispan, JBoss Cache >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > > -- > Manik Surtani > manik(a)jboss.org > Lead, Infinispan > Lead, JBoss Cache > http://www.infinispan.org > http://www.jbosscache.org > > > > -- Galder Zamarreño Sr. Software Engineer Infinispan, JBoss Cache

It's useful if you have exported source checkouts (maven snapshots, etc), and you want to figure out which version the release is. Although with subversion you don't need it on every file. Perhaps though you want it in your version info string, that way its in the binary too?

Galder Zamarreno wrote: > I've gone and removed @version javadoc annotations from files > containing them. > On 08/04/2009 02:00 PM, Manik Surtani wrote: >> Yeah I agree. Lets not use $Id$ as they are pretty meaningless. >> Any >> meaningful info $Id$ exposes can be gleaned using svn log anyway. >> >> On 4 Aug 2009, at 11:23, Galder Zamarreno wrote: >> >>> >>> On 08/04/2009 12:21 PM, Galder Zamarreno wrote: >>>> Hi, >>>> >>>> I see that Vladimir has started to use things like this in the >>>> javadoc >>>> of some classes: >>>> >>>> @version $Id$ >>>> >>>> In the past, I had loads of issues with this when trying to apply >>>> patches because this information varies from commit to commit >>>> and hence >>>> they cannot be matched :( >>> And personally, I don't they add anything that cannot be >>> retrieved with >>> svn history... >>> >>>> Thoughts? >>> -- >>> Galder Zamarreño >>> Sr. Software Engineer >>> Infinispan, JBoss Cache >>> _______________________________________________ >>> infinispan-dev mailing list >>> infinispan-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> -- >> Manik Surtani >> manik(a)jboss.org >> Lead, Infinispan >> Lead, JBoss Cache >> http://www.infinispan.org >> http://www.jbosscache.org >> >> >> >> -- Jason T. Greene JBoss, a division of Red Hat