4:08 a.m.
During the review of [1] both Pedro and Will asked about whether a field
could be null or not and I really wished I could use some kind of
@NotNull annotation to clarify that. We already have findbugs included
in our maven reports so what do you all think if we adopt those
annotations just like we already do for the jcip ones ?
Tristan
[1] https://github.com/infinispan/infinispan/pull/3726
--
Tristan Tarrant
Infinispan Lead
JBoss, a division of Red Hat
4:53 a.m.
You mean the JSR-305 annotations included in findbugs?
Yes, I think it would be a good idea.
Cheers
Dan
On Fri, Oct 30, 2015 at 11:08 AM, Tristan Tarrant <ttarrant(a)redhat.com> wrote:
During the review of [1] both Pedro and Will asked about whether a
field
could be null or not and I really wished I could use some kind of
@NotNull annotation to clarify that. We already have findbugs included
in our maven reports so what do you all think if we adopt those
annotations just like we already do for the jcip ones ?
Tristan
[1] https://github.com/infinispan/infinispan/pull/3726
--
Tristan Tarrant
Infinispan Lead
JBoss, a division of Red Hat
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
5:15 a.m.
Yes,
although I'd probably not reference JSR-305 since it is dormant :)
Tristan
On 30/10/2015 10:53, Dan Berindei wrote:
You mean the JSR-305 annotations included in findbugs?
Yes, I think it would be a good idea.
Cheers
Dan
On Fri, Oct 30, 2015 at 11:08 AM, Tristan Tarrant <ttarrant(a)redhat.com> wrote:
> During the review of [1] both Pedro and Will asked about whether a field
> could be null or not and I really wished I could use some kind of
> @NotNull annotation to clarify that. We already have findbugs included
> in our maven reports so what do you all think if we adopt those
> annotations just like we already do for the jcip ones ?
>
> Tristan
>
>
> [1] https://github.com/infinispan/infinispan/pull/3726
> --
> Tristan Tarrant
> Infinispan Lead
> JBoss, a division of Red Hat
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Tristan Tarrant
Infinispan Lead
JBoss, a division of Red Hat
4:53 a.m.
+1 from me.
But since we are JDK8 based, how about using Optional for "optional"
parameters and "nothing" for required ones?
On Fri, Oct 30, 2015 at 10:08 AM, Tristan Tarrant <ttarrant(a)redhat.com>
wrote:
During the review of [1] both Pedro and Will asked about whether a
field
could be null or not and I really wished I could use some kind of
@NotNull annotation to clarify that. We already have findbugs included
in our maven reports so what do you all think if we adopt those
annotations just like we already do for the jcip ones ?
Tristan
[1] https://github.com/infinispan/infinispan/pull/3726
--
Tristan Tarrant
Infinispan Lead
JBoss, a division of Red Hat
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
5:18 a.m.
Yes, I did think of that, and I like Optional a lot, but sometimes it is
overkill.
Tristan
On 30/10/2015 10:53, Sebastian Laskawiec wrote:
+1 from me.
But since we are JDK8 based, how about using Optional for "optional"
parameters and "nothing" for required ones?
On Fri, Oct 30, 2015 at 10:08 AM, Tristan Tarrant <ttarrant(a)redhat.com
<mailto:ttarrant@redhat.com>> wrote:
During the review of [1] both Pedro and Will asked about whether a field
could be null or not and I really wished I could use some kind of
@NotNull annotation to clarify that. We already have findbugs included
in our maven reports so what do you all think if we adopt those
annotations just like we already do for the jcip ones ?
Tristan
[1] https://github.com/infinispan/infinispan/pull/3726
--
Tristan Tarrant
Infinispan Lead
JBoss, a division of Red Hat
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org <mailto:infinispan-dev@lists.jboss.org>
https://lists.jboss.org/mailman/listinfo/infinispan-dev
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Tristan Tarrant
Infinispan Lead
JBoss, a division of Red Hat
3124
days inactive
3124
days old
infinispan-dev@lists.jboss.org
4 comments
3 participants
participants (3)
-
Dan Berindei -
Sebastian Laskawiec -
Tristan Tarrant