Sanne's correct. If you are interested, then make a comment on the pull req first on
github.
On 15 Apr 2011, at 16:55, Sanne Grinovero wrote:
that would generate a lot of emails, I'd have to start filtering
out
this list :/
We are supposed to have at least one person to review each patch, ok
the more is better but if someone is not interested we can trust that
the others are doing their best. If I start reviewing a patch in
addition to another reviewer as well because I'm interested, then I
will start receiving emails right?
Cheers,
Sanne
2011/4/15 Galder Zamarreño <galder(a)jboss.org>:
> Hi,
>
> I've noticed that when someone sends a pull req, we all get an email. However,
the moment someone comments, that comment is only received as email by the person who
created the pull req. And if the person that created the pull req replies, only the other
person that commented gets the email.
>
> It'd be much better if all people that can push pull reqs could receive all
emails about comments, cos even though you don't deal with the pull req comment, you
might have something to say about someone's comment.
>
> Thoughts? I'm not sure where this falls, whether in Manik's script or
something that we have to configure in Github
>
> Cheers,
> --
> Galder Zamarreño
> Sr. Software Engineer
> Infinispan, JBoss Cache
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev