Re: [jboss-as7-dev] Request for review: AS7 management additions

This looks ok, except in the OSGiSubsystemProviders.OSGI_MODULES_REMOVE the operation name is set to ADD instead of the intended REMOVE. Re: + // TODO what is this one used for? static final DescriptionProvider SUBSYSTEM_ADD = new DescriptionProvider() { When the config is parsed and it finds the osgi subsystem element, your parser generates an add operation with address subsystem=osgi and whatever parameters that operation takes. The SUBSYSTEM_ADD above is meant to describe those parameters (it currently doesn't). The OSGiSubsystemAdd handler then handles the operation. You're pulling some of the stuff currently handled by OSGiSubsystemAdd out into a separate child resource, so the OSGiSubsystemAdd logic will need to be updated to reflect that. On 5/31/11 7:22 AM, David Bosschaert wrote: -- Brian Stansberry Principal Software Engineer JBoss by Red Hat