7:22 a.m.
Hi all,
I'm currently learning the AS7 management API so I can work on providing additional
management functionality.
As a start, I've extended the OSGi management API so that a pre-loaded module can be
added/removed.
Before I go add more stuff to this I would appreciate if someone could quickly review what
I did, just to make sure I didn't miss anything...
The changes are this branch:
https://github.com/bosschaert/jboss-as/commit/ba78cf975ba86a7cba9a195f001...
Thanks!
David
11:22 a.m.
This looks ok, except in the OSGiSubsystemProviders.OSGI_MODULES_REMOVE
the operation name is set to ADD instead of the intended REMOVE.
Re:
+ // TODO what is this one used for?
static final DescriptionProvider SUBSYSTEM_ADD = new
DescriptionProvider() {
When the config is parsed and it finds the osgi subsystem element, your
parser generates an add operation with address subsystem=osgi and
whatever parameters that operation takes. The SUBSYSTEM_ADD above is
meant to describe those parameters (it currently doesn't). The
OSGiSubsystemAdd handler then handles the operation.
You're pulling some of the stuff currently handled by OSGiSubsystemAdd
out into a separate child resource, so the OSGiSubsystemAdd logic will
need to be updated to reflect that.
On 5/31/11 7:22 AM, David Bosschaert wrote:
Hi all,
I'm currently learning the AS7 management API so I can work on providing additional
management functionality.
As a start, I've extended the OSGi management API so that a pre-loaded module can be
added/removed.
Before I go add more stuff to this I would appreciate if someone could quickly review
what I did, just to make sure I didn't miss anything...
The changes are this branch:
https://github.com/bosschaert/jboss-as/commit/ba78cf975ba86a7cba9a195f001...
Thanks!
David
_______________________________________________
jboss-as7-dev mailing list
jboss-as7-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
--
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat
2:11 p.m.
Thanks Brian!
This looks ok, except in the
OSGiSubsystemProviders.OSGI_MODULES_REMOVE
the operation name is set to ADD instead of the intended REMOVE.
Well spotted (thanks!) and this actually brings me to my next question: where are these
DescriptionProviders used? I see that it even provides i18n-capable descriptions but at
least using jboss-admin.sh I couldn't figure out how to get this info out. Is there
also a relation to any .xsd file out there that contains the same information?
Cheers,
David
----- Original Message -----
> From: "Brian Stansberry" <brian.stansberry(a)redhat.com>
> To: jboss-as7-dev(a)lists.jboss.org
> Sent: Tuesday, 31 May, 2011 5:22:36 PM
> Subject: Re: [jboss-as7-dev] Request for review: AS7 management additions
>
This looks ok, except in the
OSGiSubsystemProviders.OSGI_MODULES_REMOVE
the operation name is set to ADD instead of the intended REMOVE.
>
> Re:
>
> + // TODO what is this one used for?
> static final DescriptionProvider SUBSYSTEM_ADD = new
> DescriptionProvider() {
>
> When the config is parsed and it finds the osgi subsystem element,
> your
> parser generates an add operation with address subsystem=osgi and
> whatever parameters that operation takes. The SUBSYSTEM_ADD above is
> meant to describe those parameters (it currently doesn't). The
> OSGiSubsystemAdd handler then handles the operation.
>
> You're pulling some of the stuff currently handled by OSGiSubsystemAdd
> out into a separate child resource, so the OSGiSubsystemAdd logic will
> need to be updated to reflect that.
>
>
> On 5/31/11 7:22 AM, David Bosschaert wrote:
> > Hi all,
> >
> > I'm currently learning the AS7 management API so I can work on
> > providing additional management functionality.
> > As a start, I've extended the OSGi management API so that a
> > pre-loaded module can be added/removed.
> >
> > Before I go add more stuff to this I would appreciate if someone
> > could quickly review what I did, just to make sure I didn't miss
> > anything...
> >
> > The changes are this branch:
> >
https://github.com/bosschaert/jboss-as/commit/ba78cf975ba86a7cba9a195f001...
> >
> > Thanks!
> >
> > David
> > _______________________________________________
> > jboss-as7-dev mailing list
> > jboss-as7-dev(a)lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>
>
> --
> Brian Stansberry
> Principal Software Engineer
> JBoss by Red Hat
> _______________________________________________
> jboss-as7-dev mailing list
> jboss-as7-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
4:10 p.m.
On 5/31/11 2:11 PM, David Bosschaert wrote:
Thanks Brian!
> This looks ok, except in the
> OSGiSubsystemProviders.OSGI_MODULES_REMOVE
> the operation name is set to ADD instead of the intended REMOVE.
Well spotted (thanks!) and this actually brings me to my next question: where are these
DescriptionProviders used? I see that it even provides i18n-capable descriptions but at
least using jboss-admin.sh I couldn't figure out how to get this info out. Is there
also a relation to any .xsd file out there that contains the same information?
The descriptions are accessible via the read-resource-description
operation, which is available by default on every resource.
http://fpaste.org/HOPF/ shows executing that against the deployment
scanner, both in its base form and with a couple params set.
Unfortunately, there's no tooling to generate this stuff from the xsd at
this point.
Cheers,
David
----- Original Message -----
> From: "Brian Stansberry"<brian.stansberry(a)redhat.com>
> To: jboss-as7-dev(a)lists.jboss.org
> Sent: Tuesday, 31 May, 2011 5:22:36 PM
> Subject: Re: [jboss-as7-dev] Request for review: AS7 management additions
>
> This looks ok, except in the
> OSGiSubsystemProviders.OSGI_MODULES_REMOVE
> the operation name is set to ADD instead of the intended REMOVE.
>
> Re:
>
> + // TODO what is this one used for?
> static final DescriptionProvider SUBSYSTEM_ADD = new
> DescriptionProvider() {
>
> When the config is parsed and it finds the osgi subsystem element,
> your
> parser generates an add operation with address subsystem=osgi and
> whatever parameters that operation takes. The SUBSYSTEM_ADD above is
> meant to describe those parameters (it currently doesn't). The
> OSGiSubsystemAdd handler then handles the operation.
>
> You're pulling some of the stuff currently handled by OSGiSubsystemAdd
> out into a separate child resource, so the OSGiSubsystemAdd logic will
> need to be updated to reflect that.
>
>
> On 5/31/11 7:22 AM, David Bosschaert wrote:
>> Hi all,
>>
>> I'm currently learning the AS7 management API so I can work on
>> providing additional management functionality.
>> As a start, I've extended the OSGi management API so that a
>> pre-loaded module can be added/removed.
>>
>> Before I go add more stuff to this I would appreciate if someone
>> could quickly review what I did, just to make sure I didn't miss
>> anything...
>>
>> The changes are this branch:
>>
https://github.com/bosschaert/jboss-as/commit/ba78cf975ba86a7cba9a195f001...
>>
>> Thanks!
>>
>> David
>> _______________________________________________
>> jboss-as7-dev mailing list
>> jboss-as7-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>
>
> --
> Brian Stansberry
> Principal Software Engineer
> JBoss by Red Hat
> _______________________________________________
> jboss-as7-dev mailing list
> jboss-as7-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
--
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat
8:12 a.m.
----- Original Message -----
From: "Brian Stansberry"
<brian.stansberry(a)redhat.com>
To: "David Bosschaert" <david(a)redhat.com>
Cc: jboss-as7-dev(a)lists.jboss.org
Sent: Tuesday, 31 May, 2011 10:10:04 PM
Subject: Re: [jboss-as7-dev] Request for review: AS7 management additions
On 5/31/11 2:11 PM, David Bosschaert wrote:
The descriptions are accessible via the read-resource-description
operation, which is available by default on every resource.
http://fpaste.org/HOPF/ shows executing that against the deployment
scanner, both in its base form and with a couple params set.
Ok - that works :) and I see from the other thread that the plan is to use these
descriptions to validate at some point in the future which would be really good.
Unfortunately, there's no tooling to generate this stuff from the
xsd
at this point.
It shouldn't be too hard to at least create a one-way generator that produces these
ModelDescriptions from an .xsd source. AFAICS xsd can express pretty much all that's
needed here (and if it doesn't you can always use custom xsd annotations).
I guess I always get a little nervous when the same info is expressed in multiple places
without a clear link between then...
Cheers,
David
1:35 a.m.
What is the ultimate purpose of this? AFAICS this would add a module to
the osgi subsystem description, which could on subsystem startup provide
packages that are available on the osgi system classloader. These
packages would however only be visible if corresponding export
statements are defined too.
From an osgi subsystem management perspective, I'd think it is more
useful to provide management functionality like start/stop of a bundle.
Another obvious candidate would be the management of ConfigAdmin properties.
cheers
-thomas
On 05/31/2011 02:22 PM, David Bosschaert wrote:
Hi all,
I'm currently learning the AS7 management API so I can work on providing additional
management functionality.
As a start, I've extended the OSGi management API so that a pre-loaded module can be
added/removed.
Before I go add more stuff to this I would appreciate if someone could quickly review
what I did, just to make sure I didn't miss anything...
The changes are this branch:
https://github.com/bosschaert/jboss-as/commit/ba78cf975ba86a7cba9a195f001...
Thanks!
David
_______________________________________________
jboss-as7-dev mailing list
jboss-as7-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
2 a.m.
Hi Thomas,
If you look at the management console (and jboss-admin.sh) you'll see that it provides
an interface to control the static information that is configured in
standalone.xml/domain.xml as well as a way to interact with the dynamic information in the
runtime.
When I started looking at the management stuff in OSGi I noticed that the way the static
configuration is currently provided is quite different from other subsystems, and it's
read-only: it doesn't support changes through the console.
So this piece has a couple of purposes:
* Make the OSGi-Management API conformant with the other Management API's
* Make the OSGi configuration editable throught the console
* For me to learn this stuff :)
Yes, I agree, the bundle level runtime API (start/stop) etc should and will also be done.
Cheers,
David
----- Original Message -----
From: "Thomas Diesler" <thomas.diesler(a)jboss.com>
To: "David Bosschaert" <david(a)redhat.com>
Cc: jboss-as7-dev(a)lists.jboss.org
Sent: Wednesday, 1 June, 2011 7:35:49 AM
Subject: Re: [jboss-as7-dev] Request for review: AS7 management additions
What is the ultimate purpose of this? AFAICS this would add a module
to
the osgi subsystem description, which could on subsystem startup
provide
packages that are available on the osgi system classloader. These
packages would however only be visible if corresponding export
statements are defined too.
From an osgi subsystem management perspective, I'd think it is more
useful to provide management functionality like start/stop of a
bundle.
Another obvious candidate would be the management of ConfigAdmin
properties.
cheers
-thomas
On 05/31/2011 02:22 PM, David Bosschaert wrote:
> Hi all,
>
> I'm currently learning the AS7 management API so I can work on
> providing additional management functionality.
> As a start, I've extended the OSGi management API so that a
> pre-loaded module can be added/removed.
>
> Before I go add more stuff to this I would appreciate if someone
> could quickly review what I did, just to make sure I didn't miss
> anything...
>
> The changes are this branch:
>
https://github.com/bosschaert/jboss-as/commit/ba78cf975ba86a7cba9a195f001...
>
> Thanks!
>
> David
> _______________________________________________
> jboss-as7-dev mailing list
> jboss-as7-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
--
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Thomas Diesler
JBoss OSGi Lead
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
2:21 a.m.
Yes, thats a good point: static configuration vs. Runtime changes. Typically you would
expect the later from a management tool, but we do actually provide the means to modify
the "static" configuration as well. To make this distinction more clear, we are
going to provide operation response headers that indicate if the changes have been applied
at runtime or if a server reboot is necessary. Brian is currently working on that.
On Jun 1, 2011, at 9:00, David Bosschaert <david(a)redhat.com> wrote:
Hi Thomas,
If you look at the management console (and jboss-admin.sh) you'll see that it
provides an interface to control the static information that is configured in
standalone.xml/domain.xml as well as a way to interact with the dynamic information in the
runtime.
When I started looking at the management stuff in OSGi I noticed that the way the static
configuration is currently provided is quite different from other subsystems, and it's
read-only: it doesn't support changes through the console.
So this piece has a couple of purposes:
* Make the OSGi-Management API conformant with the other Management API's
* Make the OSGi configuration editable throught the console
* For me to learn this stuff :)
Yes, I agree, the bundle level runtime API (start/stop) etc should and will also be
done.
Cheers,
David
----- Original Message -----
> From: "Thomas Diesler" <thomas.diesler(a)jboss.com>
> To: "David Bosschaert" <david(a)redhat.com>
> Cc: jboss-as7-dev(a)lists.jboss.org
> Sent: Wednesday, 1 June, 2011 7:35:49 AM
> Subject: Re: [jboss-as7-dev] Request for review: AS7 management additions
>
> What is the ultimate purpose of this? AFAICS this would add a module
> to
> the osgi subsystem description, which could on subsystem startup
> provide
> packages that are available on the osgi system classloader. These
> packages would however only be visible if corresponding export
> statements are defined too.
>
> From an osgi subsystem management perspective, I'd think it is more
> useful to provide management functionality like start/stop of a
> bundle.
> Another obvious candidate would be the management of ConfigAdmin
> properties.
>
> cheers
> -thomas
>
> On 05/31/2011 02:22 PM, David Bosschaert wrote:
>> Hi all,
>>
>> I'm currently learning the AS7 management API so I can work on
>> providing additional management functionality.
>> As a start, I've extended the OSGi management API so that a
>> pre-loaded module can be added/removed.
>>
>> Before I go add more stuff to this I would appreciate if someone
>> could quickly review what I did, just to make sure I didn't miss
>> anything...
>>
>> The changes are this branch:
>>
https://github.com/bosschaert/jboss-as/commit/ba78cf975ba86a7cba9a195f001...
>>
>> Thanks!
>>
>> David
>> _______________________________________________
>> jboss-as7-dev mailing list
>> jboss-as7-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>
> --
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Thomas Diesler
> JBoss OSGi Lead
> JBoss, a division of Red Hat
> xxxxxxxxxxxxxxxxxxxxxxxxxxxx
_______________________________________________
jboss-as7-dev mailing list
jboss-as7-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
5439
days inactive
5440
days old
7 comments
4 participants
participants (4)
-
Brian Stansberry -
David Bosschaert -
Heiko Braun -
Thomas Diesler