[JBoss JIRA] (WFCORE-3393) Connection Timeout should take into account time spent in opening the channel
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3393?page=com.atlassian.jira.plugi... ]
Brian Stansberry commented on WFCORE-3393:
------------------------------------------
The relevant code is all in the protocol module though, which makes this more feasible.
> Connection Timeout should take into account time spent in opening the channel
> -----------------------------------------------------------------------------
>
> Key: WFCORE-3393
> URL: https://issues.jboss.org/browse/WFCORE-3393
> Project: WildFly Core
> Issue Type: Enhancement
> Components: Domain Management
> Reporter: Jean-Francois Denise
> Assignee: Brian Stansberry
>
> This applies to the protocol module. The timeout is :https://github.com/wildfly/wildfly-core/blob/master/protocol/src/main/java/org/jboss/as/protocol/mgmt/FutureManagementChannel.java#L154
> The connection timeout applies to protocol establishment only, an hardcoded timeout of 10 seconds is dedicated to the channel.open.
> This can create an unexpected behaviour in case we have a fast connection establishment and for some reason (as seen in JBEAP-11859) a slow channel open. Whatever the timeout in use, 10 seconds is what the user will get.
> In order to offer a coherent timeout, the time that remains after the connection establishment should be dedicated to the channel open. If we want to keep existing behaviour, if the remaining is less than 10 seconds, then 10 seconds should be used.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (WFCORE-3393) Connection Timeout should take into account time spent in opening the channel
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3393?page=com.atlassian.jira.plugi... ]
Brian Stansberry commented on WFCORE-3393:
------------------------------------------
[~jdenise] Thanks. That looks tricky, as that logic is called from far away from any overall timeout setting.
> Connection Timeout should take into account time spent in opening the channel
> -----------------------------------------------------------------------------
>
> Key: WFCORE-3393
> URL: https://issues.jboss.org/browse/WFCORE-3393
> Project: WildFly Core
> Issue Type: Enhancement
> Components: Domain Management
> Reporter: Jean-Francois Denise
> Assignee: Brian Stansberry
>
> This applies to the protocol module. The timeout is :https://github.com/wildfly/wildfly-core/blob/master/protocol/src/main/java/org/jboss/as/protocol/mgmt/FutureManagementChannel.java#L154
> The connection timeout applies to protocol establishment only, an hardcoded timeout of 10 seconds is dedicated to the channel.open.
> This can create an unexpected behaviour in case we have a fast connection establishment and for some reason (as seen in JBEAP-11859) a slow channel open. Whatever the timeout in use, 10 seconds is what the user will get.
> In order to offer a coherent timeout, the time that remains after the connection establishment should be dedicated to the channel open. If we want to keep existing behaviour, if the remaining is less than 10 seconds, then 10 seconds should be used.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (WFCORE-3393) Connection Timeout should take into account time spent in opening the channel
by Jean-Francois Denise (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3393?page=com.atlassian.jira.plugi... ]
Jean-Francois Denise updated WFCORE-3393:
-----------------------------------------
Description:
This applies to the protocol module. The timeout is :https://github.com/wildfly/wildfly-core/blob/master/protocol/src/main/java/org/jboss/as/protocol/mgmt/FutureManagementChannel.java#L154
The connection timeout applies to protocol establishment only, an hardcoded timeout of 10 seconds is dedicated to the channel.open.
This can create an unexpected behaviour in case we have a fast connection establishment and for some reason (as seen in JBEAP-11859) a slow channel open. Whatever the timeout in use, 10 seconds is what the user will get.
In order to offer a coherent timeout, the time that remains after the connection establishment should be dedicated to the channel open. If we want to keep existing behaviour, if the remaining is less than 10 seconds, then 10 seconds should be used.
was:
The connection timeout applies to protocol establishment only, an hardcoded timeout of 10 seconds is dedicated to the channel.open.
This can create an unexpected behaviour in case we have a fast connection establishment and for some reason (as seen in JBEAP-11859) a slow channel open. Whatever the timeout in use, 10 seconds is what the user will get.
In order to offer a coherent timeout, the time that remains after the connection establishment should be dedicated to the channel open. If we want to keep existing behaviour, if the remaining is less than 10 seconds, then 10 seconds should be used.
> Connection Timeout should take into account time spent in opening the channel
> -----------------------------------------------------------------------------
>
> Key: WFCORE-3393
> URL: https://issues.jboss.org/browse/WFCORE-3393
> Project: WildFly Core
> Issue Type: Enhancement
> Components: Domain Management
> Reporter: Jean-Francois Denise
> Assignee: Brian Stansberry
>
> This applies to the protocol module. The timeout is :https://github.com/wildfly/wildfly-core/blob/master/protocol/src/main/java/org/jboss/as/protocol/mgmt/FutureManagementChannel.java#L154
> The connection timeout applies to protocol establishment only, an hardcoded timeout of 10 seconds is dedicated to the channel.open.
> This can create an unexpected behaviour in case we have a fast connection establishment and for some reason (as seen in JBEAP-11859) a slow channel open. Whatever the timeout in use, 10 seconds is what the user will get.
> In order to offer a coherent timeout, the time that remains after the connection establishment should be dedicated to the channel open. If we want to keep existing behaviour, if the remaining is less than 10 seconds, then 10 seconds should be used.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (WFCORE-3393) Connection Timeout should take into account time spent in opening the channel
by Jean-Francois Denise (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3393?page=com.atlassian.jira.plugi... ]
Jean-Francois Denise commented on WFCORE-3393:
----------------------------------------------
[~brian.stansberry], I updated the description.
> Connection Timeout should take into account time spent in opening the channel
> -----------------------------------------------------------------------------
>
> Key: WFCORE-3393
> URL: https://issues.jboss.org/browse/WFCORE-3393
> Project: WildFly Core
> Issue Type: Enhancement
> Components: Domain Management
> Reporter: Jean-Francois Denise
> Assignee: Brian Stansberry
>
> This applies to the protocol module. The timeout is :https://github.com/wildfly/wildfly-core/blob/master/protocol/src/main/java/org/jboss/as/protocol/mgmt/FutureManagementChannel.java#L154
> The connection timeout applies to protocol establishment only, an hardcoded timeout of 10 seconds is dedicated to the channel.open.
> This can create an unexpected behaviour in case we have a fast connection establishment and for some reason (as seen in JBEAP-11859) a slow channel open. Whatever the timeout in use, 10 seconds is what the user will get.
> In order to offer a coherent timeout, the time that remains after the connection establishment should be dedicated to the channel open. If we want to keep existing behaviour, if the remaining is less than 10 seconds, then 10 seconds should be used.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (WFCORE-3393) Connection Timeout should take into account time spent in opening the channel
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3393?page=com.atlassian.jira.plugi... ]
Brian Stansberry commented on WFCORE-3393:
------------------------------------------
Where is this 10 set?
> Connection Timeout should take into account time spent in opening the channel
> -----------------------------------------------------------------------------
>
> Key: WFCORE-3393
> URL: https://issues.jboss.org/browse/WFCORE-3393
> Project: WildFly Core
> Issue Type: Enhancement
> Components: Domain Management
> Reporter: Jean-Francois Denise
> Assignee: Brian Stansberry
>
> The connection timeout applies to protocol establishment only, an hardcoded timeout of 10 seconds is dedicated to the channel.open.
> This can create an unexpected behaviour in case we have a fast connection establishment and for some reason (as seen in JBEAP-11859) a slow channel open. Whatever the timeout in use, 10 seconds is what the user will get.
> In order to offer a coherent timeout, the time that remains after the connection establishment should be dedicated to the channel open. If we want to keep existing behaviour, if the remaining is less than 10 seconds, then 10 seconds should be used.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months
[JBoss JIRA] (WFCORE-3393) Connection Timeout should take into account time spent in opening the channel
by Jean-Francois Denise (JIRA)
Jean-Francois Denise created WFCORE-3393:
--------------------------------------------
Summary: Connection Timeout should take into account time spent in opening the channel
Key: WFCORE-3393
URL: https://issues.jboss.org/browse/WFCORE-3393
Project: WildFly Core
Issue Type: Enhancement
Components: Domain Management
Reporter: Jean-Francois Denise
Assignee: Brian Stansberry
The connection timeout applies to protocol establishment only, an hardcoded timeout of 10 seconds is dedicated to the channel.open.
This can create an unexpected behaviour in case we have a fast connection establishment and for some reason (as seen in JBEAP-11859) a slow channel open. Whatever the timeout in use, 10 seconds is what the user will get.
In order to offer a coherent timeout, the time that remains after the connection establishment should be dedicated to the channel open. If we want to keep existing behaviour, if the remaining is less than 10 seconds, then 10 seconds should be used.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
6 years, 5 months