[JBoss JIRA] (DROOLS-2051) Data-driven enumerations fail when other enumerations do not exist
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2051?page=com.atlassian.jira.plugi... ]
Michael Anstis reassigned DROOLS-2051:
--------------------------------------
Project: Drools (was: Guvnor)
Key: DROOLS-2051 (was: GUVNOR-1731)
Workflow: GIT Pull Request workflow (was: classic default workflow)
Component/s: Enumerations Editor
(was: Enumerations)
Assignee: Michael Anstis
> Data-driven enumerations fail when other enumerations do not exist
> ------------------------------------------------------------------
>
> Key: DROOLS-2051
> URL: https://issues.jboss.org/browse/DROOLS-2051
> Project: Drools
> Issue Type: Feature Request
> Components: Enumerations Editor
> Reporter: G Patel
> Assignee: Michael Anstis
>
> *Moved from https://issues.jboss.org/browse/JBRULES-3270*
> Currently, the following enumeration requires an enumeration on engineType to work correctly:
> 'Vehicle.fuelType[engineType]' : '(new test.VehicleHelper()).getFuelTypes("@{engineType}")'
> Without an enumeration on engineType, the above fuelType enumeration does not work. Drools should not require an enumeration on engineType, as it may not always be needed.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (DROOLS-2052) Graphical Enum editor
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2052?page=com.atlassian.jira.plugi... ]
Michael Anstis reassigned DROOLS-2052:
--------------------------------------
Project: Drools (was: Guvnor)
Key: DROOLS-2052 (was: GUVNOR-222)
Workflow: GIT Pull Request workflow (was: classic default workflow)
Component/s: Enumerations Editor
(was: Enumerations)
Affects Version/s: 5.5.0.Final
(was: drools-5.0.0.CR1)
Assignee: Michael Anstis (was: Eveliina Rikkola)
> Graphical Enum editor
> ---------------------
>
> Key: DROOLS-2052
> URL: https://issues.jboss.org/browse/DROOLS-2052
> Project: Drools
> Issue Type: Feature Request
> Components: Enumerations Editor
> Affects Versions: 5.5.0.Final
> Reporter: Michael Neale
> Assignee: Michael Anstis
>
> Would be very nice to have a enum config editor GUI (with helper wizards to get it right).
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (DROOLS-2053) Make rule context available to enumeration loaders
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2053?page=com.atlassian.jira.plugi... ]
Michael Anstis reassigned DROOLS-2053:
--------------------------------------
Project: Drools (was: Guvnor)
Key: DROOLS-2053 (was: GUVNOR-1730)
Workflow: GIT Pull Request workflow (was: classic default workflow)
Component/s: Enumerations Editor
(was: Enumerations)
Assignee: Michael Anstis
> Make rule context available to enumeration loaders
> --------------------------------------------------
>
> Key: DROOLS-2053
> URL: https://issues.jboss.org/browse/DROOLS-2053
> Project: Drools
> Issue Type: Feature Request
> Components: Enumerations Editor
> Reporter: G Patel
> Assignee: Michael Anstis
>
> *Moved from https://issues.jboss.org/browse/JBRULES-3271*
> Currently, only fact field names are passed into data enumeration loaders. Sometimes, the enumeration list might need to change based on details about the rule being edited, like rule metadata or package name, etc. The request is to make the Rule object (along with all of it's metadata) available to data enumeration loaders. Perhaps have loaders implement the following interface:
> public interface EnumLoader{ public List<String> loadEnum(Rule r, String... dependentFields); }
> This will enable support for more contextual enum lists. Very helpful for folks trying to integrate the standalone rule editor into applications.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (DROOLS-2049) Remove private void checkMarshallingUsingDsl method
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2049?page=com.atlassian.jira.plugi... ]
Michael Anstis moved GUVNOR-3519 to DROOLS-2049:
------------------------------------------------
Project: Drools (was: Guvnor)
Key: DROOLS-2049 (was: GUVNOR-3519)
Workflow: GIT Pull Request workflow (was: classic default workflow)
Component/s: DSLs Editor
(was: DSL)
Affects Version/s: 7.3.0.Final
(was: 7.3.0.Final)
> Remove private void checkMarshallingUsingDsl method
> ---------------------------------------------------
>
> Key: DROOLS-2049
> URL: https://issues.jboss.org/browse/DROOLS-2049
> Project: Drools
> Issue Type: Task
> Components: DSLs Editor
> Affects Versions: 7.3.0.Final
> Reporter: Jozef Marko
> Assignee: Jozef Marko
>
> The [testclass|https://github.com/kiegroup/drools/blob/master/drools-workbench...] contains methods shown bellow. There is potential error in tests that expect checkMarshallingUsingDsl will behave differently from checkMarshalling. This checkMarshallingUsingDsl should be removed and tests which use it should be rewritten.
> {code:java}
> private void checkMarshalling(String expected,
> RuleModel m) {
> String drl = ruleModelPersistence.marshal(m);
> assertNotNull(drl);
> if (expected != null) {
> assertEqualsIgnoreWhitespace(expected,
> drl);
> }
> }
> private void checkMarshallingUsingDsl(String expected,
> RuleModel m) {
> String drl = ruleModelPersistence.marshal(m);
> assertNotNull(drl);
> if (expected != null) {
> assertEqualsIgnoreWhitespace(expected,
> drl);
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (DROOLS-2043) Guided Rule Editor does not support Magic Characters in DSLs
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2043?page=com.atlassian.jira.plugi... ]
Michael Anstis moved GUVNOR-2039 to DROOLS-2043:
------------------------------------------------
Project: Drools (was: Guvnor)
Key: DROOLS-2043 (was: GUVNOR-2039)
Workflow: GIT Pull Request workflow (was: classic default workflow)
Component/s: DSLs Editor
(was: DSL)
Affects Version/s: 5.5.0.Final
(was: drools-5.5.0.Final)
> Guided Rule Editor does not support Magic Characters in DSLs
> ------------------------------------------------------------
>
> Key: DROOLS-2043
> URL: https://issues.jboss.org/browse/DROOLS-2043
> Project: Drools
> Issue Type: Bug
> Components: DSLs Editor
> Affects Versions: 5.5.0.Final
> Reporter: Hendrik Wouters
> Labels: dsl, guided_editor, guvnor, magic_characters, regex
>
> Validation of a DSL rule in the guided editor fails when the DSL contains regex magic characters, such as '?'.
> Example DSL:
> [when]Assignment "{$assignment}" is {numberOfDays} days? overdue = {$assignment}: Assignment( hasDeadline before daysAgo({numberOfDays}) )
> In the textual rule editor, this works fine:
> - Assignment "$a" is 1 day overdue
> - Assignment "$b" is 2 days overdue
> In the guided rule editor, it doesnt. Magic characters appear to be ignored, and no match with the DSL is made.
> Verification gives the following errors:
> [Assignment Overdue (Guided DSL)] [ERR 102] Line 5:13 mismatched input '"$assignment"' in rule "Assignment Overdue (Guided DSL)"
> [Assignment Overdue (Guided DSL)] Parser returned a null Package
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (DROOLS-2044) Guvnor translated DSL does not change the first letter of the bean property to lower case in certain cases
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2044?page=com.atlassian.jira.plugi... ]
Michael Anstis moved GUVNOR-2007 to DROOLS-2044:
------------------------------------------------
Project: Drools (was: Guvnor)
Key: DROOLS-2044 (was: GUVNOR-2007)
Workflow: GIT Pull Request workflow (was: classic default workflow)
Component/s: DSLs Editor
(was: DSL)
Affects Version/s: 5.5.0.Final
(was: drools-5.5.0.Final)
> Guvnor translated DSL does not change the first letter of the bean property to lower case in certain cases
> ----------------------------------------------------------------------------------------------------------
>
> Key: DROOLS-2044
> URL: https://issues.jboss.org/browse/DROOLS-2044
> Project: Drools
> Issue Type: Bug
> Components: DSLs Editor
> Affects Versions: 5.5.0.Final
> Reporter: Xiandong su
> Attachments: GuvnorCase-0.0.1-SNAPSHOT.jar, GuvnorCase.zip, screen.png
>
>
> When the bean property in a java class starts multiple upper cases letters, Guvnor generated DSL code does not change the first letter to lower case as it should do. Because of this, the generated DSL can not be run
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (DROOLS-2045) DSLs from other packages in current project should be visible when editing a Guided Rule (With DSL)
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2045?page=com.atlassian.jira.plugi... ]
Michael Anstis moved GUVNOR-2263 to DROOLS-2045:
------------------------------------------------
Project: Drools (was: Guvnor)
Key: DROOLS-2045 (was: GUVNOR-2263)
Workflow: GIT Pull Request workflow (was: classic default workflow)
Component/s: DSLs Editor
(was: DSL)
Steps to Reproduce: (was: 1- Create a repository on the Workbench.
2- Create a project on the creaed repo on the Workbench.
3- Create two packages on the project (pkg1 and pkg2)
4- Create the following DSL expression on pkg1:
[when]There is a string {str}= String(this == "{str}")
5- Create the following DSL expression on pkg2:
[when]There is a {value}= Number(intValue == {value})
6- Create a Guided Rule (with DSL) on pkg1: While adding DSL expressions, you will only see "There is a string {str}" as an option for the conditions. Add that condition and replace "str" with "1"
7- Click on "validate" on the rule: You will receive a "Mismatched input 'string' on line 6" because it is using the DSL expression from the other package
If you clone this repo and compile it locally with "mvn clean package", you might have the same error.)
Affects Version/s: 6.3.0.Beta2
(was: drools_6.3.0.Beta2)
Workaround Description: (was: For the moment, keeping DSL files repeated and aligned among different packages allow us to work on this issue. However, it will be simpler to just have all DSL expressions from all packages accessible from the Guided Rule (with DSL) options, since they will be used when compiling the rules anyway)
> DSLs from other packages in current project should be visible when editing a Guided Rule (With DSL)
> ---------------------------------------------------------------------------------------------------
>
> Key: DROOLS-2045
> URL: https://issues.jboss.org/browse/DROOLS-2045
> Project: Drools
> Issue Type: Enhancement
> Components: DSLs Editor
> Affects Versions: 6.3.0.Beta2
> Reporter: Mariano Nicolas De Maio
>
> When creating a a Guided Rule (With DSL), only DSL expressions defined in the current package are shown to be added in the editor. This doesn't seem to be a desired feature, since when you click "Validate" on said rule, it seems to be compiling the rule using DSL expressions of other packages as well.
> The same behavior is later on seen when compiling rules with "Build and Deploy" from the project editor.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (DROOLS-2046) DSL Editor: Grid based editor for DSLs
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2046?page=com.atlassian.jira.plugi... ]
Michael Anstis moved GUVNOR-221 to DROOLS-2046:
-----------------------------------------------
Project: Drools (was: Guvnor)
Key: DROOLS-2046 (was: GUVNOR-221)
Workflow: GIT Pull Request workflow (was: classic default workflow)
Component/s: DSLs Editor
(was: DSL)
Affects Version/s: 5.5.0.Final
(was: drools-5.0.0.CR1)
> DSL Editor: Grid based editor for DSLs
> --------------------------------------
>
> Key: DROOLS-2046
> URL: https://issues.jboss.org/browse/DROOLS-2046
> Project: Drools
> Issue Type: Feature Request
> Components: DSLs Editor
> Affects Versions: 5.5.0.Final
> Reporter: Michael Neale
> Priority: Minor
>
> Would be nice to have a editor like the eclipse one, perhaps even smarter (with some wizards to help out).
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (DROOLS-2047) Guided Editor: Nested DSL UI Suggestion
by Michael Anstis (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2047?page=com.atlassian.jira.plugi... ]
Michael Anstis moved GUVNOR-1190 to DROOLS-2047:
------------------------------------------------
Project: Drools (was: Guvnor)
Key: DROOLS-2047 (was: GUVNOR-1190)
Workflow: GIT Pull Request workflow (was: classic default workflow)
Component/s: DSLs Editor
(was: DSL)
> Guided Editor: Nested DSL UI Suggestion
> ---------------------------------------
>
> Key: DROOLS-2047
> URL: https://issues.jboss.org/browse/DROOLS-2047
> Project: Drools
> Issue Type: Feature Request
> Components: DSLs Editor
> Reporter: Brad Davis
> Assignee: Michael Anstis
> Priority: Minor
> Attachments: current-fact-entry.jpg, future-nested-condition-entry.jpg
>
>
> When there is a large set of DSL, with nested statements, the UI for Rules creation becomes cluttered. I propose that we change the simple List to a expandable table structure for Fact Assertion.
> For Example,
> [when]There is a Patient with Cholesterol Readings=$c : Cholesterol()
> [when]-With the Gender {gender}=patient.gender=="{gender}"
> [when]-With Age Between {lower:[0-9]+} and {upper}=patient.age <= {lower}, patient.age >= {upper}
> [when]-With Cholesterol of {cholesterol} mg/dl or above=mgdl >={cholesterol}
> [when]-With Cholesterol of {cholesterol} mg/dl or below=mgdl <={cholesterol}
> [when]-With Cholesterol between {lower} mg/dl and {upper} mg/dl=mgdl >={lower}, mgdl<={upper}
> This leads to fact entry such as the screenshot attached. As you can imagine, creating rules with many DSLs would become overwhelming quickly to sort through. I think maybe we should use a Tree view instead of a list here. This would allow you to drill down to nested DSL statements. Also, when creating a child of the DSL statement, only the children DRL statements should be displayed on the screen.
> Attached are the current entry, and a mockup of how I would like to see this working in the future. I think it could simplify and organize the fact creation quite a bit.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months