[JBoss JIRA] (WFLY-8025) Alternatives attribute "domain" doesn't exist in modcluster subsystem
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/WFLY-8025?page=com.atlassian.jira.plugin.... ]
Radoslav Husar updated WFLY-8025:
---------------------------------
Affects Version/s: 10.1.0.Final
> Alternatives attribute "domain" doesn't exist in modcluster subsystem
> ---------------------------------------------------------------------
>
> Key: WFLY-8025
> URL: https://issues.jboss.org/browse/WFLY-8025
> Project: WildFly
> Issue Type: Bug
> Components: mod_cluster
> Affects Versions: 10.1.0.Final
> Reporter: Claudio Miranda
> Assignee: Radoslav Husar
>
> modcluster resource contains the following attribute definition for "load-balancing-group"
> {code}
> "load-balancing-group" => {
> "type" => STRING,
> "description" => "loadBalancingGroup name.",
> "expressions-allowed" => true,
> "required" => false,
> "nillable" => true,
> "alternatives" => ["domain"],
> "min-length" => 1L,
> "max-length" => 2147483647L,
> "access-type" => "read-write",
> "storage" => "configuration",
> "restart-required" => "all-services"
> },
> {code}
> But the alternatives constraint specifies a "domain" attribute that doesn't exist.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFLY-8025) Alternatives attribute "domain" doesn't exist in modcluster subsystem
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/WFLY-8025?page=com.atlassian.jira.plugin.... ]
Radoslav Husar updated WFLY-8025:
---------------------------------
Priority: Minor (was: Major)
> Alternatives attribute "domain" doesn't exist in modcluster subsystem
> ---------------------------------------------------------------------
>
> Key: WFLY-8025
> URL: https://issues.jboss.org/browse/WFLY-8025
> Project: WildFly
> Issue Type: Bug
> Components: mod_cluster
> Affects Versions: 10.1.0.Final
> Reporter: Claudio Miranda
> Assignee: Radoslav Husar
> Priority: Minor
>
> modcluster resource contains the following attribute definition for "load-balancing-group"
> {code}
> "load-balancing-group" => {
> "type" => STRING,
> "description" => "loadBalancingGroup name.",
> "expressions-allowed" => true,
> "required" => false,
> "nillable" => true,
> "alternatives" => ["domain"],
> "min-length" => 1L,
> "max-length" => 2147483647L,
> "access-type" => "read-write",
> "storage" => "configuration",
> "restart-required" => "all-services"
> },
> {code}
> But the alternatives constraint specifies a "domain" attribute that doesn't exist.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFLY-7987) Remove operations should warn the user if the resource has any dependents
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-7987?page=com.atlassian.jira.plugin.... ]
Brian Stansberry commented on WFLY-7987:
----------------------------------------
[~ggam] I think it's ok to keep this one for this issue. "Capabilities" is just the internal mechanism for how we will detect and react to the issue you describe here. If you prefer to open a different one that's ok, but this one seems good to me.
Thanks for asking about how fine grained to report issues. If it's easier for you to do lots of small ones that's ok. But a good middle ground is to think of these as referential integrity problems, where something in the configuration of subystem X refers to something in the config of subsystem Y (or in the "kernel" where the kernel means stuff that's in the config not in a subsystem, e.g. a socket-binding.)
If you see a problem between X and Y, then all other problems like that between X and Y are likely related and could be fixed by the same general fix, which is to establish proper capability contracts for X and Y and then wire up the system to use them. The hard work in fixing that is thinking through the contracts and doing that right usually means thinking through an entire subsystem, not just one thing detail. So if you find 3 different attributes between X and Y, they can all go in a general issue "Poor referential integrity between X and Y". If X and Y are the same subsystem, then it becomes "Poor referential integrity within X".
This one is "Poor referential integrity within the Undertow subsystem". From your comment earlier it sounds like you found a problem with "Poor referential integrity within the EJB subsystem."
Thanks!
> Remove operations should warn the user if the resource has any dependents
> -------------------------------------------------------------------------
>
> Key: WFLY-7987
> URL: https://issues.jboss.org/browse/WFLY-7987
> Project: WildFly
> Issue Type: Task
> Components: Web (Undertow)
> Affects Versions: 10.1.0.Final
> Reporter: Guillermo González de Agüero
> Assignee: Stuart Douglas
>
> Services may have dependents that can't work if they are not present. Removal operations should prevent, or least warn the user then he is about to remove a service that may have side effects.
> Take a look at this example:
> {code:shell}
> [standalone@localhost:9990 /] /subsystem=undertow/configuration=filter/response-header=test:add(header-name=X-test, header-value=test)
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=undertow/server=default-server/host=default-host/filter-ref=test:add()
> {"outcome" => "success"}
> [standalone@localhost:9990 /] /subsystem=undertow/configuration=filter/response-header=test:remove()
> {
> "outcome" => "success",
> "response-headers" => {
> "operation-requires-reload" => true,
> "process-state" => "reload-required"
> }
> }
> [standalone@localhost:9990 /] :reload()
> {
> "outcome" => "success",
> "result" => undefined
> }
> [standalone@localhost:9990 /] /core-service=management:read-boot-errors()
> {
> "outcome" => "success",
> "result" => [{
> "failed-operation" => {
> "operation" => "add",
> "address" => [
> ("subsystem" => "undertow"),
> ("server" => "default-server"),
> ("host" => "default-host"),
> ("filter-ref" => "test")
> ]
> },
> "failure-description" => "{\"WFLYCTL0412: Required services that are not installed:\" => [\"jboss.undertow.filter.test\"],\"WFLYCTL0180: Services with missing/unavailable dependencies\" => [\"jboss.undertow.server.default-server.default-host.filter-ref.test is missing [jboss.undertow.filter.test]\"]}",
> "services-missing-dependencies" => ["jboss.undertow.server.default-server.default-host.filter-ref.test is missing [jboss.undertow.filter.test]"]
> }]
> }
> {code}
> A new Undertow filter is created and assigned to a host. The filter is then removed, but the host still needs it.
> The problem is only seen after a server reload. The same thing happens when you remove, i.e. the default Servlet Container or the Bean pool of the EJB subsystem.
> My proposal is to at least add a response head to the remove operations listing affected (dependent) services. This would complement the new WildFly 11 capability registry.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFCORE-2205) NPE thrown in jboss-cli while defining already defined StringListType attribute
by Jean-Francois Denise (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2205?page=com.atlassian.jira.plugi... ]
Jean-Francois Denise updated WFCORE-2205:
-----------------------------------------
Git Pull Request: https://github.com/wildfly/wildfly-core/pull/2097, https://github.com/wildfly/wildfly-core/pull/2151 (was: https://github.com/wildfly/wildfly-core/pull/2097)
> NPE thrown in jboss-cli while defining already defined StringListType attribute
> -------------------------------------------------------------------------------
>
> Key: WFCORE-2205
> URL: https://issues.jboss.org/browse/WFCORE-2205
> Project: WildFly Core
> Issue Type: Bug
> Components: CLI
> Reporter: Jan Tymel
> Assignee: Jean-Francois Denise
> Fix For: 3.0.0.Alpha20
>
>
> NullPointerException is thrown when user tries to define already (i.e. previously in current command) defined StringListType attribute. This attempt results in following stack trace and termination of jboss-cli.
> {code}
> /subsystem=elytron/provider-loader=providerLoader:add(providers=[{class-names=[com.example.Class]},class-names=[{com.example.AnotherClass}Exception in thread "Aesh Process Loop 749282235" java.lang.NullPointerException
> at org.jboss.as.cli.impl.DeploymentItemCompleter.getCandidates(DeploymentItemCompleter.java:80)
> at org.jboss.as.cli.impl.DeploymentItemCompleter.complete(DeploymentItemCompleter.java:53)
> at org.jboss.as.cli.impl.ValueTypeCompleter$ValueTypeCallbackHandler.getCandidatesFromMetadata(ValueTypeCompleter.java:433)
> at org.jboss.as.cli.impl.ValueTypeCompleter$ValueTypeCallbackHandler.getSimpleValues(ValueTypeCompleter.java:690)
> at org.jboss.as.cli.impl.ValueTypeCompleter$ValueTypeCallbackHandler.getCandidates(ValueTypeCompleter.java:573)
> at org.jboss.as.cli.impl.ValueTypeCompleter.complete(ValueTypeCompleter.java:346)
> at org.jboss.as.cli.operation.OperationRequestCompleter.complete(OperationRequestCompleter.java:276)
> at org.jboss.as.cli.operation.OperationRequestCompleter.complete(OperationRequestCompleter.java:89)
> at org.jboss.as.cli.CommandCompleter.doComplete(CommandCompleter.java:137)
> at org.jboss.as.cli.CommandCompleter.complete(CommandCompleter.java:64)
> at org.jboss.as.cli.impl.Console$Factory$1$1.complete(Console.java:143)
> at org.jboss.aesh.console.AeshCompletionHandler.complete(AeshCompletionHandler.java:155)
> at org.jboss.aesh.console.AeshInputProcessor.complete(AeshInputProcessor.java:429)
> at org.jboss.aesh.console.AeshInputProcessor.parseOperation(AeshInputProcessor.java:166)
> at org.jboss.aesh.console.Console.processInternalOperation(Console.java:775)
> at org.jboss.aesh.console.Console.execute(Console.java:735)
> at org.jboss.aesh.console.Console.access$900(Console.java:73)
> at org.jboss.aesh.console.Console$6.run(Console.java:644)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> Expected result:
> No NPE thrown, jboss-cli is not terminated.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (ELY-924) Coverity static analysis: Resource leak in LdapSecurityRealm (Elytron)
by Ilia Vassilev (JIRA)
[ https://issues.jboss.org/browse/ELY-924?page=com.atlassian.jira.plugin.sy... ]
Ilia Vassilev moved WFLY-7964 to ELY-924:
-----------------------------------------
Project: WildFly Elytron (was: WildFly)
Key: ELY-924 (was: WFLY-7964)
Component/s: (was: Security)
Affects Version/s: 1.1.0.Beta21
(was: 11.0.0.Alpha1)
> Coverity static analysis: Resource leak in LdapSecurityRealm (Elytron)
> ----------------------------------------------------------------------
>
> Key: ELY-924
> URL: https://issues.jboss.org/browse/ELY-924
> Project: WildFly Elytron
> Issue Type: Bug
> Affects Versions: 1.1.0.Beta21
> Reporter: Martin Choma
> Assignee: Ilia Vassilev
> Priority: Critical
>
> Coverity static-analysis scan found resource leak in LdapSecurityRealm.getIdentity().
> It has to be in try-with-resources, because Stream<LdapIdentity> has registered close handler, where NamingEnumeration.close() is called. Looking into one possible implementation http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/8u... It would be safer to call close() explicitelly.
> However chained stream statement is used in try, which cause 2 Stream objects to be created. But only one of them is closed. Stream created by ldapSearch.search(context) (with exlicitely registered close handler) is not closed.
> {code:java|title=LdapSecurityRealm.java}
> try (
> Stream<LdapIdentity> identityStream = ldapSearch.search(context)
> .map(result -> new LdapIdentity(result.getNameInNamespace()))
> ) {
> LdapIdentity identity = identityStream.findFirst().orElse(null);
> {code}
> https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=85538...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months