[JBoss JIRA] (ELY-1096) Coverity, volatile not atomically updated in RotatingFileAuditEndpoint (Elytron)
by Martin Choma (JIRA)
Martin Choma created ELY-1096:
---------------------------------
Summary: Coverity, volatile not atomically updated in RotatingFileAuditEndpoint (Elytron)
Key: ELY-1096
URL: https://issues.jboss.org/browse/ELY-1096
Project: WildFly Elytron
Issue Type: Bug
Reporter: Martin Choma
Assignee: Darran Lofthouse
Priority: Critical
There is variable {{currentSize}} marked with modifier as {{volatile}}, what hint variable {{currentSize}} is used in multithreaded manner, as volatile ensures actual value can be seen between threads.
On the other side there is update operation on {{currentSize}}, which is not written in atomic manner, so can lead race condition.
{code}
@Override
protected void write(byte[] bytes) throws IOException {
super.write(bytes);
currentSize += bytes.length;
}
{code}
Setting as Critical as that can lead to strange / hard to reproduce errors.
https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=15443...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (WFCORE-2707) Socket binding group definition issues
by Brian Stansberry (JIRA)
Brian Stansberry created WFCORE-2707:
----------------------------------------
Summary: Socket binding group definition issues
Key: WFCORE-2707
URL: https://issues.jboss.org/browse/WFCORE-2707
Project: WildFly Core
Issue Type: Bug
Components: Domain Management
Reporter: Brian Stansberry
Assignee: Brian Stansberry
The definition of socket-binding-group resources needs cleaning up a bit. There's some sharing of code between the domain wide binding resources vs what's used for the server and HC.
1) The capability registered for the domain-wide SBG may not really be appropriate for server/HC. IIRC nothing references the server/HC SBG so it doesn't need this cap, and having it in the HC case raises the potential for cap conflicts with the domain-wide sbgs. This is minor.
2) The remove handler used for server/HC only executes Stage.RUNTIME on a server which means nothing happens on the HC.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (WFCORE-2706) Expose the SocketBindingManager as a capability
by Brian Stansberry (JIRA)
Brian Stansberry created WFCORE-2706:
----------------------------------------
Summary: Expose the SocketBindingManager as a capability
Key: WFCORE-2706
URL: https://issues.jboss.org/browse/WFCORE-2706
Project: WildFly Core
Issue Type: Bug
Components: Domain Management
Reporter: Brian Stansberry
Assignee: Brian Stansberry
Needed for WFCORE-2664 to allow checking for the capability to replace an MSC Optional dependency. Plus other subsystems are depending on the SBM so that should be mediated via capabilities.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (WFLY-8619) Incorrect IIOP security config validation
by Tomasz Adamski (JIRA)
[ https://issues.jboss.org/browse/WFLY-8619?page=com.atlassian.jira.plugin.... ]
Tomasz Adamski closed WFLY-8619.
--------------------------------
Resolution: Duplicate Issue
> Incorrect IIOP security config validation
> -----------------------------------------
>
> Key: WFLY-8619
> URL: https://issues.jboss.org/browse/WFLY-8619
> Project: WildFly
> Issue Type: Bug
> Components: IIOP
> Affects Versions: 11.0.0.Alpha1
> Reporter: Tomasz Adamski
> Assignee: Tomasz Adamski
> Priority: Blocker
>
> In org.wildfly.iiop.openjdk.ConfigValidator.java:
> {code}
> if (supportSSL && !sslConfigured) {
> throw IIOPLogger.ROOT_LOGGER.noSecurityDomainOrSSLContextsSpecified();
> }
> else if (serverRequiresSsl || clientRequiresSsl) {
> // if either the server or the client requires SSL, then SSL support must have been enabled.
> throw IIOPLogger.ROOT_LOGGER.sslNotConfigured();
> }
> {code}
> Shouldn't go to second if if supporSSL is configured.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (JBJCA-1347) NullPointerException in SemaphoreConcurrentLinkedDequeManagedConnectionPool.java:441
by Brett Delle Grazie (JIRA)
Brett Delle Grazie created JBJCA-1347:
-----------------------------------------
Summary: NullPointerException in SemaphoreConcurrentLinkedDequeManagedConnectionPool.java:441
Key: JBJCA-1347
URL: https://issues.jboss.org/browse/JBJCA-1347
Project: IronJacamar
Issue Type: Bug
Affects Versions: WildFly/IronJacamar 1.3.2.Final
Environment: CentOS 6
Wildfly 10.0.0.Final (Iron Jacamar 1.3.2.Final)
PostgreSQL Server 9.5.5
PostgreSQL JDBC driver 9.4.1208 and tried with 42.0.0
Oracle Java version "1.8.0_112"
Java(TM) SE Runtime Environment (build 1.8.0_112-b15)
Java HotSpot(TM) 64-Bit Server VM (build 25.112-b15, mixed mode)
Reporter: Brett Delle Grazie
Using a PostgreSQL XA datasource with statistics enabled we get a NullPointerException if the connection fails temporarily.
With JDBC driver 9.4.1208 Wildfly never reconnects to the PostgreSQL server with the next request and Wildfly must be restarted. With JDBC driver 42.0.0 it does reconnect on next request.
If statistics are disabled, the NPE does not occur and both drivers reconnect on the next request as expected.
Specific location of NPE:
https://github.com/ironjacamar/ironjacamar/blob/ironjacamar-1.3.2.Final/c...
Note there is similar code on line 461 of the same class (in the exception handler)
Example configuration follows
With a PostgreSQL datasource configured in Wildfly as:
{code:xml}
<xa-datasource jndi-name="java:/DS.people" pool-name="DS.people" enabled="true" spy="true" statistics-enabled="true" use-java-context="true" use-ccm="true">
<driver>postgresql</driver>
<xa-datasource-property name="ServerName">localhost</xa-datasource-property>
<xa-datasource-property name="PortNumber">5432</xa-datasource-property>
<xa-datasource-property name="DatabaseName">peopleviewstore</xa-datasource-property>
<xa-datasource-property name="ApplicationName">people</xa-datasource-property>
<xa-datasource-property name="assumeMinServerVersion">9.5</xa-datasource-property>
<xa-datasource-property name="connectTimeout">10</xa-datasource-property>
<xa-datasource-property name="currentSchema">public</xa-datasource-property>
<xa-datasource-property name="hostRecheckSeconds">10</xa-datasource-property>
<xa-datasource-property name="loginTimeout">10</xa-datasource-property>
<xa-datasource-property name="logUnclosedConnections">true</xa-datasource-property>
<xa-datasource-property name="socketTimeout">30</xa-datasource-property>
<xa-datasource-property name="targetServerType">master</xa-datasource-property>
<xa-datasource-property name="tcpKeepAlive">true</xa-datasource-property>
<xa-pool>
<min-pool-size>0</min-pool-size>
<initial-pool-size>0</initial-pool-size>
<max-pool-size>10</max-pool-size>
<allow-multiple-users>false</allow-multiple-users>
</xa-pool>
<timeout>
<xa-resource-timeout>0</xa-resource-timeout>
</timeout>
<transaction-isolation>TRANSACTION_READ_COMMITTED</transaction-isolation>
<statement>
<track-statements>true</track-statements>
</statement>
<security>
<user-name></user-name>
<password></password>
</security>
<validation>
<validate-on-match>true</validate-on-match>
<use-fast-fail>true</use-fast-fail>
<exception-sorter class-name="org.jboss.jca.adapters.jdbc.extensions.postgres.PostgreSQLExceptionSorter"/>
<valid-connection-checker class-name="org.jboss.jca.adapters.jdbc.extensions.postgres.PostgreSQLValidConnectionChecker"/>
</validation>
</xa-datasource>
{code}
And corresponding driver configuration:
{code:xml}
<driver name="postgresql" module="org.postgresql">
<xa-datasource-class>org.postgresql.xa.PGXADataSource</xa-datasource-class>
</driver>
{code}
we have deployed the JDBC driver as a module, module.xml looks like:
{code:xml}
<?xml version="1.0" ?>
<module xmlns="urn:jboss:module:1.3" name="org.postgresql" slot="main">
<resources>
<resource-root path="postgresql-42.0.0.jar"/>
</resources>
<dependencies>
<module name="javax.api"/>
<module name="javax.transaction.api"/>
</dependencies>
</module>
{code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (LOGTOOL-105) Option to have LoggingToolsProcessor to not use javax.annotation.Generated
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/LOGTOOL-105?page=com.atlassian.jira.plugi... ]
James Perkins updated LOGTOOL-105:
----------------------------------
Release Notes Text:
There will be an attempt to determine which {{@Generated}} annotation to use. First the {{javax.annotation.Generated}} is tried and if unsuccessful the {{javax.annotation.processing.Generated}} is tried. If neither work no annation will be added to the generated source.
You can also specify {{-AaddGeneratedAnnotation=false}} to not add annotations to the generated source at all.
> Option to have LoggingToolsProcessor to not use javax.annotation.Generated
> --------------------------------------------------------------------------
>
> Key: LOGTOOL-105
> URL: https://issues.jboss.org/browse/LOGTOOL-105
> Project: Log Tool
> Issue Type: Feature Request
> Reporter: Sanne Grinovero
> Assignee: Sanne Grinovero
> Fix For: 2.1.0.Alpha2
>
>
> To allow projects using the JBoss Logging annotation processor to test latest Java 9 Jigsaw builds, we need to be able to workaround issue
> https://bugs.openjdk.java.net/browse/JDK-8152842
> I'm introducing an annotation processor option which will cause the generated source code to "forget" to mark the generated code with {{javax.annotation.Generated}}.
> --{{AskipGeneratedAnnotation=true}}-- {{-AaddGeneratedAnnotation=false}}
> The JMH annotation processor followed a similar path:
> https://bugs.openjdk.java.net/browse/CODETOOLS-7901643
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years
[JBoss JIRA] (WFLY-8619) Incorrect IIOP security config validation
by Tomasz Adamski (JIRA)
Tomasz Adamski created WFLY-8619:
------------------------------------
Summary: Incorrect IIOP security config validation
Key: WFLY-8619
URL: https://issues.jboss.org/browse/WFLY-8619
Project: WildFly
Issue Type: Bug
Components: IIOP
Affects Versions: 11.0.0.Alpha1
Reporter: Tomasz Adamski
Assignee: Tomasz Adamski
Priority: Blocker
In org.wildfly.iiop.openjdk.ConfigValidator.java:
{code}
if (supportSSL && !sslConfigured) {
throw IIOPLogger.ROOT_LOGGER.noSecurityDomainOrSSLContextsSpecified();
}
else if (serverRequiresSsl || clientRequiresSsl) {
// if either the server or the client requires SSL, then SSL support must have been enabled.
throw IIOPLogger.ROOT_LOGGER.sslNotConfigured();
}
{code}
Should go to second if if supporSSL is configured.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years