[JBoss JIRA] (DROOLS-1551) Implement FEEL/DMN value marshaller
by Edson Tirelli (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1551?page=com.atlassian.jira.plugi... ]
Edson Tirelli updated DROOLS-1551:
----------------------------------
Fix Version/s: (was: 7.1.0.Final)
> Implement FEEL/DMN value marshaller
> -----------------------------------
>
> Key: DROOLS-1551
> URL: https://issues.jboss.org/browse/DROOLS-1551
> Project: Drools
> Issue Type: Feature Request
> Components: dmn engine
> Affects Versions: 7.0.0.CR3
> Reporter: Edson Tirelli
> Assignee: Edson Tirelli
>
> Some value types in FEEL/DMN require special formatting when marshalling/unmarshalling. For instance:
> {quote}
> So it seems that ISO 8601 does not define negative intervals. I.e., ISO 8601 only supports things like "PT1H". XPath extends that with a leading optional sign, like "+PT1H" and "-PT1H". Java extends that allowing the sign to be used in each of the units in the duration like, "PT+1H", "PT-1H", besides the leading sign "-PT1H".
> The FEEL spec on page 113 seems to follow the XPath lexical definition, so the leading sign "-PT1H" seems to be the correct format.
> {quote}
> Implement an object marshaller for DMN/FEEL that is capable of marshalling/unmarshalling objects. Most object types are straightforward, but a few of them (like durations) need special handling. In particular:
> * negative duration should use a leading - sign instead of having the sign in the unit numbers
> * durations need to be normalized before marshalled:
> {quote}
> A days and time duration in the semantic domain is a sequence of numbers for the days, hours, minutes, and seconds of duration, normalized such that the sum of these numbers is minimized.
> {quote}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (DROOLS-1481) Validate function signature at compile time and improve error message
by Edson Tirelli (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1481?page=com.atlassian.jira.plugi... ]
Edson Tirelli updated DROOLS-1481:
----------------------------------
Fix Version/s: (was: 7.1.0.Final)
> Validate function signature at compile time and improve error message
> ---------------------------------------------------------------------
>
> Key: DROOLS-1481
> URL: https://issues.jboss.org/browse/DROOLS-1481
> Project: Drools
> Issue Type: Feature Request
> Components: dmn engine
> Affects Versions: 7.0.0.Beta7
> Reporter: Edson Tirelli
> Assignee: Matteo Mortari
>
> Function signatures as of now are only validated in runtime. We can improve it to add static validation as well. For instance, in the expression:
> {code}"$"+ (if Payment < 1000 then string(Payment) else (substring(string(Payment),1,1) + "," + substring(string(decimal(Payment,2),2)))){code}
> In runtime I get:
> {quote}Unable to find function 'string( class java.math.BigDecimal, class java.math.BigDecimal )'{quote}
> Because of:
> {code}...string(decimal(Payment,2),2)...{code}
> Instead of (see the misplaced parenthesis):
> {code}...string(decimal(Payment,2)),2...{code}
> I think we can also improve the error message to say:
> {quote}Unable to find function 'string( number, number )'{quote}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (DROOLS-1612) Throw compilation error when using collect hit policy with aggr. function and multiple outputs
by Edson Tirelli (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1612?page=com.atlassian.jira.plugi... ]
Edson Tirelli updated DROOLS-1612:
----------------------------------
Fix Version/s: 7.1.0.Final
> Throw compilation error when using collect hit policy with aggr. function and multiple outputs
> ----------------------------------------------------------------------------------------------
>
> Key: DROOLS-1612
> URL: https://issues.jboss.org/browse/DROOLS-1612
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Affects Versions: 7.0.0.Final
> Reporter: Tibor Zimányi
> Assignee: Edson Tirelli
> Fix For: 7.1.0.Final
>
>
> According to the DMN spec., "Decision tables with compound outputs support only the following hit policies: Unique, Any, Priority, First, Output
> order, Rule order and Collect without operator, because the collect operator is undefined over multiple outputs."
> However when I use decision table with "COLLECT" hit policy, "sum" aggregate function and multiple outputs, the table compiles. When evaluating the table, I get nulls as output value results, but no error message in DMNResult.
> I will provide a reproducer in a PR.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (DROOLS-1612) Throw compilation error when using collect hit policy with aggr. function and multiple outputs
by Edson Tirelli (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1612?page=com.atlassian.jira.plugi... ]
Edson Tirelli commented on DROOLS-1612:
---------------------------------------
[~tzimanyi] , I will look into it. When first implemented, we wanted to support aggregation even for multiple output columns (as an extension to the standard), as long as all columns are of the appropriate type. I will look at the problem you reported and improve error handling.
> Throw compilation error when using collect hit policy with aggr. function and multiple outputs
> ----------------------------------------------------------------------------------------------
>
> Key: DROOLS-1612
> URL: https://issues.jboss.org/browse/DROOLS-1612
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Affects Versions: 7.0.0.Final
> Reporter: Tibor Zimányi
> Assignee: Edson Tirelli
>
> According to the DMN spec., "Decision tables with compound outputs support only the following hit policies: Unique, Any, Priority, First, Output
> order, Rule order and Collect without operator, because the collect operator is undefined over multiple outputs."
> However when I use decision table with "COLLECT" hit policy, "sum" aggregate function and multiple outputs, the table compiles. When evaluating the table, I get nulls as output value results, but no error message in DMNResult.
> I will provide a reproducer in a PR.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (WFLY-8904) Fix AuthenticationTestCase and GetCallerPrincipalTestCase for Elytron and unignore it
by Michal Jurc (JIRA)
[ https://issues.jboss.org/browse/WFLY-8904?page=com.atlassian.jira.plugin.... ]
Michal Jurc updated WFLY-8904:
------------------------------
Description:
{{org.jboss.as.test.integration.ejb.security.AuthenticationTestCase}} currently fails in {{elytron}} profile due to different exception than expected (old PB one) being produced by Elytron:
{code}Results :
Failed tests:
AuthenticationTestCase.testAuthentication_TwoBeans_ReAuth__BadPwd_ViaServlet:257 null
{code}
When this is fixed, the test should be unignored for the {{elytron}} profile.
{{GetCallerPrincipalTestCase}} also needs to be changed to adhere to unspecified security context in beans in {{PostConstruct}} phase.
was:
{{org.jboss.as.test.integration.ejb.security.AuthenticationTestCase}} currently fails in {{elytron}} profile due to different exception than expected (old PB one) being produced by Elytron:
{code}Results :
Failed tests:
AuthenticationTestCase.testAuthentication_TwoBeans_ReAuth__BadPwd_ViaServlet:257 null
{code}
When this is fixed, the test should be unignored for the {{elytron}} profile.
> Fix AuthenticationTestCase and GetCallerPrincipalTestCase for Elytron and unignore it
> -------------------------------------------------------------------------------------
>
> Key: WFLY-8904
> URL: https://issues.jboss.org/browse/WFLY-8904
> Project: WildFly
> Issue Type: Bug
> Components: Test Suite
> Reporter: Michal Jurc
> Assignee: Michal Jurc
>
> {{org.jboss.as.test.integration.ejb.security.AuthenticationTestCase}} currently fails in {{elytron}} profile due to different exception than expected (old PB one) being produced by Elytron:
> {code}Results :
> Failed tests:
> AuthenticationTestCase.testAuthentication_TwoBeans_ReAuth__BadPwd_ViaServlet:257 null
> {code}
> When this is fixed, the test should be unignored for the {{elytron}} profile.
> {{GetCallerPrincipalTestCase}} also needs to be changed to adhere to unspecified security context in beans in {{PostConstruct}} phase.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (WFLY-8904) Fix AuthenticationTestCase and GetCallerPrincipalTestCase for Elytron and unignore it
by Michal Jurc (JIRA)
[ https://issues.jboss.org/browse/WFLY-8904?page=com.atlassian.jira.plugin.... ]
Michal Jurc updated WFLY-8904:
------------------------------
Summary: Fix AuthenticationTestCase and GetCallerPrincipalTestCase for Elytron and unignore it (was: Fix AuthenticationTestCase for Elytron and unignore it)
> Fix AuthenticationTestCase and GetCallerPrincipalTestCase for Elytron and unignore it
> -------------------------------------------------------------------------------------
>
> Key: WFLY-8904
> URL: https://issues.jboss.org/browse/WFLY-8904
> Project: WildFly
> Issue Type: Bug
> Components: Test Suite
> Reporter: Michal Jurc
> Assignee: Michal Jurc
>
> {{org.jboss.as.test.integration.ejb.security.AuthenticationTestCase}} currently fails in {{elytron}} profile due to different exception than expected (old PB one) being produced by Elytron:
> {code}Results :
> Failed tests:
> AuthenticationTestCase.testAuthentication_TwoBeans_ReAuth__BadPwd_ViaServlet:257 null
> {code}
> When this is fixed, the test should be unignored for the {{elytron}} profile.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months
[JBoss JIRA] (DROOLS-1576) Intermittently Rule getting executed Twice while using Agenda Groups and Order
by Mario Fusco (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1576?page=com.atlassian.jira.plugi... ]
Mario Fusco resolved DROOLS-1576.
---------------------------------
Resolution: Cannot Reproduce Bug
I cannot reproducer this issue. Feel free to reopen this ticket when you'll be able to provide a proper reproducer.
> Intermittently Rule getting executed Twice while using Agenda Groups and Order
> ------------------------------------------------------------------------------
>
> Key: DROOLS-1576
> URL: https://issues.jboss.org/browse/DROOLS-1576
> Project: Drools
> Issue Type: Bug
> Reporter: Siyad Theyparambil Mohammed
> Assignee: Mario Fusco
> Attachments: CreateDedCharges-Rule.txt, CreateFLATFeeCharges-Rule.txt, CreatePSRLCreditCharges-Rule.txt, CreateRPERFeeCharges-Rule.txt, Drools-1576.zip, Drools-1576_Mario.zip, First Execution Result.txt, Second Execution Result.txt
>
>
> Hi,
> We have 4 rules which are divided into 2 agenda groups
> ||Rule||Agenda Group||
> |CreateRPERFeeCharges|createcharges|
> |CreateFLATFeeCharges|createcharges|
> |CreateDedCharges|createcharges|
> |CreatePSRLCreditCharges|postrule|
>
> Focus is set on the agenda group in the following order,
> 1. postrule
> 2. createcharges
> The Rule “CreatePSRLCreditCharges” has named consequences. Based on the accumulated Charge amount we want one of the two consequence to be executed. If you notice the “First Execution Result.txt” this rule was executed twice once for the “IF” and second for “ELSE” but during the second trigger of the rule execution it fired the rule only once with the same data. Could you please look/check and let us know if we have an issue with the rule or is this a bug in drools?
>
> We have attached the all the 4 drls and the results of the 2 execution that was triggered.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
8 years, 11 months