[JBoss JIRA] (WFLY-11181) XAResourceRecoveryServiceConfigurator adds a TX service dependency for non-transactional caches
by Brian Stansberry (Jira)
Brian Stansberry created WFLY-11181:
---------------------------------------
Summary: XAResourceRecoveryServiceConfigurator adds a TX service dependency for non-transactional caches
Key: WFLY-11181
URL: https://issues.jboss.org/browse/WFLY-11181
Project: WildFly
Issue Type: Bug
Components: Clustering
Reporter: Brian Stansberry
Assignee: Brian Stansberry
I _think_ this is wrong...
XAResourceRecoveryServiceConfigurator is installed for all caches, not just ones with the ones with the component=transaction child resource. That's basically ok because its accept and get methods only do things if this.cache.get().getCacheConfiguration().transaction().recovery().enabled(). But, the problem is the service dependency on the XAResourceRecoveryRegistry service the transaction subsystem provides is always added, so even if is wouldn't be used the dependency is added.
I think WFLY-11167 will make it possible to correct this by 1) doing capability checking before adding the service dependency and 2) adding a capability requirement in TransactionResourceDefinition.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3088) FEEL Compiler: refactor to AST-based tree walk
by Tibor Zimányi (Jira)
[ https://issues.jboss.org/browse/DROOLS-3088?page=com.atlassian.jira.plugi... ]
Tibor Zimányi updated DROOLS-3088:
----------------------------------
Story Points: 8
> FEEL Compiler: refactor to AST-based tree walk
> ----------------------------------------------
>
> Key: DROOLS-3088
> URL: https://issues.jboss.org/browse/DROOLS-3088
> Project: Drools
> Issue Type: Task
> Reporter: Edoardo Vacchi
> Assignee: Edoardo Vacchi
> Priority: Major
> Labels: drools-core
>
> Current implementation of the compiler walks the parse tree generated by ANTLR, which is a bit cumbersome because of the way the grammar has to be written to deal with priorities/ambiguities. Luckily, many of such issues are solved by the interpreter implementation, which walks the parse tree and generates a neat, simpler Abstract Syntax Tree.
> This tasks is to refactor our current compiler to walk that AST, instead of the larger parse tree.
> Benefits:
> - less "visit" cases in the visitor
> - more opportunities to "optimize" the tree (e.g, tree rewrites, constant folding)
> - more opportunities to refactor tree walking phases (e.g. we could add a "type-evaluation" phase)
> - a chance to refactor code gen utilities to support classes, and simplify the code in general
> - cons: it takes a bit of time, but the AST nodes are really a handful, so it should not take that much
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3139) [DMN Designer] Automatic Layout Feature
by Jozef Marko (Jira)
Jozef Marko created DROOLS-3139:
-----------------------------------
Summary: [DMN Designer] Automatic Layout Feature
Key: DROOLS-3139
URL: https://issues.jboss.org/browse/DROOLS-3139
Project: Drools
Issue Type: Epic
Components: DMN Editor
Reporter: Jozef Marko
Assignee: Daniel José dos Santos
DMN Designer should *autolayout* new imported DMN models. The *autolayout* should position DRG diagram nodes into horizontal layers to minimize crossing of connectors with respect of *Top-Down* importance. It means if nodes *Layer B* are inputs for nodes in *Layer A* then the *Layer B* will be below *Layer A*. The *autolayout* should also try to minimize scrolling needed to see whole DRG diagram.
User should also have possibility to invoke *autolayout* feature any time during designing the diagram. In this case the action should be undoable with the *Undo* toolbar button.
The approach used to achieve this is the Sugiyama Method, which is done in 4 steps. Each step have its own set of algorithms. For each step, we selected one of the available algorithms to implement, based on our current needs and time to develop:
*Step 1 - Cycle breaking:* We break cycles in diagram by reversing some edges (they are de-reversed in the end). This step are required because we need ending points in step 2 while sweeping through graph;
*Step 2 - Layering:* We sweep through graph (diagram) and put each node (vertex) in a layer, based on it's distance from others node. For edges that crosses multiple layers, we create virtual vertices connecting those. They are removed at the end.
This approach usually puts the start nodes at the top and the deepest nodes at the end. In the current implementation we're using Longest Path algorithm. A better approach can be developed in future using Network Simplex;
*Step 3 - Node Ordering:* We order each node (vertex) inside its layers in order to reduce crossing, using median. Another approach that can be used is barycenter.
*Step 4 - Node Positioning:* We de-reverse nodes reversed in step 1 and remove virtual nodes reconnecting the concrete nodes. Then we calculate the position of each node. This step can be divided in two steps: one for horizontal position and other for vertical for better positioning. Currently we're using a simple approach: every block of nodes inside the layers is centered and the distance between layers is the same. So it will produce results like the attachment "Automatic Layout Demo".
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3088) FEEL Compiler: refactor to AST-based tree walk
by Edoardo Vacchi (Jira)
[ https://issues.jboss.org/browse/DROOLS-3088?page=com.atlassian.jira.plugi... ]
Edoardo Vacchi updated DROOLS-3088:
-----------------------------------
Sprint: 2018 Week 42-44
> FEEL Compiler: refactor to AST-based tree walk
> ----------------------------------------------
>
> Key: DROOLS-3088
> URL: https://issues.jboss.org/browse/DROOLS-3088
> Project: Drools
> Issue Type: Task
> Reporter: Edoardo Vacchi
> Assignee: Edoardo Vacchi
> Priority: Major
> Labels: drools-core
>
> Current implementation of the compiler walks the parse tree generated by ANTLR, which is a bit cumbersome because of the way the grammar has to be written to deal with priorities/ambiguities. Luckily, many of such issues are solved by the interpreter implementation, which walks the parse tree and generates a neat, simpler Abstract Syntax Tree.
> This tasks is to refactor our current compiler to walk that AST, instead of the larger parse tree.
> Benefits:
> - less "visit" cases in the visitor
> - more opportunities to "optimize" the tree (e.g, tree rewrites, constant folding)
> - more opportunities to refactor tree walking phases (e.g. we could add a "type-evaluation" phase)
> - a chance to refactor code gen utilities to support classes, and simplify the code in general
> - cons: it takes a bit of time, but the AST nodes are really a handful, so it should not take that much
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (DROOLS-3138) [DMN Editor] Add support to define data-types
by Jozef Marko (Jira)
Jozef Marko created DROOLS-3138:
-----------------------------------
Summary: [DMN Editor] Add support to define data-types
Key: DROOLS-3138
URL: https://issues.jboss.org/browse/DROOLS-3138
Project: Drools
Issue Type: Epic
Components: DMN Editor
Reporter: Jozef Marko
Assignee: Guilherme Carreiro
As a practitioner, I want to be able to define Data Types in the UI, so that when the DMN engine evaluates a decision table input/output it will check if the type of the value matches the specified type.
Verification conditions:
Support added for the User to define data-types ({{ItemDefinition}}).
This may become a top-level task when I get to work on it; as the requirement is quite large and encompasses nested data-types (a whole new grid will be required); and definition of enums, constrains on values etc.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (WFLY-10747) IOException when using JSF in deployment
by Farah Juma (Jira)
[ https://issues.jboss.org/browse/WFLY-10747?page=com.atlassian.jira.plugin... ]
Farah Juma commented on WFLY-10747:
-----------------------------------
[~treblereel] Does the exception also occur for a deployment that does not explicitly set the JSF version? If not, then yes, this doesn't seem like a bug. Thanks for looking into this!
> IOException when using JSF in deployment
> ----------------------------------------
>
> Key: WFLY-10747
> URL: https://issues.jboss.org/browse/WFLY-10747
> Project: WildFly
> Issue Type: Bug
> Components: JSF, Web (Undertow)
> Affects Versions: 10.1.0.Final, 11.0.0.Final, 12.0.0.Final, 13.0.0.Final
> Reporter: Adam Krajcik
> Assignee: Dmitrii Tikhomirov
> Priority: Major
> Attachments: deployment.war
>
>
> When using JSF in attached [^deployment.war], I can see the following error. This error happens during the first request. Sever doesn't print this error on further requests.
> {code}
> 14:08:31,401 SEVERE [facelets.compiler] (default task-1) Error Loading Library: jar:file:/tmp/jboss-eap-7.2/modules/system/layers/base/com/sun/jsf-impl/main/jsf-impl-2.2.13.SP5-redhat-1.jar!/META-INF/mojarra_ext.taglib.xml: java.io.IOException: Error parsing [jar:file:/tmp/jboss-eap-7.2/modules/system/layers/base/com/sun/jsf-impl/main/jsf-impl-2.2.13.SP5-redhat-1.jar!/META-INF/mojarra_ext.taglib.xml]:
> at com.sun.facelets.compiler.TagLibraryConfig.create(TagLibraryConfig.java:410)
> at com.sun.facelets.compiler.TagLibraryConfig.loadImplicit(TagLibraryConfig.java:431)
> at com.sun.facelets.compiler.Compiler.initialize(Compiler.java:87)
> at com.sun.facelets.compiler.Compiler.compile(Compiler.java:104)
> at com.sun.facelets.impl.DefaultFaceletFactory.createFacelet(DefaultFaceletFactory.java:218)
> at com.sun.facelets.impl.DefaultFaceletFactory.getFacelet(DefaultFaceletFactory.java:149)
> at com.sun.facelets.impl.DefaultFaceletFactory.getFacelet(DefaultFaceletFactory.java:100)
> at com.sun.facelets.FaceletViewHandler.buildView(FaceletViewHandler.java:519)
> at com.sun.facelets.FaceletViewHandler.renderView(FaceletViewHandler.java:569)
> at com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:120)
> at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
> at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:219)
> at javax.faces.webapp.FacesServlet.service(FacesServlet.java:659)
> at io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74)
> at io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62)
> at io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68)
> at io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36)
> at org.wildfly.extension.undertow.security.SecurityContextAssociationHandler.handleRequest(SecurityContextAssociationHandler.java:78)
> at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
> at io.undertow.servlet.handlers.security.SSLInformationAssociationHandler.handleRequest(SSLInformationAssociationHandler.java:132)
> at io.undertow.servlet.handlers.security.ServletAuthenticationCallHandler.handleRequest(ServletAuthenticationCallHandler.java:57)
> at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
> at io.undertow.security.handlers.AbstractConfidentialityHandler.handleRequest(AbstractConfidentialityHandler.java:46)
> at io.undertow.servlet.handlers.security.ServletConfidentialityConstraintHandler.handleRequest(ServletConfidentialityConstraintHandler.java:64)
> at io.undertow.security.handlers.AuthenticationMechanismsHandler.handleRequest(AuthenticationMechanismsHandler.java:60)
> at io.undertow.servlet.handlers.security.CachedAuthenticatedSessionHandler.handleRequest(CachedAuthenticatedSessionHandler.java:77)
> at io.undertow.security.handlers.NotificationReceiverHandler.handleRequest(NotificationReceiverHandler.java:50)
> at io.undertow.security.handlers.AbstractSecurityContextAssociationHandler.handleRequest(AbstractSecurityContextAssociationHandler.java:43)
> at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
> at org.wildfly.extension.undertow.security.jacc.JACCContextIdHandler.handleRequest(JACCContextIdHandler.java:61)
> at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
> at org.wildfly.extension.undertow.deployment.GlobalRequestControllerHandler.handleRequest(GlobalRequestControllerHandler.java:68)
> at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
> at io.undertow.servlet.handlers.ServletInitialHandler.handleFirstRequest(ServletInitialHandler.java:292)
> at io.undertow.servlet.handlers.ServletInitialHandler.access$100(ServletInitialHandler.java:81)
> at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:138)
> at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:135)
> at io.undertow.servlet.core.ServletRequestContextThreadSetupAction$1.call(ServletRequestContextThreadSetupAction.java:48)
> at io.undertow.servlet.core.ContextClassLoaderSetupAction$1.call(ContextClassLoaderSetupAction.java:43)
> at org.wildfly.extension.undertow.security.SecurityContextThreadSetupAction.lambda$create$0(SecurityContextThreadSetupAction.java:105)
> at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1514)
> at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1514)
> at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1514)
> at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1514)
> at io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:272)
> at io.undertow.servlet.handlers.ServletInitialHandler.access$000(ServletInitialHandler.java:81)
> at io.undertow.servlet.handlers.ServletInitialHandler$1.handleRequest(ServletInitialHandler.java:104)
> at io.undertow.server.Connectors.executeRootHandler(Connectors.java:360)
> at io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:830)
> at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
> at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1985)
> at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1487)
> at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1349)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: org.xml.sax.SAXException: Error Handling [jar:file:/tmp/jboss-eap-7.2/modules/system/layers/base/com/sun/jsf-impl/main/jsf-impl-2.2.13.SP5-redhat-1.jar!/META-INF/mojarra_ext.taglib.xml@47,31]
> at com.sun.facelets.compiler.TagLibraryConfig$LibraryHandler.error(TagLibraryConfig.java:376)
> at org.apache.xerces.util.ErrorHandlerWrapper.error(ErrorHandlerWrapper.java:135)
> at org.apache.xerces.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:394)
> at org.apache.xerces.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:325)
> at org.apache.xerces.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:282)
> at org.apache.xerces.impl.dtd.XMLDTDValidator.rootElementSpecified(XMLDTDValidator.java:1644)
> at org.apache.xerces.impl.dtd.XMLDTDValidator.handleStartElement(XMLDTDValidator.java:1922)
> at org.apache.xerces.impl.dtd.XMLDTDValidator.startElement(XMLDTDValidator.java:787)
> at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanStartElement(XMLDocumentFragmentScannerImpl.java:827)
> at org.apache.xerces.impl.XMLDocumentScannerImpl$ContentDispatcher.scanRootElementHook(XMLDocumentScannerImpl.java:1141)
> at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(XMLDocumentFragmentScannerImpl.java:1754)
> at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:324)
> at org.apache.xerces.parsers.XML11Configuration.parse(XML11Configuration.java:875)
> at org.apache.xerces.parsers.XML11Configuration.parse(XML11Configuration.java:798)
> at org.apache.xerces.parsers.XMLParser.parse(XMLParser.java:108)
> at org.apache.xerces.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1198)
> at org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:564)
> at org.apache.xerces.jaxp.SAXParserImpl.parse(SAXParserImpl.java:298)
> at javax.xml.parsers.SAXParser.parse(SAXParser.java:195)
> at com.sun.facelets.compiler.TagLibraryConfig.create(TagLibraryConfig.java:407)
> ... 53 more
> {code}
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months
[JBoss JIRA] (ELY-1680) IBM, failing KeyStoreSuiteChild.testGetCertificateChainBinary
by Farah Juma (Jira)
[ https://issues.jboss.org/browse/ELY-1680?page=com.atlassian.jira.plugin.s... ]
Farah Juma commented on ELY-1680:
---------------------------------
[~jondruse] It would be great if you could look into this. Thanks!
> IBM, failing KeyStoreSuiteChild.testGetCertificateChainBinary
> -------------------------------------------------------------
>
> Key: ELY-1680
> URL: https://issues.jboss.org/browse/ELY-1680
> Project: WildFly Elytron
> Issue Type: Bug
> Components: Testsuite
> Affects Versions: 1.6.1.Final
> Reporter: Martin Choma
> Priority: Major
> Fix For: 1.7.0.CR3
>
> Attachments: ldap-keystore-gen.sh
>
>
> {code}
> [ERROR] testGetCertificateChainBinary(org.wildfly.security.ldap.KeyStoreSuiteChild) Time elapsed: 0.057 s <<< FAILURE!
> org.junit.ComparisonFailure: expected:<CN=[firefly_binary], OU=Elytron, O=Elyt...> but was:<CN=[localhost], OU=Elytron, O=Elyt...>
> at org.wildfly.security.ldap.KeyStoreSuiteChild.testGetCertificateChainBinary(KeyStoreSuiteChild.java:136)
> at org.wildfly.security.ldap.DirContextFactoryRule$1.evaluate(DirContextFactoryRule.java:218)
> {code}
> If I switch order of certificates in chain, then test passes.
> {code}
> diff --git a/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java b/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java
> index d8095867a..cda635beb 100644
> --- a/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java
> +++ b/src/test/java/org/wildfly/security/ldap/KeyStoreSuiteChild.java
> @@ -133,8 +133,8 @@ public class KeyStoreSuiteChild {
> Certificate[] chain = keyStore.getCertificateChain("firefly_binary");
> Assert.assertNotNull(chain);
> Assert.assertEquals(2, chain.length);
> - Assert.assertEquals("CN=firefly_binary, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[0]).getSubjectDN().toString());
> - Assert.assertEquals("CN=localhost, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[1]).getSubjectDN().toString());
> + Assert.assertEquals("CN=firefly_binary, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[1]).getSubjectDN().toString());
> + Assert.assertEquals("CN=localhost, OU=Elytron, O=Elytron, L=Elytron, ST=Elytron, C=UK", ((X509Certificate)chain[0]).getSubjectDN().toString());
> }
> {code}
> -For some reason I want able to debug code with -Dmaven.surefire.debug (Breakpoint was never hit) to find out which calls switch the order.-
> It takes long (5min) for debugger to attach to code.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 7 months