[JBoss JIRA] (WFLY-9839) Incorrect lock management in infinispan
by Scott Marlow (JIRA)
[ https://issues.jboss.org/browse/WFLY-9839?page=com.atlassian.jira.plugin.... ]
Scott Marlow commented on WFLY-9839:
------------------------------------
[~pferraro] [~rhusar] have you heard of this problem before, which as explained above, Infinispan is not releasing an Infinispan lock after the call to MyEntityManager.updateMyEntity() returns, which should cause the MyEntityManager level JTA transaction to end (which should at least trigger Synchronization.afterCompletion()).
This sounds like it would be an Infinispan issue, which should probably be reported as an ISPN jira. What do you think?
> Incorrect lock management in infinispan
> ---------------------------------------
>
> Key: WFLY-9839
> URL: https://issues.jboss.org/browse/WFLY-9839
> Project: WildFly
> Issue Type: Bug
> Components: JPA / Hibernate, Transactions
> Affects Versions: 10.1.0.Final, 11.0.0.Final
> Environment: Reproduced on Debian 8 GNU/Linux,
> Java - openjdk version "1.8.0_131"
> Reporter: Oleg K
> Assignee: Scott Marlow
> Attachments: maven-with-arquillian-unittest.zip
>
>
> If we update one JPA entity with one id (primary key) in several transactions and refresh (via EntityManager.refresh call) loaded entity between them - infinispan does not release lock for the entity - so one can fail on timeout waiting for that lock to be released.
> The root exception is:
> org.infinispan.util.concurrent.TimeoutException: ISPN000299: Unable to acquire lock after 15 seconds for key 10 and requestor GlobalTransaction:<null>:6:local. Lock is held by GlobalTransaction:<null>:4:local
> at org.infinispan.util.concurrent.locks.impl.DefaultLockManager$KeyAwareExtendedLockPromise.lock(DefaultLockManager.java:238)
> at org.infinispan.interceptors.locking.AbstractLockingInterceptor.lockAndRecord(AbstractLockingInterceptor.java:193)
> at org.infinispan.interceptors.locking.AbstractTxLockingInterceptor.checkPendingAndLockKey(AbstractTxLockingInterceptor.java:193)
> at org.infinispan.interceptors.locking.AbstractTxLockingInterceptor.lockOrRegisterBackupLock(AbstractTxLockingInterceptor.java:116)
> at org.infinispan.interceptors.locking.PessimisticLockingInterceptor.visitDataWriteCommand(PessimisticLockingInterceptor.java:134)
> at org.infinispan.interceptors.locking.AbstractTxLockingInterceptor.visitPutKeyValueCommand(AbstractTxLockingInterceptor.java:65)
> at org.infinispan.commands.write.PutKeyValueCommand.acceptVisitor(PutKeyValueCommand.java:78)
> at org.infinispan.interceptors.base.CommandInterceptor.invokeNextInterceptor(CommandInterceptor.java:99)
> at org.infinispan.interceptors.TxInterceptor.enlistWriteAndInvokeNext(TxInterceptor.java:367)
> at org.infinispan.interceptors.TxInterceptor.visitPutKeyValueCommand(TxInterceptor.java:221)
> at org.infinispan.commands.write.PutKeyValueCommand.acceptVisitor(PutKeyValueCommand.java:78)
> at org.infinispan.interceptors.base.CommandInterceptor.invokeNextInterceptor(CommandInterceptor.java:99)
> at org.infinispan.interceptors.InvocationContextInterceptor.handleAll(InvocationContextInterceptor.java:114)
> at org.infinispan.interceptors.InvocationContextInterceptor.handleDefault(InvocationContextInterceptor.java:83)
> at org.infinispan.commands.AbstractVisitor.visitPutKeyValueCommand(AbstractVisitor.java:43)
> at org.infinispan.commands.write.PutKeyValueCommand.acceptVisitor(PutKeyValueCommand.java:78)
> at org.infinispan.interceptors.InterceptorChain.invoke(InterceptorChain.java:335)
> at org.infinispan.cache.impl.CacheImpl.executeCommandAndCommitIfNeeded(CacheImpl.java:1672)
> at org.infinispan.cache.impl.CacheImpl.putInternal(CacheImpl.java:1121)
> at org.infinispan.cache.impl.CacheImpl.put(CacheImpl.java:1111)
> at org.infinispan.cache.impl.DecoratedCache.put(DecoratedCache.java:453)
> at org.infinispan.cache.impl.AbstractDelegatingCache.put(AbstractDelegatingCache.java:291)
> at org.hibernate.cache.infinispan.access.TxInvalidationCacheAccessDelegate.update(TxInvalidationCacheAccessDelegate.java:67)
> at org.hibernate.cache.infinispan.entity.ReadWriteAccess.update(ReadWriteAccess.java:29)
> at org.hibernate.action.internal.EntityUpdateAction.cacheUpdate(EntityUpdateAction.java:222)
> at org.hibernate.action.internal.EntityUpdateAction.execute(EntityUpdateAction.java:196)
> at org.hibernate.engine.spi.ActionQueue.executeActions(ActionQueue.java:582)
> at org.hibernate.engine.spi.ActionQueue.executeActions(ActionQueue.java:456)
> at org.hibernate.event.internal.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:337)
> at org.hibernate.event.internal.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:39)
> at org.hibernate.internal.SessionImpl.flush(SessionImpl.java:1282)
> at org.hibernate.jpa.spi.AbstractEntityManagerImpl.flush(AbstractEntityManagerImpl.java:1300)
> at org.jboss.as.jpa.container.AbstractEntityManager.flush(AbstractEntityManager.java:459)
> at wildfly.infinispan.test.MyEntityManagerEJB.updateMyEntity(MyEntityManagerEJB.java:36)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (WFLY-9746) Revert JGroups capability reference to ChannelFactory
by Paul Ferraro (JIRA)
[ https://issues.jboss.org/browse/WFLY-9746?page=com.atlassian.jira.plugin.... ]
Paul Ferraro edited comment on WFLY-9746 at 2/15/18 2:02 PM:
-------------------------------------------------------------
The configuration you've specified is valid for the 2.0 schema, but not for the 3.0 schema, and the configuration specified uses the 3.0 schema. Remember that version 3.0 of the schema specified by this PR is different from the 3.0 schema included with the Artemis upgrade PR (this was the context under which the original jira was filed). If you use the configuration corresponding to the 2.0 schema as specified, everything works. If you want to use the 3.0 schema, you must use the correct attribute names.
e.g. for 2.0
<discovery-group name="foo" jgroups-stack="udp" jgroups-channel="activemq-cluster"/>
e.g. for 3.0
<discovery-group name="foo" jgroups-stack="udp" jgroups-cluster="activemq-cluster"/>
or
<discovery-group name="foo" jgroups-channel="ee" jgroups-cluster="activemq-cluster"/>
was (Author: pferraro):
You've specified configuration from the 2.0 schema, but are using the 3.0 schema. Remember that version 3.0 of the schema specified by this PR is different from the 3.0 schema included with the Artemis upgrade PR. If you use the configuration corresponding to the 2.0 schema as specified, it should work. If you want to use the 3.0 schema, you must use the correct attribute names.
e.g. for 2.0
<discovery-group name="foo" jgroups-stack="udp" jgroups-channel="activemq-cluster"/>
e.g. for 3.0
<discovery-group name="foo" jgroups-stack="udp" jgroups-cluster="activemq-cluster"/>
or
<discovery-group name="foo" jgroups-channel="ee" jgroups-cluster="activemq-cluster"/>
> Revert JGroups capability reference to ChannelFactory
> -----------------------------------------------------
>
> Key: WFLY-9746
> URL: https://issues.jboss.org/browse/WFLY-9746
> Project: WildFly
> Issue Type: Bug
> Components: Clustering, JMS
> Affects Versions: 12.0.0.Beta1
> Reporter: Paul Ferraro
> Assignee: Paul Ferraro
> Priority: Blocker
>
> There is regression If Artemis is configured to JGroups tcp stack to form cluster then server does not start and fail with:
> {code}
> 13:24:02,424 INFO [org.jboss.ws.common.management] (MSC service thread 1-8) JBWS022052: Starting JBossWS 5.1.9.Final (Apache CXF 3.1.12)
> 13:24:02,428 ERROR [org.jboss.as.controller.management-operation] (Controller Boot Thread) WFLYCTL0013: Operation ("add") failed - address: ([
> ("subsystem" => "messaging-activemq"),
> ("server" => "default")
> ]) - failure description: {
> "WFLYCTL0412: Required services that are not installed:" => [
> "jboss.messaging-activemq.default",
> "org.wildfly.clustering.command-dispatcher-factory.tcp"
> ],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => [
> "jboss.messaging-activemq.default.jms.manager is missing [jboss.messaging-activemq.default]",
> "jboss.messaging-activemq.default is missing [org.wildfly.clustering.command-dispatcher-factory.tcp]"
> ]
> }
> 13:24:02,438 INFO [org.jboss.as.controller] (Controller Boot Thread) WFLYCTL0183: Service status report
> WFLYCTL0184: New missing/unsatisfied dependencies:
> service jboss.messaging-activemq.default (unavailable) dependents: [service jboss.messaging-activemq.default.jms.manager]
> service org.wildfly.clustering.command-dispatcher-factory.tcp (missing) dependents: [service jboss.messaging-activemq.default]
> 13:24:02,485 INFO [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0212: Resuming server
> 13:24:02,487 INFO [org.jboss.as] (Controller Boot Thread) WFLYSRV0060: Http management interface listening on http://127.0.0.1:11990/management
> 13:24:02,487 INFO [org.jboss.as] (Controller Boot Thread) WFLYSRV0051: Admin console listening on http://127.0.0.1:11990
> {code}
> Configuration of jgroups and messaging-activemq subsystem:
> {code}
> <subsystem xmlns="urn:jboss:domain:jgroups:5.0">
> <channels default="ee">
> <channel name="ee" stack="udp" cluster="ejb"/>
> </channels>
> ...
> <stack name="tcp">
> <transport type="TCP" socket-binding="jgroups-tcp"/>
> <protocol type="org.jgroups.protocols.TCPPING">
> <property name="port_range">
> 10
> </property>
> <property name="num_initial_members">
> 1
> </property>
> <property name="initial_hosts">
> 127.0.0.1[9600]
> </property>
> <property name="timeout">
> 3000
> </property>
> </protocol>
> <protocol type="MERGE3"/>
> <protocol type="FD_SOCK"/>
> <protocol type="FD"/>
> <protocol type="VERIFY_SUSPECT"/>
> <protocol type="pbcast.NAKACK"/>
> <protocol type="UNICAST3"/>
> <protocol type="pbcast.STABLE"/>
> <protocol type="pbcast.GMS"/>
> <protocol type="UFC"/>
> <protocol type="MFC"/>
> <protocol type="FRAG2"/>
> <protocol type="RSVP"/>
> </stack>
> </stacks>
> </subsystem>
> ....
> <subsystem xmlns="urn:jboss:domain:messaging-activemq:2.0">
> <server name="default" persistence-enabled="true" id-cache-size="200000">
> <broadcast-group name="bg-group1" jgroups-stack="tcp" jgroups-channel="activemq-cluster" broadcast-period="2000" connectors="connector"/>
> <discovery-group name="dg-group1" jgroups-stack="tcp" jgroups-channel="activemq-cluster" refresh-timeout="10000"/>
> <cluster-connection name="my-cluster" address="jms" connector-name="connector" check-period="30000" connection-ttl="60000" call-timeout="30000" discovery-group="dg-group1"/>
> ...
> </server>
> </subsystem>
> {code}
> Attaching the whole config: standalone-full-ha.xml
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (WFLY-9007) The bin/product.conf and the org.jboss.as.product:<xxx> module should come in via an FP
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-9007?page=com.atlassian.jira.plugin.... ]
Brian Stansberry updated WFLY-9007:
-----------------------------------
Fix Version/s: (was: 12.0.0.CR1)
> The bin/product.conf and the org.jboss.as.product:<xxx> module should come in via an FP
> ---------------------------------------------------------------------------------------
>
> Key: WFLY-9007
> URL: https://issues.jboss.org/browse/WFLY-9007
> Project: WildFly
> Issue Type: Task
> Components: Server
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
>
> For WFLY-4692 we moved the "product" stuff out of [servlet-]feature-pack and into [servlet-]dist. But this means it doesn't end up in the skinny dist produced by the "[servlet-]build" module. Plus it makes the "dist" a kind of FP of its own.
> The stuff in [servlet-]dist/src/distribution should be its own FP. That one *perhaps* depends on the related normal feature-pack. Then build and dist use the new FP in addition to or instead of the regular feature-pack.
> So, the regular feature-pack is independently usable, in other dists, but our offiical build/dist, which has our official product module, picks up the new FP.
> Whether the new "product" FP depends on the regular feature-pack depends on how we want to use it; i.e. can this bin/product.conf and module be used in some other flavor of dist besides the official one.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (WFLY-9840) batch-jberet subsystem export should exclude the correct path
by Kabir Khan (JIRA)
Kabir Khan created WFLY-9840:
--------------------------------
Summary: batch-jberet subsystem export should exclude the correct path
Key: WFLY-9840
URL: https://issues.jboss.org/browse/WFLY-9840
Project: WildFly
Issue Type: Bug
Components: Batch
Affects Versions: 12.0.0.Beta1
Reporter: Kabir Khan
Assignee: Kabir Khan
Fix For: 12.0.0.CR1
batch-jberet/pom.xml currently has
{code}
<exclude path="org/wildfly/extension/batch/jberet/_private"/>
{code}
which does not exist. It should be:
{code}
<exclude path="org/wildfly/extension/batch/_private"/>
{code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months
[JBoss JIRA] (WFLY-1598) Out of the box SSL - or shortly after.
by Kabir Khan (JIRA)
[ https://issues.jboss.org/browse/WFLY-1598?page=com.atlassian.jira.plugin.... ]
Kabir Khan updated WFLY-1598:
-----------------------------
Fix Version/s: 12.0.0.CR1
(was: 12.0.0.Beta1)
> Out of the box SSL - or shortly after.
> --------------------------------------
>
> Key: WFLY-1598
> URL: https://issues.jboss.org/browse/WFLY-1598
> Project: WildFly
> Issue Type: Sub-task
> Components: Domain Management, Security
> Reporter: Darran Lofthouse
> Priority: Critical
> Labels: management_security,, management_sso
> Fix For: 12.0.0.CR1
>
>
> There are various reasons that we do not support SSL/TLS out of the box e.g.
> - If we ship a default keystore then everyone has access to the private key.
> - Generating one on first boot we do not have sufficient information to generate it correctly, also the performance overhead.
> This issue is to explorer other options to encourage their use and make it easier to configure.
> As an example could the admin console detect a non encrypted connection and have an box that encourages the config along with a wizard like workflow to get it set up?
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 2 months