[JBoss JIRA] (WFCORE-3757) Fix unreported failures in RBAC test suite
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3757?page=com.atlassian.jira.plugi... ]
Brian Stansberry reassigned WFCORE-3757:
----------------------------------------
Assignee: Brian Stansberry (was: Jeff Mesnil)
> Fix unreported failures in RBAC test suite
> ------------------------------------------
>
> Key: WFCORE-3757
> URL: https://issues.jboss.org/browse/WFCORE-3757
> Project: WildFly Core
> Issue Type: Bug
> Components: Test Suite
> Affects Versions: 5.0.0.Alpha3
> Reporter: Jeff Mesnil
> Assignee: Brian Stansberry
>
> The org.jboss.as.test.integration.mgmt.access.PropertiesRoleMappingTestCase is run 3 times in the rbac test suite accross 3 different surefire execution:
> * one as PropertiesRoleMappingTestCase
> * one in LdapRoleMappingG2UTestCase Suite
> * one in LdapRoleMappingU2GTestCase Suite
> We had an issue with WFCORE-3705 that was making the test fails for the 2 ldap suites.
> The maven execution was failing but our CI was reporting that the test suite was failing as TeamCity does not distinguish the test execution across different suites.
> The regression was identified only during the release of WildFly Core 5.0.0.Alpha3.
> The rbac test suite should reliably report any failures and we need to make sure that our CI handle them properly.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (WFCORE-3757) Fix unreported failures in RBAC test suite
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3757?page=com.atlassian.jira.plugi... ]
Brian Stansberry reassigned WFCORE-3757:
----------------------------------------
Assignee: Jeff Mesnil (was: Brian Stansberry)
> Fix unreported failures in RBAC test suite
> ------------------------------------------
>
> Key: WFCORE-3757
> URL: https://issues.jboss.org/browse/WFCORE-3757
> Project: WildFly Core
> Issue Type: Bug
> Components: Test Suite
> Affects Versions: 5.0.0.Alpha3
> Reporter: Jeff Mesnil
> Assignee: Jeff Mesnil
>
> The org.jboss.as.test.integration.mgmt.access.PropertiesRoleMappingTestCase is run 3 times in the rbac test suite accross 3 different surefire execution:
> * one as PropertiesRoleMappingTestCase
> * one in LdapRoleMappingG2UTestCase Suite
> * one in LdapRoleMappingU2GTestCase Suite
> We had an issue with WFCORE-3705 that was making the test fails for the 2 ldap suites.
> The maven execution was failing but our CI was reporting that the test suite was failing as TeamCity does not distinguish the test execution across different suites.
> The regression was identified only during the release of WildFly Core 5.0.0.Alpha3.
> The rbac test suite should reliably report any failures and we need to make sure that our CI handle them properly.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (WFLY-10283) Enhance CommandDispatcher async methods to use CompletableFutures
by Paul Ferraro (JIRA)
Paul Ferraro created WFLY-10283:
-----------------------------------
Summary: Enhance CommandDispatcher async methods to use CompletableFutures
Key: WFLY-10283
URL: https://issues.jboss.org/browse/WFLY-10283
Project: WildFly
Issue Type: Enhancement
Components: Clustering
Affects Versions: No Release
Reporter: Paul Ferraro
Assignee: Paul Ferraro
This allows consumers of CommandDispatcher to implement non-blocking handling of dispatched commands.
The submitOnNode(...) method can just be modified to return the more specific return value. However, the submitOnCluster(...) will need a different method name (or signature).
The MessageDispatcher in JGroups 4 now returns CompletableFutures natively, which means we can easily support this without the addition of yet another thread pool.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (DROOLS-2486) Drools Runtime does not recognize Custom Operator Parameter
by bharath mogali (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2486?page=com.atlassian.jira.plugi... ]
bharath mogali commented on DROOLS-2486:
----------------------------------------
Not sure if this helps, but we tried to copied entire code from Drools Repo for Str operator and created our own operator. Surprisingly our tests mentioned earlier did not work.
We have other operators like date[before/after/equals] we are noticing same behavior for them as well.
> Drools Runtime does not recognize Custom Operator Parameter
> -----------------------------------------------------------
>
> Key: DROOLS-2486
> URL: https://issues.jboss.org/browse/DROOLS-2486
> Project: Drools
> Issue Type: Feature Request
> Components: core engine
> Affects Versions: 7.7.0.Final
> Reporter: bharath mogali
> Assignee: Mario Fusco
>
> Problem Statement:
> We have few custom operators for Date and Strings, which are implemented looking at Str operator like shown here: https://github.com/kiegroup/drools/blob/f7ab4ee3c88d767a8cbb372c2db1afa84...
> with below configuration in kie.properties.conf:
> drools.evaluator.str = com.company.drools.operators.StrEvaluatorDefinition
> For Custom Str operator we created, Drools runtime is not able to make distinction between Str[begins] and Str[ends].
> What this means is when we are running below tests, we expect Rule-1 to fail and Rule-2 to get activated. But what we noticed is, Rule-2 will not be activated.
> // Facts input into drools :
> // str1 = drools
> // str2 = dr
> rule "Rule-1"
> when message : Customer( str1 str[endsWith] str2 )
> then System.out.println("Rule - Str 1 - fired");
> end
> rule "Rule-2"
> when message : Customer( str1 str[startsWith] str2 )
> then System.out.println("Rule - Str 2 - fired");
> end
> Other Observations:
> If we change RHS to a a string literal like shown below, then Rule-2 will be Activated.
> // Facts input into drools :
> // str1 = drools
> // str2 = dr
> rule "Rule-1"
> when message : Customer( str1 str[endsWith] "abc" )
> then System.out.println("Rule - Str 1 - fired");
> end
> rule "Rule-2"
> when message : Customer( str1 str[startsWith] str2 )
> then System.out.println("Rule - Str 2 - fired");
> end
> Finally
> We removed Str custom operator, and then used the out of the box Str operator provided by drools. We ran below mentioned tests again, this time Rule-2 gets activated.
> // Facts input into drools :
> // str1 = drools
> // str2 = dr
> rule "Rule-1"
> when message : Customer( str1 str[endsWith] str2 )
> then System.out.println("Rule - Str 1 - fired");
> end
> rule "Rule-2"
> when message : Customer( str1 str[startsWith] str2 )
> then System.out.println("Rule - Str 2 - fired");
> end
> Based on our tests, it seems like custom operators are not processed correctly.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (WFLY-9842) Enhance CommandDispatcher async methods to use CompletableFutures
by Paul Ferraro (JIRA)
[ https://issues.jboss.org/browse/WFLY-9842?page=com.atlassian.jira.plugin.... ]
Paul Ferraro updated WFLY-9842:
-------------------------------
Summary: Enhance CommandDispatcher async methods to use CompletableFutures (was: Enhance CommandDispatcher's async methods to return CompletableFutures)
> Enhance CommandDispatcher async methods to use CompletableFutures
> -----------------------------------------------------------------
>
> Key: WFLY-9842
> URL: https://issues.jboss.org/browse/WFLY-9842
> Project: WildFly
> Issue Type: Enhancement
> Components: Clustering
> Affects Versions: No Release
> Reporter: Paul Ferraro
> Assignee: Paul Ferraro
>
> This allows consumers of CommandDispatcher to implement non-blocking handling of dispatched commands.
> The submitOnNode(...) method can just be modified to return the more specific return value. However, the submitOnCluster(...) will need a different method name (or signature).
> The MessageDispatcher in JGroups 4 now returns CompletableFutures natively, which means we can easily support this without the addition of yet another thread pool.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years
[JBoss JIRA] (DROOLS-2486) Drools Runtime does not recognize Custom Operator Parameter
by bharath mogali (JIRA)
bharath mogali created DROOLS-2486:
--------------------------------------
Summary: Drools Runtime does not recognize Custom Operator Parameter
Key: DROOLS-2486
URL: https://issues.jboss.org/browse/DROOLS-2486
Project: Drools
Issue Type: Feature Request
Components: core engine
Affects Versions: 7.7.0.Final
Reporter: bharath mogali
Assignee: Mario Fusco
Problem Statement:
We have few custom operators for Date and Strings, which are implemented looking at Str operator like shown here: https://github.com/kiegroup/drools/blob/f7ab4ee3c88d767a8cbb372c2db1afa84...
with below configuration in kie.properties.conf:
drools.evaluator.str = com.company.drools.operators.StrEvaluatorDefinition
For Custom Str operator we created, Drools runtime is not able to make distinction between Str[begins] and Str[ends].
What this means is when we are running below tests, we expect Rule-1 to fail and Rule-2 to get activated. But what we noticed is, Rule-2 will not be activated.
// Facts input into drools :
// str1 = drools
// str2 = dr
rule "Rule-1"
when message : Customer( str1 str[endsWith] str2 )
then System.out.println("Rule - Str 1 - fired");
end
rule "Rule-2"
when message : Customer( str1 str[startsWith] str2 )
then System.out.println("Rule - Str 2 - fired");
end
Other Observations:
If we change RHS to a a string literal like shown below, then Rule-2 will be Activated.
// Facts input into drools :
// str1 = drools
// str2 = dr
rule "Rule-1"
when message : Customer( str1 str[endsWith] "abc" )
then System.out.println("Rule - Str 1 - fired");
end
rule "Rule-2"
when message : Customer( str1 str[startsWith] str2 )
then System.out.println("Rule - Str 2 - fired");
end
Finally
We removed Str custom operator, and then used the out of the box Str operator provided by drools. We ran below mentioned tests again, this time Rule-2 gets activated.
// Facts input into drools :
// str1 = drools
// str2 = dr
rule "Rule-1"
when message : Customer( str1 str[endsWith] str2 )
then System.out.println("Rule - Str 1 - fired");
end
rule "Rule-2"
when message : Customer( str1 str[startsWith] str2 )
then System.out.println("Rule - Str 2 - fired");
end
Based on our tests, it seems like custom operators are not processed correctly.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years