[JBoss JIRA] (WFWIP-280) Warnings propagated from io.smallrye.jwt.auth.* don't have assigned ID
by Darran Lofthouse (Jira)
[ https://issues.redhat.com/browse/WFWIP-280?page=com.atlassian.jira.plugin... ]
Darran Lofthouse commented on WFWIP-280:
----------------------------------------
[~jkasik]
I agree the error messages are very valuable which is why I have agreed to see if the SmallRye JWT project will accept using them, but this is one of the costs of using third party libraries over our own - we loose the ability to enforce our own logging standards over them.
Regarding the text you are quoting, that includes the word "caught", it is not the most descriptive chunks of text but if we are talking about something being "caught" in Java it would imply it has previously been thrown - i.e. an Exception or other Throwable.
If we have cases of exceptions being caught by our code and subsequently logged or rethrown by our code I 100% agree we should be logging or rethrowing with a message ID, generally code that doesn't do this correctly should fail code review.
But the message that has led to this WFWIP issue is not thrown by SmallRye JWT and so it not "caught" by our code, the quoted message is directly logged by SmallRye JWT.
So the plan we will take will be to see if SmallRye JWT will accept IDs being added to their messages. This specific message however will likely be dropped to DEBUG or TRACE level anyway or I will see if it can be moved to a per-request logging category instead.
> Warnings propagated from io.smallrye.jwt.auth.* don't have assigned ID
> ----------------------------------------------------------------------
>
> Key: WFWIP-280
> URL: https://issues.redhat.com/browse/WFWIP-280
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP JWT
> Reporter: Jan Kasik
> Assignee: Darran Lofthouse
> Priority: Critical
>
> Warning which are propagated to log from io.smallrye.jwt.auth package don't have assigned logging ID.
> Example:
> {code}
> 11:52:50,705 WARN [io.smallrye.jwt.auth.mechanism.JWTHttpAuthenticationMechanism] (default task-1) Unable to validate bearer token: Failed to verify token: io.smallrye.jwt.auth.principal.ParseException: Failed to verify token
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (WFWIP-280) Warnings propagated from io.smallrye.jwt.auth.* don't have assigned ID
by Jan Kasik (Jira)
[ https://issues.redhat.com/browse/WFWIP-280?page=com.atlassian.jira.plugin... ]
Jan Kasik commented on WFWIP-280:
---------------------------------
[~dlofthouse] What I'm afraid of is that having no logging IDs also means limited means of log monitoring and filtering. This might be crucial for some users since missing logging IDs can introduce false alarms in their established monitoring solutions and other unpredictable issues. The document also specifically mentions third-party projects:
{quote}
Messages generated by third-party code should be caught by the consumer, which will typically be a JBoss project. The consumer should then map the third-party framework error into something that is both meaningful to the user and follows this convention.
{quote}
> Warnings propagated from io.smallrye.jwt.auth.* don't have assigned ID
> ----------------------------------------------------------------------
>
> Key: WFWIP-280
> URL: https://issues.redhat.com/browse/WFWIP-280
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP JWT
> Reporter: Jan Kasik
> Assignee: Darran Lofthouse
> Priority: Critical
>
> Warning which are propagated to log from io.smallrye.jwt.auth package don't have assigned logging ID.
> Example:
> {code}
> 11:52:50,705 WARN [io.smallrye.jwt.auth.mechanism.JWTHttpAuthenticationMechanism] (default task-1) Unable to validate bearer token: Failed to verify token: io.smallrye.jwt.auth.principal.ParseException: Failed to verify token
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (WFWIP-280) Warnings propagated from io.smallrye.jwt.auth.* don't have assigned ID
by Darran Lofthouse (Jira)
[ https://issues.redhat.com/browse/WFWIP-280?page=com.atlassian.jira.plugin... ]
Darran Lofthouse updated WFWIP-280:
-----------------------------------
Priority: Critical (was: Blocker)
> Warnings propagated from io.smallrye.jwt.auth.* don't have assigned ID
> ----------------------------------------------------------------------
>
> Key: WFWIP-280
> URL: https://issues.redhat.com/browse/WFWIP-280
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP JWT
> Reporter: Jan Kasik
> Assignee: Darran Lofthouse
> Priority: Critical
>
> Warning which are propagated to log from io.smallrye.jwt.auth package don't have assigned logging ID.
> Example:
> {code}
> 11:52:50,705 WARN [io.smallrye.jwt.auth.mechanism.JWTHttpAuthenticationMechanism] (default task-1) Unable to validate bearer token: Failed to verify token: io.smallrye.jwt.auth.principal.ParseException: Failed to verify token
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (WFWIP-280) Warnings propagated from io.smallrye.jwt.auth.* don't have assigned ID
by Darran Lofthouse (Jira)
[ https://issues.redhat.com/browse/WFWIP-280?page=com.atlassian.jira.plugin... ]
Darran Lofthouse commented on WFWIP-280:
----------------------------------------
I don't agree this is a Blocker, by flagging as a Blocker it is effectively saying that we will not include this feature in WildFly unless it is resolved.
>From the perspective of Wildfly SmallRye is a third party project, it is not our place to force WildFly coding standards onto a third party project. I am going to see if they will accept a contribution to accept message IDs in their project but if for any reason they choose not to accept this we will be using SmallRye JWT with messages that do not contain an ID.
The wiki page you are quoting is specifically in relation to JBoss projects, SmallRye is NOT a JBoss project. Due to this I am going to drop the priority to Critical, I am happy we prioritise looking for a solution but not omitting an entire feature.
As with all third party projects we have to accept the logging they provide us with. Exceptions may be slightly different as we could have an opportunity to catch any exception thrown and log it ourselves or rethrow it ourselves with a new associated ID but we do not have that option for logged messages.
[~maeste] / [~bstansberry2] FYI ^^^ When we pull in a third party library to the application server instead of developing it ourselves we can not be imposing JBoss logging requirements onto that component.
> Warnings propagated from io.smallrye.jwt.auth.* don't have assigned ID
> ----------------------------------------------------------------------
>
> Key: WFWIP-280
> URL: https://issues.redhat.com/browse/WFWIP-280
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP JWT
> Reporter: Jan Kasik
> Assignee: Darran Lofthouse
> Priority: Blocker
>
> Warning which are propagated to log from io.smallrye.jwt.auth package don't have assigned logging ID.
> Example:
> {code}
> 11:52:50,705 WARN [io.smallrye.jwt.auth.mechanism.JWTHttpAuthenticationMechanism] (default task-1) Unable to validate bearer token: Failed to verify token: io.smallrye.jwt.auth.principal.ParseException: Failed to verify token
> {code}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months
[JBoss JIRA] (WFLY-12866) Add MP Metrics test for Webservice
by Jim Ma (Jira)
Jim Ma created WFLY-12866:
-----------------------------
Summary: Add MP Metrics test for Webservice
Key: WFLY-12866
URL: https://issues.redhat.com/browse/WFLY-12866
Project: WildFly
Issue Type: Task
Components: Web Services
Affects Versions: 18.0.1.Final
Reporter: Jim Ma
Assignee: Jim Ma
Fix For: 19.0.0.Beta1
Add a Microprofile-metrics test to demonstrate this works for webservice endpoint
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 5 months