[JBoss JIRA] (DROOLS-5710) [DMN XML] Signavio Profile - DayDiffFunction: Should work with Date and DateTime values
by Jonas Beyer (Jira)
[ https://issues.redhat.com/browse/DROOLS-5710?page=com.atlassian.jira.plug... ]
Jonas Beyer commented on DROOLS-5710:
-------------------------------------
Hi [~tari_manga], thanks for the quick response! We've created and linked a PR for extending the Signavio function. We'd prefer if this would work with {{today()}} as well as {{now()}} :)
> [DMN XML] Signavio Profile - DayDiffFunction: Should work with Date and DateTime values
> ---------------------------------------------------------------------------------------
>
> Key: DROOLS-5710
> URL: https://issues.redhat.com/browse/DROOLS-5710
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Reporter: Jonas Beyer
> Assignee: Matteo Mortari
> Priority: Minor
>
> If the DayDiff() function is called with a parameter of data type Date, an error is thrown during runtime.
> Example:
> {quote}dayDiff(myDate, today())
> {quote}
> h3. Acceptance Criteria:
> * DayDiff function can be called with datatypes Date and Datetime in any combination
> ** Date, Date
> ** Date, Datetime
> ** Datetime, Date
> ** Datetime, Datetime
> h3. Details:
> The {{DayDiffFunction}} is implemented using {{Duration#between}} . This implementation will try to calculate the duration between the given {{Temporal}} s based on their nanoseconds or seconds, which can't be extracted from values of type Date that don't have a time component.
> Suggestion: Manually convert the parameters to {{Instant}} s, using the start of the day as time component for Date values.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[JBoss JIRA] (DROOLS-5710) [DMN XML] Signavio Profile - DayDiffFunction: Should work with Date and DateTime values
by Jonas Beyer (Jira)
[ https://issues.redhat.com/browse/DROOLS-5710?page=com.atlassian.jira.plug... ]
Jonas Beyer updated DROOLS-5710:
--------------------------------
Git Pull Request: https://github.com/kiegroup/drools/pull/3153
> [DMN XML] Signavio Profile - DayDiffFunction: Should work with Date and DateTime values
> ---------------------------------------------------------------------------------------
>
> Key: DROOLS-5710
> URL: https://issues.redhat.com/browse/DROOLS-5710
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Reporter: Jonas Beyer
> Assignee: Matteo Mortari
> Priority: Minor
>
> If the DayDiff() function is called with a parameter of data type Date, an error is thrown during runtime.
> Example:
> {quote}dayDiff(myDate, today())
> {quote}
> h3. Acceptance Criteria:
> * DayDiff function can be called with datatypes Date and Datetime in any combination
> ** Date, Date
> ** Date, Datetime
> ** Datetime, Date
> ** Datetime, Datetime
> h3. Details:
> The {{DayDiffFunction}} is implemented using {{Duration#between}} . This implementation will try to calculate the duration between the given {{Temporal}} s based on their nanoseconds or seconds, which can't be extracted from values of type Date that don't have a time component.
> Suggestion: Manually convert the parameters to {{Instant}} s, using the start of the day as time component for Date values.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[JBoss JIRA] (DROOLS-5710) [DMN XML] Signavio Profile - DayDiffFunction: Should work with Date and DateTime values
by Jonas Beyer (Jira)
[ https://issues.redhat.com/browse/DROOLS-5710?page=com.atlassian.jira.plug... ]
Jonas Beyer updated DROOLS-5710:
--------------------------------
Description:
If the DayDiff() function is called with a parameter of data type Date, an error is thrown during runtime.
Example:
{quote}dayDiff(myDate, today())
{quote}
h3. Acceptance Criteria:
* DayDiff function can be called with datatypes Date and Datetime in any combination
** Date, Date
** Date, Datetime
** Datetime, Date
** Datetime, Datetime
h3. Details:
The {{DayDiffFunction}} is implemented using {{Duration#between}} . This implementation will try to calculate the duration between the given {{Temporal}} s based on their nanoseconds or seconds, which can't be extracted from values of type Date that don't have a time component.
Suggestion: Manually convert the parameters to {{Instant}} s, using the start of the day as time component for Date values.
was:
If the DayDiff() function is called with a parameter of data type Date, an error is thrown during runtime.
Example:
{quote}dayDiff(myDate, today())
{quote}
h3. Acceptance Criteria:
* DayDiff function can be called with datatypes Date and Datetime in any combination
** Date, Date
** Date, Datetime
** Datetime, Date
** Datetime, Datetime
h3. Details:
The {{DayDiffFunction}} is implemented using {{Duration#between}}. This implementation will try to calculate the duration between the given {{Temporal}}s based on their nanoseconds or seconds, which can't be extracted from values of type Date that don't have a time component.
Suggestion: Manually convert the parameters to {{Instant}}s, using the start of the day as time component for Date values.
> [DMN XML] Signavio Profile - DayDiffFunction: Should work with Date and DateTime values
> ---------------------------------------------------------------------------------------
>
> Key: DROOLS-5710
> URL: https://issues.redhat.com/browse/DROOLS-5710
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Reporter: Jonas Beyer
> Assignee: Matteo Mortari
> Priority: Minor
>
> If the DayDiff() function is called with a parameter of data type Date, an error is thrown during runtime.
> Example:
> {quote}dayDiff(myDate, today())
> {quote}
> h3. Acceptance Criteria:
> * DayDiff function can be called with datatypes Date and Datetime in any combination
> ** Date, Date
> ** Date, Datetime
> ** Datetime, Date
> ** Datetime, Datetime
> h3. Details:
> The {{DayDiffFunction}} is implemented using {{Duration#between}} . This implementation will try to calculate the duration between the given {{Temporal}} s based on their nanoseconds or seconds, which can't be extracted from values of type Date that don't have a time component.
> Suggestion: Manually convert the parameters to {{Instant}} s, using the start of the day as time component for Date values.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[JBoss JIRA] (DROOLS-5710) [DMN XML] Signavio Profile - DayDiffFunction: Should work with Date and DateTime values
by Matteo Mortari (Jira)
[ https://issues.redhat.com/browse/DROOLS-5710?page=com.atlassian.jira.plug... ]
Matteo Mortari commented on DROOLS-5710:
----------------------------------------
Hi [~jonas.beyer] if you are going to propose an extension of this Signavio function for a default behaviour as listed in the acceptance criteria, is very fine with me, I just wanted to add a potential additional solution would be (without modification) just having:
{code:java}
dayDiff(myDate, now())
{code}
> [DMN XML] Signavio Profile - DayDiffFunction: Should work with Date and DateTime values
> ---------------------------------------------------------------------------------------
>
> Key: DROOLS-5710
> URL: https://issues.redhat.com/browse/DROOLS-5710
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Reporter: Jonas Beyer
> Assignee: Matteo Mortari
> Priority: Minor
>
> If the DayDiff() function is called with a parameter of data type Date, an error is thrown during runtime.
> Example:
> {quote}dayDiff(myDate, today())
> {quote}
> h3. Acceptance Criteria:
> * DayDiff function can be called with datatypes Date and Datetime in any combination
> ** Date, Date
> ** Date, Datetime
> ** Datetime, Date
> ** Datetime, Datetime
> h3. Details:
> The {{DayDiffFunction}} is implemented using {{Duration#between}}. This implementation will try to calculate the duration between the given {{Temporal}}s based on their nanoseconds or seconds, which can't be extracted from values of type Date that don't have a time component.
> Suggestion: Manually convert the parameters to {{Instant}}s, using the start of the day as time component for Date values.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[JBoss JIRA] (DROOLS-5711) [DMN XML] Signavio Profile - MultiInstanceDecisionLogic: MID requirements are not linked
by Jonas Beyer (Jira)
Jonas Beyer created DROOLS-5711:
-----------------------------------
Summary: [DMN XML] Signavio Profile - MultiInstanceDecisionLogic: MID requirements are not linked
Key: DROOLS-5711
URL: https://issues.redhat.com/browse/DROOLS-5711
Project: Drools
Issue Type: Bug
Components: dmn engine
Reporter: Jonas Beyer
Assignee: Matteo Mortari
h3. Summary:
When evaluating a decision model that contains a MultiInstanceDecision, the result will often times be {{[null]}}, because the engine will not evaluate the decision dependencies of the MID first, and simply execute the MID with empty inputs instead.
h3. Details:
The statement that will cause decisions to consider their requirements during evaluation is missing for MultiInstanceDecisions:
{code:java}
compiler.linkRequirements( model, di );{code}
Inside {{org.kie.dmn.signavio.MultiInstanceDecisionLogic.MultiInstanceDecisionNodeCompiler#compileEvaluator}}
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[JBoss JIRA] (DROOLS-5710) [DMN XML] Signavio Profile - DayDiffFunction: Should work with Date and DateTime values
by Jonas Beyer (Jira)
[ https://issues.redhat.com/browse/DROOLS-5710?page=com.atlassian.jira.plug... ]
Jonas Beyer updated DROOLS-5710:
--------------------------------
Description:
If the DayDiff() function is called with a parameter of data type Date, an error is thrown during runtime.
Example:
{quote}dayDiff(myDate, today())
{quote}
h3. Acceptance Criteria:
* DayDiff function can be called with datatypes Date and Datetime in any combination
** Date, Date
** Date, Datetime
** Datetime, Date
** Datetime, Datetime
h3. Details:
The {{DayDiffFunction}} is implemented using {{Duration#between}}. This implementation will try to calculate the duration between the given {{Temporal}}s based on their nanoseconds or seconds, which can't be extracted from values of type Date that don't have a time component.
Suggestion: Manually convert the parameters to {{Instant}}s, using the start of the day as time component for Date values.
was:
If the DayDiff() function is called with a parameter of data type Date, an error is thrown during runtime.
Example:
{quote}dayDiff(myDate, today())
{quote}
h3. Acceptance Criteria:
* DayDiff function can be called with datatypes Date and Datetime in any combination
** Date, Date
** Date, Datetime
** Datetime, Date
** Datetime, Datetime
> [DMN XML] Signavio Profile - DayDiffFunction: Should work with Date and DateTime values
> ---------------------------------------------------------------------------------------
>
> Key: DROOLS-5710
> URL: https://issues.redhat.com/browse/DROOLS-5710
> Project: Drools
> Issue Type: Bug
> Components: dmn engine
> Reporter: Jonas Beyer
> Assignee: Matteo Mortari
> Priority: Minor
>
> If the DayDiff() function is called with a parameter of data type Date, an error is thrown during runtime.
> Example:
> {quote}dayDiff(myDate, today())
> {quote}
> h3. Acceptance Criteria:
> * DayDiff function can be called with datatypes Date and Datetime in any combination
> ** Date, Date
> ** Date, Datetime
> ** Datetime, Date
> ** Datetime, Datetime
> h3. Details:
> The {{DayDiffFunction}} is implemented using {{Duration#between}}. This implementation will try to calculate the duration between the given {{Temporal}}s based on their nanoseconds or seconds, which can't be extracted from values of type Date that don't have a time component.
> Suggestion: Manually convert the parameters to {{Instant}}s, using the start of the day as time component for Date values.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[JBoss JIRA] (DROOLS-5710) [DMN XML] Signavio Profile - DayDiffFunction: Should work with Date and DateTime values
by Jonas Beyer (Jira)
Jonas Beyer created DROOLS-5710:
-----------------------------------
Summary: [DMN XML] Signavio Profile - DayDiffFunction: Should work with Date and DateTime values
Key: DROOLS-5710
URL: https://issues.redhat.com/browse/DROOLS-5710
Project: Drools
Issue Type: Bug
Components: dmn engine
Reporter: Jonas Beyer
Assignee: Matteo Mortari
If the DayDiff() function is called with a parameter of data type Date, an error is thrown during runtime.
Example:
{quote}dayDiff(myDate, today())
{quote}
h3. Acceptance Criteria:
* DayDiff function can be called with datatypes Date and Datetime in any combination
** Date, Date
** Date, Datetime
** Datetime, Date
** Datetime, Datetime
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[JBoss JIRA] (JGRP-2418) Impedence mismatch between message types and transports
by Bela Ban (Jira)
[ https://issues.redhat.com/browse/JGRP-2418?page=com.atlassian.jira.plugin... ]
Bela Ban closed JGRP-2418.
--------------------------
Resolution: Won't Do
See previous comments
> Impedence mismatch between message types and transports
> -------------------------------------------------------
>
> Key: JGRP-2418
> URL: https://issues.redhat.com/browse/JGRP-2418
> Project: JGroups
> Issue Type: Enhancement
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Major
> Fix For: 5.1
>
>
> When sending a message (_of any type_), it is currently marshalled into a byte[] array, which is handled differently by each transport:
> * UDP wraps it into a DatagramPacket and calls DatagramSocket.send()
> * TCP writes the array to the socket's output stream
> * TCP_NIO2 wraps it into a {{ByteBuffer}} and calls SocketChannel.write(ByteBuffer)
> In some cases, there is an impedance mismatch between the type of the message and the type of the transport: for example, when sending an NioMessage (containing a ByteBuffer), we don't actually need the conversion to byte array and the subsequent wrapping into a ByteBuffer; this is superfluous. Even worse, when using off-heap, this creates an unneeded memory allocation. Passing the *same* ByteBuffer all the way down from the application to the transport would be better.
> This requires changes in the way bundlers accumulate messages. Also, perhaps the transport itself should become an SPI, to which a generic {{Transport}} protocol delegates. This would also allow us to implement multiple transports (JGRP-1424) in the same stack.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months
[JBoss JIRA] (JGRP-2418) Impedence mismatch between message types and transports
by Bela Ban (Jira)
[ https://issues.redhat.com/browse/JGRP-2418?page=com.atlassian.jira.plugin... ]
Bela Ban commented on JGRP-2418:
--------------------------------
OK, closing this. Marshalling/unmarshalling symmetry would have been nice, but this would have been an effort for no apparent perf or maintenance gain
> Impedence mismatch between message types and transports
> -------------------------------------------------------
>
> Key: JGRP-2418
> URL: https://issues.redhat.com/browse/JGRP-2418
> Project: JGroups
> Issue Type: Enhancement
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Major
> Fix For: 5.1
>
>
> When sending a message (_of any type_), it is currently marshalled into a byte[] array, which is handled differently by each transport:
> * UDP wraps it into a DatagramPacket and calls DatagramSocket.send()
> * TCP writes the array to the socket's output stream
> * TCP_NIO2 wraps it into a {{ByteBuffer}} and calls SocketChannel.write(ByteBuffer)
> In some cases, there is an impedance mismatch between the type of the message and the type of the transport: for example, when sending an NioMessage (containing a ByteBuffer), we don't actually need the conversion to byte array and the subsequent wrapping into a ByteBuffer; this is superfluous. Even worse, when using off-heap, this creates an unneeded memory allocation. Passing the *same* ByteBuffer all the way down from the application to the transport would be better.
> This requires changes in the way bundlers accumulate messages. Also, perhaps the transport itself should become an SPI, to which a generic {{Transport}} protocol delegates. This would also allow us to implement multiple transports (JGRP-1424) in the same stack.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
5 years, 7 months