[JBoss JIRA] (WFLY-13099) Standard configuration files for MicroProfile use cases
by Brian Stansberry (Jira)
[ https://issues.redhat.com/browse/WFLY-13099?page=com.atlassian.jira.plugi... ]
Brian Stansberry updated WFLY-13099:
------------------------------------
Security: (was: Red Hat Internal)
> Standard configuration files for MicroProfile use cases
> -------------------------------------------------------
>
> Key: WFLY-13099
> URL: https://issues.redhat.com/browse/WFLY-13099
> Project: WildFly
> Issue Type: Feature Request
> Components: Build System
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
> Priority: Major
> Fix For: 19.0.0.Beta3
>
>
> Provide standard configuration files 'standalone-microprofile.xml' and 'standalone-microprofile-ha.xml'. The HA variant will be equivalent to non-HA except that base features that have distributed variants (e.g. web session clustering and Hibernate second-level caching) will use the HA variants.
> Equivalent profiles in domain.xml are not required.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (WFLY-13137) Facilitate use of a distinct maven groupId for artifacts associated with org.wildfly:wildfly-galleon-pack
by Brian Stansberry (Jira)
Brian Stansberry created WFLY-13137:
---------------------------------------
Summary: Facilitate use of a distinct maven groupId for artifacts associated with org.wildfly:wildfly-galleon-pack
Key: WFLY-13137
URL: https://issues.redhat.com/browse/WFLY-13137
Project: WildFly
Issue Type: Enhancement
Components: Build System
Reporter: Brian Stansberry
Assignee: Brian Stansberry
Fix For: 19.0.0.Beta3
Use maven properties to make it fairly straightforward to swap in a different maven G for the microprofile FT, JWT and OpenAPI extension modules as well as the galleon-pack, build and dist modules.
This isn't particularly relevant to WF but will make it easier to convert WF tags to EAP branches.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (WFWIP-306) Health check response contains default readiness data
by Fabio Burzigotti (Jira)
[ https://issues.redhat.com/browse/WFWIP-306?page=com.atlassian.jira.plugin... ]
Fabio Burzigotti updated WFWIP-306:
-----------------------------------
Description:
Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
When no _readiness_ health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
The same _does not_ happen when there's just one registered readiness procedure - i.e. when no annotated _liveness_ procedures exist.
This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
The following example uses an Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
1. feature branch [1]
{code}
//health
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
},
{
"name": "ready-deployment.HealthTest.war",
"status": "UP"
}
]
}
//live
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
}
]
}
//ready
{
"status": "UP",
"checks": [
{
"name": "ready-deployment.HealthTest.war",
"status": "UP"
}
]
}
{code}
2. here are the results for the same calls against Wildfly 19 Beta 1:
{code}
//health
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
}
]
}
//live
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
}
]
}
//ready
{
"status": "UP",
"checks": []
}
{code}
[1]
https://github.com/jmesnil/wildfly
was:
Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
When no readiness health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
The following example uses an Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
1. feature branch [1]
{code}
//health
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
},
{
"name": "ready-deployment.HealthTest.war",
"status": "UP"
}
]
}
//live
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
}
]
}
//ready
{
"status": "UP",
"checks": [
{
"name": "ready-deployment.HealthTest.war",
"status": "UP"
}
]
}
{code}
2. here are the results for the same calls against Wildfly 19 Beta 1:
{code}
//health
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
}
]
}
//live
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
}
]
}
//ready
{
"status": "UP",
"checks": []
}
{code}
[1]
https://github.com/jmesnil/wildfly
> Health check response contains default readiness data
> -----------------------------------------------------
>
> Key: WFWIP-306
> URL: https://issues.redhat.com/browse/WFWIP-306
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP Health
> Reporter: Fabio Burzigotti
> Assignee: Jeff Mesnil
> Priority: Critical
>
> Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
> When no _readiness_ health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
> The same _does not_ happen when there's just one registered readiness procedure - i.e. when no annotated _liveness_ procedures exist.
> This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
> The following example uses an Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
> 1. feature branch [1]
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> },
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": [
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> {code}
> 2. here are the results for the same calls against Wildfly 19 Beta 1:
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": []
> }
> {code}
> [1]
> https://github.com/jmesnil/wildfly
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (WFWIP-306) Health check response contains default readiness data
by Fabio Burzigotti (Jira)
[ https://issues.redhat.com/browse/WFWIP-306?page=com.atlassian.jira.plugin... ]
Fabio Burzigotti updated WFWIP-306:
-----------------------------------
Description:
Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
When no readiness health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
The following example uses an Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
1. feature branch [1]
{code}
//health
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
},
{
"name": "ready-deployment.HealthTest.war",
"status": "UP"
}
]
}
//live
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
}
]
}
//ready
{
"status": "UP",
"checks": [
{
"name": "ready-deployment.HealthTest.war",
"status": "UP"
}
]
}
{code}
2. here are the results for the same calls against Wildfly 19 Beta 1:
{code}
//health
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
}
]
}
//live
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
}
]
}
//ready
{
"status": "UP",
"checks": []
}
{code}
[1]
https://github.com/jmesnil/wildfly
was:
Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
When no readiness health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
# Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
1. feature branch [1]
{code}
//health
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
},
{
"name": "ready-deployment.HealthTest.war",
"status": "UP"
}
]
}
//live
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
}
]
}
//ready
{
"status": "UP",
"checks": [
{
"name": "ready-deployment.HealthTest.war",
"status": "UP"
}
]
}
{code}
2. here are the results for the same calls against Wildfly 19 Beta 1:
{code}
//health
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
}
]
}
//live
{
"status": "UP",
"checks": [
{
"name": "live",
"status": "UP",
"data": {
"key": "value"
}
}
]
}
//ready
{
"status": "UP",
"checks": []
}
{code}
[1]
https://github.com/jmesnil/wildfly
> Health check response contains default readiness data
> -----------------------------------------------------
>
> Key: WFWIP-306
> URL: https://issues.redhat.com/browse/WFWIP-306
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP Health
> Reporter: Fabio Burzigotti
> Assignee: Jeff Mesnil
> Priority: Critical
>
> Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
> When no readiness health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
> This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
> The following example uses an Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
> 1. feature branch [1]
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> },
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": [
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> {code}
> 2. here are the results for the same calls against Wildfly 19 Beta 1:
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": []
> }
> {code}
> [1]
> https://github.com/jmesnil/wildfly
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (WFWIP-306) Health check response contains default readiness data
by Fabio Burzigotti (Jira)
[ https://issues.redhat.com/browse/WFWIP-306?page=com.atlassian.jira.plugin... ]
Fabio Burzigotti updated WFWIP-306:
-----------------------------------
Steps to Reproduce:
* download and extract Wildfly 19 Beta 1 binaries into something like ~/wfly-19-beta-1
...
* clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
{code}
$ git clone git@github.com:jmesnil/wildfly.git
$ cd wildfly
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
{code}
* clone the reproducer repository [2] and run the tests
{code}
$ git clone git@github.com:fabiobrz/health-22-repro.git
$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1 -Dtest=MissingReadinessHealthTest
# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22 -Dtest=MissingReadinessHealthTest
{code}
[1]
https://github.com/jmesnil/wildfly
[2]
https://github.com/fabiobrz/health-22-repro
was:
* download and extract Wildfly 19 Beta 1 binaries into something like ~/wfly-19-beta-1
...
* clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
{code}
$ git clone git@github.com:jmesnil/wildfly.git
$ cd wildfly
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
{code}
* clone the reproducer repository [2] and run the tests
{code}
$ git clone git@github.com:fabiobrz/health-22-repro.git
$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1
# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22
{code}
[1]
https://github.com/jmesnil/wildfly
[2]
https://github.com/fabiobrz/health-22-repro
> Health check response contains default readiness data
> -----------------------------------------------------
>
> Key: WFWIP-306
> URL: https://issues.redhat.com/browse/WFWIP-306
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP Health
> Reporter: Fabio Burzigotti
> Assignee: Jeff Mesnil
> Priority: Critical
>
> Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
> When no readiness health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
> This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
> # Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
> 1. feature branch [1]
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> },
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": [
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> {code}
> 2. here are the results for the same calls against Wildfly 19 Beta 1:
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": []
> }
> {code}
> [1]
> https://github.com/jmesnil/wildfly
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (WFWIP-306) Health check response contains default readiness data
by Fabio Burzigotti (Jira)
[ https://issues.redhat.com/browse/WFWIP-306?page=com.atlassian.jira.plugin... ]
Fabio Burzigotti updated WFWIP-306:
-----------------------------------
Steps to Reproduce:
* download and extract Wildfly 19 Beta 1 binaries into something like ~/wfly-19-beta-1
...
* clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
{code}
$ git clone git@github.com:jmesnil/wildfly.git
$ cd wildfly
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
{code}
* clone the reproducer repository [2] and run the tests
{code}
$ git clone git@github.com:fabiobrz/health-22-repro.git
$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1
# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22
{code}
[1]
https://github.com/jmesnil/wildfly
[2]
https://github.com/fabiobrz/health-22-repro
was:
* download and extract Wildfly 19 Beta 1 binaries into something like ~/wfly-19-beta-1
# clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
{code}
$ git clone git@github.com:jmesnil/wildfly.git
$ cd wildfly
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
{code}
* clone the reproducer repository [2] and run the tests
{code}
$ git clone git@github.com:fabiobrz/health-22-repro.git
$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1
# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22
{code}
[1]
https://github.com/jmesnil/wildfly
[2]
https://github.com/fabiobrz/health-22-repro
> Health check response contains default readiness data
> -----------------------------------------------------
>
> Key: WFWIP-306
> URL: https://issues.redhat.com/browse/WFWIP-306
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP Health
> Reporter: Fabio Burzigotti
> Assignee: Jeff Mesnil
> Priority: Critical
>
> Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
> When no readiness health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
> This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
> # Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
> 1. feature branch [1]
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> },
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": [
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> {code}
> 2. here are the results for the same calls against Wildfly 19 Beta 1:
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": []
> }
> {code}
> [1]
> https://github.com/jmesnil/wildfly
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (WFWIP-306) Health check response contains default readiness data
by Fabio Burzigotti (Jira)
[ https://issues.redhat.com/browse/WFWIP-306?page=com.atlassian.jira.plugin... ]
Fabio Burzigotti updated WFWIP-306:
-----------------------------------
Steps to Reproduce:
# download and extract Wildfly 19 Beta 1 binaries into something like ~/wfly-19-beta-1
# clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
{code}
$ git clone git@github.com:jmesnil/wildfly.git
$ cd wildfly
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
{code}
# clone the reproducer repository [2] and run the tests
{code}
$ git clone git@github.com:fabiobrz/health-22-repro.git
$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1
# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22
{code}
[1]
https://github.com/jmesnil/wildfly
[2]
https://github.com/fabiobrz/health-22-repro
was:
# download and extract Wildfly 19 Beta 1 binaries into ~/wfly-19-beta-1
# clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
{code}
$ git clone git@github.com:jmesnil/wildfly.git
$ cd wildfly
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
{code}
# clone the reproducer repository [2] and run the tests
{code}
$ git clone git@github.com:fabiobrz/health-22-repro.git
$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1
# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22
{code}
[1]
https://github.com/jmesnil/wildfly
[2]
https://github.com/fabiobrz/health-22-repro
> Health check response contains default readiness data
> -----------------------------------------------------
>
> Key: WFWIP-306
> URL: https://issues.redhat.com/browse/WFWIP-306
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP Health
> Reporter: Fabio Burzigotti
> Assignee: Jeff Mesnil
> Priority: Critical
>
> Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
> When no readiness health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
> This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
> # Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
> 1. feature branch [1]
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> },
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": [
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> {code}
> 2. here are the results for the same calls against Wildfly 19 Beta 1:
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": []
> }
> {code}
> [1]
> https://github.com/jmesnil/wildfly
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (WFWIP-306) Health check response contains default readiness data
by Fabio Burzigotti (Jira)
[ https://issues.redhat.com/browse/WFWIP-306?page=com.atlassian.jira.plugin... ]
Fabio Burzigotti updated WFWIP-306:
-----------------------------------
Steps to Reproduce:
* download and extract Wildfly 19 Beta 1 binaries into something like ~/wfly-19-beta-1
# clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
{code}
$ git clone git@github.com:jmesnil/wildfly.git
$ cd wildfly
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
{code}
* clone the reproducer repository [2] and run the tests
{code}
$ git clone git@github.com:fabiobrz/health-22-repro.git
$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1
# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22
{code}
[1]
https://github.com/jmesnil/wildfly
[2]
https://github.com/fabiobrz/health-22-repro
was:
# download and extract Wildfly 19 Beta 1 binaries into something like ~/wfly-19-beta-1
# clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
{code}
$ git clone git@github.com:jmesnil/wildfly.git
$ cd wildfly
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
{code}
# clone the reproducer repository [2] and run the tests
{code}
$ git clone git@github.com:fabiobrz/health-22-repro.git
$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1
# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22
{code}
[1]
https://github.com/jmesnil/wildfly
[2]
https://github.com/fabiobrz/health-22-repro
> Health check response contains default readiness data
> -----------------------------------------------------
>
> Key: WFWIP-306
> URL: https://issues.redhat.com/browse/WFWIP-306
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP Health
> Reporter: Fabio Burzigotti
> Assignee: Jeff Mesnil
> Priority: Critical
>
> Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
> When no readiness health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
> This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
> # Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
> 1. feature branch [1]
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> },
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": [
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> {code}
> 2. here are the results for the same calls against Wildfly 19 Beta 1:
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": []
> }
> {code}
> [1]
> https://github.com/jmesnil/wildfly
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (WFWIP-306) Health check response contains default readiness data
by Fabio Burzigotti (Jira)
[ https://issues.redhat.com/browse/WFWIP-306?page=com.atlassian.jira.plugin... ]
Fabio Burzigotti updated WFWIP-306:
-----------------------------------
Steps to Reproduce:
# download and extract Wildfly 19 Beta 1 binaries into ~/wfly-19-beta-1
# clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
{code}
$ git clone git@github.com:jmesnil/wildfly.git
$ cd wildfly
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
{code}
# clone the reproducer repository [2] and run the tests
{code}
$ git clone git@github.com:fabiobrz/health-22-repro.git
$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1
# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22
{code}
[1]
https://github.com/jmesnil/wildfly
[2]
https://github.com/fabiobrz/health-22-repro
was:
# download and extract Wildfly 19 Beta 1 binaries into ~/wfly-19-beta-1
# clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
{code}
$ git clone git@github.com:jmesnil/wildfly.git
$ cd wildfly
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
{code}
# clone the reproducer repository and ruun the tests
{code}
$ git clone git@github.com:fabiobrz/health-22-repro.git
$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1
# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22
{code}
[1]
https://github.com/jmesnil/wildfly
> Health check response contains default readiness data
> -----------------------------------------------------
>
> Key: WFWIP-306
> URL: https://issues.redhat.com/browse/WFWIP-306
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP Health
> Reporter: Fabio Burzigotti
> Assignee: Jeff Mesnil
> Priority: Critical
>
> Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
> When no readiness health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
> This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
> # Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
> 1. feature branch [1]
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> },
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": [
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> {code}
> 2. here are the results for the same calls against Wildfly 19 Beta 1:
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": []
> }
> {code}
> [1]
> https://github.com/jmesnil/wildfly
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months
[JBoss JIRA] (WFWIP-306) Health check response contains default readiness data
by Fabio Burzigotti (Jira)
[ https://issues.redhat.com/browse/WFWIP-306?page=com.atlassian.jira.plugin... ]
Fabio Burzigotti updated WFWIP-306:
-----------------------------------
Steps to Reproduce:
# download and extract Wildfly 19 Beta 1 binaries into ~/wfly-19-beta-1
# clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
{code}
$ git clone git@github.com:jmesnil/wildfly.git
$ cd wildfly
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
{code}
# clone the reproducer repository and ruun the tests
{code}
$ git clone git@github.com:fabiobrz/health-22-repro.git
$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1
# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22
{code}
[1]
https://github.com/jmesnil/wildfly
was:
# download and extract Wildfly 19 Beta 1 binaries into ~/wfly-19-beta-1
...
# clone and build from sources the current feature branch [1] into something like ~/wfly-health-22 (by copying there the "dist" directory resulting from the build)
...
$ git clone git@github.com:jmesnil/wildfly.git
$ cd wildfly
$ git checkout WFLY-13048_upgrade_microprofile-health_2.2
$ mvn clean install
...
$ mv dist/target/wildfly-20.0.0.Beta1-SNAPSHOT ~/wfly-health-22
# clone the reproducer repository
$ git clone git@github.com:fabiobrz/health-22-repro.git
$ cd health-22-repro
# run the tests against WF 19 Beta 1: everything should be ok
$ mvn clean test -Djboss.home=~/wfly-19-beta-1
# run the tests against WF feature branch: 2 tests should fail
$ mvn clean test -Djboss.home=~/wfly-health-22
[1]
https://github.com/jmesnil/wildfly/commits/WFLY-13048_upgrade_microprofil...
> Health check response contains default readiness data
> -----------------------------------------------------
>
> Key: WFWIP-306
> URL: https://issues.redhat.com/browse/WFWIP-306
> Project: WildFly WIP
> Issue Type: Bug
> Components: MP Health
> Reporter: Fabio Burzigotti
> Assignee: Jeff Mesnil
> Priority: Critical
>
> Starting from Wildfly 19 Beta 2 and with current feature branch for MP Health upgrade to 2.2 [1], some tests started to fail, reporting unexpected content in JSON response.
> When no readiness health check procedures are defined for a given deployment - the returned JSON payload contains a "default" health check readiness object, conventionally named as "ready-deployment." + <archive-name>
> This change is not documented in the Analysis document: https://github.com/wildfly/wildfly-proposals/pull/284
> # Arquillian deployment with a single HealthCheck implementation with _liveness_ health check procedure.
> 1. feature branch [1]
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> },
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": [
> {
> "name": "ready-deployment.HealthTest.war",
> "status": "UP"
> }
> ]
> }
> {code}
> 2. here are the results for the same calls against Wildfly 19 Beta 1:
> {code}
> //health
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //live
> {
> "status": "UP",
> "checks": [
> {
> "name": "live",
> "status": "UP",
> "data": {
> "key": "value"
> }
> }
> ]
> }
> //ready
> {
> "status": "UP",
> "checks": []
> }
> {code}
> [1]
> https://github.com/jmesnil/wildfly
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years, 2 months