[jboss-jira] [JBoss JIRA] Commented: (JBAS-5906) Client user transaction lookups aren't closing initial contexts

Client user transaction lookups aren't closing initial contexts --------------------------------------------------------------- Key: JBAS-5906 URL: https://jira.jboss.org/jira/browse/JBAS-5906 Project: JBoss Application Server Issue Type: Bug Security Level: Public(Everyone can see) Components: Transaction Manager (JBossTM) Affects Versions: JBossAS-5.0.0.CR1, JBossAS-4.2.3.GA Reporter: Adrian Brock Assignee: Galder Zamarreno Fix For: JBossAS-5.0.0.CR2, JBossAS-4.2.4.GA There are a number of places in the UserTransaction initialisation and TxPropogationContextUtil that are doing jndi lookups() without closing the initial context. Typically new InitialContext().lookup(...); This is inefficient since on the client side this will mean an rmi connection is open until it gets garbage collected. This has already been fixed in JBoss5 for the TxPropogationContextUtil (correct code should look like this) try { InitialContext ctx = new InitialContext(); try { tpcFactory = (TransactionPropagationContextFactory) ctx.lookup(EXPORTER_JNDI_NAME); } finally { ctx.close(); } } catch (NamingException e) { throw new RuntimeException("Unable to lookup " + EXPORTER_JNDI_NAME, e); }