[JBoss JIRA] Created: (GPD-143) Load the icon of a paletteContribution entry from the plugin directory where it is defined
5:54 p.m.
Load the icon of a paletteContribution entry from the plugin directory where it is
defined
------------------------------------------------------------------------------------------
Key: GPD-143
URL: http://jira.jboss.com/jira/browse/GPD-143
Project: JBoss jBPM GPD
Issue Type: Feature Request
Reporter: Matthias Hanisch
Assigned To: Koen Aers
In PaletteRoot class, the icon of a palette entry is always loaded from org.jbpm.gd.jpdl
plugin, even if the paletteContribution entry is defined in a dependent plugin.
The information, where the palette entry element (entryElement in PaletteRoot.addControls)
is defined, can be found in entryElement.getContributor().getName().
So also the corresponding image can be loaded from the correct bundle.
[ Sorry to only give a verbal description of the implementation. I would sign a corporate
contributor's agreement, but I have problems with the procedure, e.g.
- do we need a corporate jboss account for my boss to sign
- if we sign with the "corporate" account, with which account I need to
contribute then
etc.
So I would need some assistance here. Then you would get a real diff also.
]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:23 p.m.
New subject: [JBoss JIRA] Updated: (GPD-143) Load the icon of a paletteContribution entry from the plugin directory where it is defined
[ http://jira.jboss.com/jira/browse/GPD-143?page=all ]
Koen Aers updated GPD-143:
--------------------------
Component/s: jpdl
Load the icon of a paletteContribution entry from the plugin
directory where it is defined
------------------------------------------------------------------------------------------
Key: GPD-143
URL: http://jira.jboss.com/jira/browse/GPD-143
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Reporter: Matthias Hanisch
Assigned To: Koen Aers
In PaletteRoot class, the icon of a palette entry is always loaded from org.jbpm.gd.jpdl
plugin, even if the paletteContribution entry is defined in a dependent plugin.
The information, where the palette entry element (entryElement in
PaletteRoot.addControls) is defined, can be found in
entryElement.getContributor().getName().
So also the corresponding image can be loaded from the correct bundle.
[ Sorry to only give a verbal description of the implementation. I would sign a corporate
contributor's agreement, but I have problems with the procedure, e.g.
- do we need a corporate jboss account for my boss to sign
- if we sign with the "corporate" account, with which account I need to
contribute then
etc.
So I would need some assistance here. Then you would get a real diff also.
]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:01 p.m.
New subject: [JBoss JIRA] Updated: (GPD-143) Load the icon of a paletteContribution entry from the plugin directory where it is defined
[ http://jira.jboss.com/jira/browse/GPD-143?page=all ]
Koen Aers updated GPD-143:
--------------------------
Fix Version/s: jBPM jPDL Designer 3.2.0.alpha1
Load the icon of a paletteContribution entry from the plugin
directory where it is defined
------------------------------------------------------------------------------------------
Key: GPD-143
URL: http://jira.jboss.com/jira/browse/GPD-143
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Reporter: Matthias Hanisch
Assigned To: Koen Aers
Fix For: jBPM jPDL Designer 3.2.0.alpha1
In PaletteRoot class, the icon of a palette entry is always loaded from org.jbpm.gd.jpdl
plugin, even if the paletteContribution entry is defined in a dependent plugin.
The information, where the palette entry element (entryElement in
PaletteRoot.addControls) is defined, can be found in
entryElement.getContributor().getName().
So also the corresponding image can be loaded from the correct bundle.
[ Sorry to only give a verbal description of the implementation. I would sign a corporate
contributor's agreement, but I have problems with the procedure, e.g.
- do we need a corporate jboss account for my boss to sign
- if we sign with the "corporate" account, with which account I need to
contribute then
etc.
So I would need some assistance here. Then you would get a real diff also.
]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:30 p.m.
New subject: [JBoss JIRA] Updated: (GPD-143) Load the icon of a paletteContribution entry from the plugin directory where it is defined
[ http://jira.jboss.com/jira/browse/GPD-143?page=all ]
Matthew Sandoz updated GPD-143:
-------------------------------
Attachment: PaletteRoot.java
I just ended up needing to do this as well - if you havent already fixed it this seems to
work. I am also attaching this file to the issue
### Eclipse Workspace Patch 1.0
#P org.jbpm.gd.jpdl
Index: src/org/jbpm/gd/common/editor/PaletteRoot.java
===================================================================
RCS file:
/cvsroot/jbpm/jbpm.3/designer/jpdl/org.jbpm.gd.jpdl/src/org/jbpm/gd/common/editor/PaletteRoot.java,v
retrieving revision 1.2
diff -u -r1.2 PaletteRoot.java
--- src/org/jbpm/gd/common/editor/PaletteRoot.java 7 Aug 2007 11:38:49 -0000 1.2
+++ src/org/jbpm/gd/common/editor/PaletteRoot.java 16 Oct 2007 19:25:06 -0000
@@ -21,6 +21,7 @@
*/
package org.jbpm.gd.common.editor;
+import java.net.URL;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
@@ -37,6 +38,7 @@
import org.eclipse.gef.palette.ToolEntry;
import org.eclipse.jface.resource.ImageDescriptor;
import org.jbpm.gd.jpdl.Plugin;
+import org.osgi.framework.Bundle;
public class PaletteRoot extends org.eclipse.gef.palette.PaletteRoot {
@@ -78,9 +80,9 @@
PaletteEntry entry;
CreationFactory factory = new CreationFactory(object,
editor.getSemanticElementFactory(), editor.getNotationElementFactory());
if (isNode) {
- entry = new CreationToolEntry(label, tooltip, factory, getIconDescriptor(icon),
null);
+ entry = new CreationToolEntry(label, tooltip, factory,
getIconDescriptor(entryElement), null);
} else {
- entry = new ConnectionCreationToolEntry(label, tooltip, factory,
getIconDescriptor(icon), null);
+ entry = new ConnectionCreationToolEntry(label, tooltip, factory,
getIconDescriptor(entryElement), null);
}
entry.setId(entryName);
paletteGroup.add(entry);
@@ -90,8 +92,10 @@
}
}
- private ImageDescriptor getIconDescriptor(String icon) {
- return
ImageDescriptor.createFromURL(Plugin.getDefault().getBundle().getEntry("/" +
icon));
+ private ImageDescriptor getIconDescriptor(IConfigurationElement element) {
+ Bundle bundle = Platform.getBundle(element.getDeclaringExtension().getNamespace());
+ URL location = bundle.getEntry("/" +
element.getAttribute("icon"));
+ return ImageDescriptor.createFromURL(location);
}
private void processPaletteContribution(IConfigurationElement configurationElement) {
Load the icon of a paletteContribution entry from the plugin
directory where it is defined
------------------------------------------------------------------------------------------
Key: GPD-143
URL: http://jira.jboss.com/jira/browse/GPD-143
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Reporter: Matthias Hanisch
Assigned To: Koen Aers
Fix For: jBPM jPDL Designer 3.2.0.alpha1
Attachments: PaletteRoot.java
In PaletteRoot class, the icon of a palette entry is always loaded from org.jbpm.gd.jpdl
plugin, even if the paletteContribution entry is defined in a dependent plugin.
The information, where the palette entry element (entryElement in
PaletteRoot.addControls) is defined, can be found in
entryElement.getContributor().getName().
So also the corresponding image can be loaded from the correct bundle.
[ Sorry to only give a verbal description of the implementation. I would sign a corporate
contributor's agreement, but I have problems with the procedure, e.g.
- do we need a corporate jboss account for my boss to sign
- if we sign with the "corporate" account, with which account I need to
contribute then
etc.
So I would need some assistance here. Then you would get a real diff also.
]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:38 p.m.
New subject: [JBoss JIRA] Commented: (GPD-143) Load the icon of a paletteContribution entry from the plugin directory where it is defined
[ http://jira.jboss.com/jira/browse/GPD-143?page=comments#action_12388922 ]
Matthias Hanisch commented on GPD-143:
--------------------------------------
Just want to add that my local fix is very similar to Matthew's. I just computed the
URL in the caller, but I would prefer Matthew's version.
Load the icon of a paletteContribution entry from the plugin
directory where it is defined
------------------------------------------------------------------------------------------
Key: GPD-143
URL: http://jira.jboss.com/jira/browse/GPD-143
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Reporter: Matthias Hanisch
Assigned To: Koen Aers
Fix For: jBPM jPDL Designer 3.2.0.alpha1
Attachments: PaletteRoot.java
In PaletteRoot class, the icon of a palette entry is always loaded from org.jbpm.gd.jpdl
plugin, even if the paletteContribution entry is defined in a dependent plugin.
The information, where the palette entry element (entryElement in
PaletteRoot.addControls) is defined, can be found in
entryElement.getContributor().getName().
So also the corresponding image can be loaded from the correct bundle.
[ Sorry to only give a verbal description of the implementation. I would sign a corporate
contributor's agreement, but I have problems with the procedure, e.g.
- do we need a corporate jboss account for my boss to sign
- if we sign with the "corporate" account, with which account I need to
contribute then
etc.
So I would need some assistance here. Then you would get a real diff also.
]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:08 p.m.
New subject: [JBoss JIRA] Closed: (GPD-143) Load the icon of a paletteContribution entry from the plugin directory where it is defined
[ http://jira.jboss.com/jira/browse/GPD-143?page=all ]
Koen Aers closed GPD-143.
-------------------------
Fix Version/s: jBPM jPDL Designer 3.1.2
Resolution: Done
Thanks Matthew and Matthias!
Load the icon of a paletteContribution entry from the plugin
directory where it is defined
------------------------------------------------------------------------------------------
Key: GPD-143
URL: http://jira.jboss.com/jira/browse/GPD-143
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Reporter: Matthias Hanisch
Assigned To: Koen Aers
Fix For: jBPM jPDL Designer 3.2.0.alpha1, jBPM jPDL Designer 3.1.2
Attachments: PaletteRoot.java
In PaletteRoot class, the icon of a palette entry is always loaded from org.jbpm.gd.jpdl
plugin, even if the paletteContribution entry is defined in a dependent plugin.
The information, where the palette entry element (entryElement in
PaletteRoot.addControls) is defined, can be found in
entryElement.getContributor().getName().
So also the corresponding image can be loaded from the correct bundle.
[ Sorry to only give a verbal description of the implementation. I would sign a corporate
contributor's agreement, but I have problems with the procedure, e.g.
- do we need a corporate jboss account for my boss to sign
- if we sign with the "corporate" account, with which account I need to
contribute then
etc.
So I would need some assistance here. Then you would get a real diff also.
]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:44 p.m.
New subject: [JBoss JIRA] Reopened: (GPD-143) Load the icon of a paletteContribution entry from the plugin directory where it is defined
[
https://jira.jboss.org/jira/browse/GPD-143?page=com.atlassian.jira.plugin...
]
Koen Aers reopened GPD-143:
---------------------------
Load the icon of a paletteContribution entry from the plugin
directory where it is defined
------------------------------------------------------------------------------------------
Key: GPD-143
URL: https://jira.jboss.org/jira/browse/GPD-143
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Reporter: Matthias Hanisch
Assignee: Koen Aers
Fix For: jBPM jPDL Designer 3.1.2
Attachments: PaletteRoot.java
In PaletteRoot class, the icon of a palette entry is always loaded from org.jbpm.gd.jpdl
plugin, even if the paletteContribution entry is defined in a dependent plugin.
The information, where the palette entry element (entryElement in
PaletteRoot.addControls) is defined, can be found in
entryElement.getContributor().getName().
So also the corresponding image can be loaded from the correct bundle.
[ Sorry to only give a verbal description of the implementation. I would sign a corporate
contributor's agreement, but I have problems with the procedure, e.g.
- do we need a corporate jboss account for my boss to sign
- if we sign with the "corporate" account, with which account I need to
contribute then
etc.
So I would need some assistance here. Then you would get a real diff also.
]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:44 p.m.
New subject: [JBoss JIRA] Resolved: (GPD-143) Load the icon of a paletteContribution entry from the plugin directory where it is defined
[
https://jira.jboss.org/jira/browse/GPD-143?page=com.atlassian.jira.plugin...
]
Koen Aers resolved GPD-143.
---------------------------
Resolution: Done
Load the icon of a paletteContribution entry from the plugin
directory where it is defined
------------------------------------------------------------------------------------------
Key: GPD-143
URL: https://jira.jboss.org/jira/browse/GPD-143
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Reporter: Matthias Hanisch
Assignee: Koen Aers
Attachments: PaletteRoot.java
In PaletteRoot class, the icon of a palette entry is always loaded from org.jbpm.gd.jpdl
plugin, even if the paletteContribution entry is defined in a dependent plugin.
The information, where the palette entry element (entryElement in
PaletteRoot.addControls) is defined, can be found in
entryElement.getContributor().getName().
So also the corresponding image can be loaded from the correct bundle.
[ Sorry to only give a verbal description of the implementation. I would sign a corporate
contributor's agreement, but I have problems with the procedure, e.g.
- do we need a corporate jboss account for my boss to sign
- if we sign with the "corporate" account, with which account I need to
contribute then
etc.
So I would need some assistance here. Then you would get a real diff also.
]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:44 p.m.
New subject: [JBoss JIRA] Updated: (GPD-143) Load the icon of a paletteContribution entry from the plugin directory where it is defined
[
https://jira.jboss.org/jira/browse/GPD-143?page=com.atlassian.jira.plugin...
]
Koen Aers updated GPD-143:
--------------------------
Fix Version/s: (was: jBPM jPDL Designer 3.2.0.alpha1)
Load the icon of a paletteContribution entry from the plugin
directory where it is defined
------------------------------------------------------------------------------------------
Key: GPD-143
URL: https://jira.jboss.org/jira/browse/GPD-143
Project: JBoss jBPM GPD
Issue Type: Feature Request
Components: jpdl
Reporter: Matthias Hanisch
Assignee: Koen Aers
Fix For: jBPM jPDL Designer 3.1.2
Attachments: PaletteRoot.java
In PaletteRoot class, the icon of a palette entry is always loaded from org.jbpm.gd.jpdl
plugin, even if the paletteContribution entry is defined in a dependent plugin.
The information, where the palette entry element (entryElement in
PaletteRoot.addControls) is defined, can be found in
entryElement.getContributor().getName().
So also the corresponding image can be loaded from the correct bundle.
[ Sorry to only give a verbal description of the implementation. I would sign a corporate
contributor's agreement, but I have problems with the procedure, e.g.
- do we need a corporate jboss account for my boss to sign
- if we sign with the "corporate" account, with which account I need to
contribute then
etc.
So I would need some assistance here. Then you would get a real diff also.
]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5649
days inactive
6166
days old
8 comments
3 participants
participants (3)
-
Koen Aers (JIRA) -
Matthew Sandoz (JIRA)
-
Matthias Hanisch (JIRA)