[JBoss JIRA] Created: (JBREM-690) Once the socket of a callback server timeouts, it starts to silently discard traffic
11:08 p.m.
Once the socket of a callback server timeouts, it starts to silently discard traffic
------------------------------------------------------------------------------------
Key: JBREM-690
URL: http://jira.jboss.com/jira/browse/JBREM-690
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: callbacks
Affects Versions: 2.2.0.Alpha6
Reporter: Ovidiu Feodorov
Assigned To: Tom Elrod
Priority: Blocker
Fix For: 2.2.0.Alpha7
Please write the following test (and I actually mean it, please do, and keep it your test
suite):
Create a "socket" transport client and register a listener to it, so the push
callback server is initialized.
Send a callback to the client, to make sure a socket is created and traffic is sent over
it.
Wait enough for the callback socket to timeout (a little bit longer than
ServerInvoker.DEFAULT_TIMEOUT_PERIOD).
Send a new callback to the client.
The callback will be silently discarded, never to be heard of again.
For the Messaging version of this bug, please see
http://jira.jboss.org/jira/browse/JBMESSAGING-371 and the associated RemotingTest.test
testMessageListenerTimeout()
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:30 p.m.
New subject: [JBoss JIRA] Commented: (JBREM-690) Once the socket of a callback server timeouts, it starts to silently discard traffic
[ http://jira.jboss.com/jira/browse/JBREM-690?page=comments#action_12351600 ]
Ovidiu Feodorov commented on JBREM-690:
---------------------------------------
One more detail: the callbacks are oneway
Once the socket of a callback server timeouts, it starts to silently
discard traffic
------------------------------------------------------------------------------------
Key: JBREM-690
URL: http://jira.jboss.com/jira/browse/JBREM-690
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: callbacks
Affects Versions: 2.2.0.Alpha6
Reporter: Ovidiu Feodorov
Assigned To: Tom Elrod
Priority: Blocker
Fix For: 2.2.0.Alpha7
Please write the following test (and I actually mean it, please do, and keep it your test
suite):
Create a "socket" transport client and register a listener to it, so the push
callback server is initialized.
Send a callback to the client, to make sure a socket is created and traffic is sent over
it.
Wait enough for the callback socket to timeout (a little bit longer than
ServerInvoker.DEFAULT_TIMEOUT_PERIOD).
Send a new callback to the client.
The callback will be silently discarded, never to be heard of again.
For the Messaging version of this bug, please see
http://jira.jboss.org/jira/browse/JBMESSAGING-371 and the associated RemotingTest.test
testMessageListenerTimeout()
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:01 a.m.
New subject: [JBoss JIRA] Commented: (JBREM-690) Once the socket of a callback server timeouts, it starts to silently discard traffic
[ http://jira.jboss.com/jira/browse/JBREM-690?page=comments#action_12351601 ]
Ovidiu Feodorov commented on JBREM-690:
---------------------------------------
src/tests/org/jboss/test/remoting/transport/socket/timeout/CallbackTimeoutTestCase.java
Once the socket of a callback server timeouts, it starts to silently
discard traffic
------------------------------------------------------------------------------------
Key: JBREM-690
URL: http://jira.jboss.com/jira/browse/JBREM-690
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: callbacks
Affects Versions: 2.2.0.Alpha6
Reporter: Ovidiu Feodorov
Assigned To: Tom Elrod
Priority: Blocker
Fix For: 2.2.0.Alpha7
Please write the following test (and I actually mean it, please do, and keep it your test
suite):
Create a "socket" transport client and register a listener to it, so the push
callback server is initialized.
Send a callback to the client, to make sure a socket is created and traffic is sent over
it.
Wait enough for the callback socket to timeout (a little bit longer than
ServerInvoker.DEFAULT_TIMEOUT_PERIOD).
Send a new callback to the client.
The callback will be silently discarded, never to be heard of again.
For the Messaging version of this bug, please see
http://jira.jboss.org/jira/browse/JBMESSAGING-371 and the associated RemotingTest.test
testMessageListenerTimeout()
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:04 a.m.
New subject: [JBoss JIRA] Commented: (JBREM-690) Once the socket of a callback server timeouts, it starts to silently discard traffic
[ http://jira.jboss.com/jira/browse/JBREM-690?page=comments#action_12351615 ]
Ovidiu Feodorov commented on JBREM-690:
---------------------------------------
Ron, I tried, I really did, to write a test for this with jrunit, but for some reason I
find it very difficult to wield.
I wrote one that only uses remoting (no Messaging overhead) in our testsuite, and this one
fails too: org.jboss.test.thirdparty.remoting.CallbackServerTimeoutTest.testTimeout()
Once the socket of a callback server timeouts, it starts to silently
discard traffic
------------------------------------------------------------------------------------
Key: JBREM-690
URL: http://jira.jboss.com/jira/browse/JBREM-690
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: callbacks
Affects Versions: 2.2.0.Alpha6
Reporter: Ovidiu Feodorov
Assigned To: Tom Elrod
Priority: Blocker
Fix For: 2.2.0.Alpha7
Please write the following test (and I actually mean it, please do, and keep it your test
suite):
Create a "socket" transport client and register a listener to it, so the push
callback server is initialized.
Send a callback to the client, to make sure a socket is created and traffic is sent over
it.
Wait enough for the callback socket to timeout (a little bit longer than
ServerInvoker.DEFAULT_TIMEOUT_PERIOD).
Send a new callback to the client.
The callback will be silently discarded, never to be heard of again.
For the Messaging version of this bug, please see
http://jira.jboss.org/jira/browse/JBMESSAGING-371 and the associated RemotingTest.test
testMessageListenerTimeout()
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:19 p.m.
New subject: [JBoss JIRA] Assigned: (JBREM-690) Once the socket of a callback server timeouts, it starts to silently discard traffic
[ http://jira.jboss.com/jira/browse/JBREM-690?page=all ]
Ron Sigal reassigned JBREM-690:
-------------------------------
Assignee: Ron Sigal (was: Tom Elrod)
Once the socket of a callback server timeouts, it starts to silently
discard traffic
------------------------------------------------------------------------------------
Key: JBREM-690
URL: http://jira.jboss.com/jira/browse/JBREM-690
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: callbacks
Affects Versions: 2.2.0.Alpha6
Reporter: Ovidiu Feodorov
Assigned To: Ron Sigal
Priority: Blocker
Fix For: 2.2.0.Alpha7
Please write the following test (and I actually mean it, please do, and keep it your test
suite):
Create a "socket" transport client and register a listener to it, so the push
callback server is initialized.
Send a callback to the client, to make sure a socket is created and traffic is sent over
it.
Wait enough for the callback socket to timeout (a little bit longer than
ServerInvoker.DEFAULT_TIMEOUT_PERIOD).
Send a new callback to the client.
The callback will be silently discarded, never to be heard of again.
For the Messaging version of this bug, please see
http://jira.jboss.org/jira/browse/JBMESSAGING-371 and the associated RemotingTest.test
testMessageListenerTimeout()
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:09 p.m.
New subject: [JBoss JIRA] Commented: (JBREM-690) Once the socket of a callback server timeouts, it starts to silently discard traffic
[ http://jira.jboss.com/jira/browse/JBREM-690?page=comments#action_12351965 ]
Ron Sigal commented on JBREM-690:
---------------------------------
It seems that when one end of a TCP connection shuts down, it doesn't automatically
inform the other side unless there's an ACK or NAK going out anyway. In particular, I
think that it's possible for the first socket write() to succeed after the other end
disconnects.
Example:
public class SocketTest
{
public static void main(String[] args)
{
new Thread()
{
public void run()
{
try
{
ServerSocket ss = new ServerSocket(2345);
Socket s = ss.accept();
InputStream is = s.getInputStream();
System.out.println("read: " + is.read());
s.close();
ss.close();
}
catch (IOException e)
{
System.out.println("server: " + e);
}
}
}.start();
try
{
Socket s = new Socket("localhost", 2345);
OutputStream os = s.getOutputStream();
os.write(3);
System.out.println("wrote 3");
os.write(5);
System.out.println("wrote 5");
os.write(7);
System.out.println("wrote 7");
s.close();
}
catch (IOException e)
{
System.out.println("client: " + e);
}
}
}
You might expect os.write(5) to fail, but, in fact, the output (at least in Windows and I
think this would be the case in linux as well) is:
wrote 3
read: 3
wrote 5
client: java.net.SocketException: Software caused connection abort: socket write
error
There's no problem for an ordinary invocation because the client waits for a response.
For an asynchronous invocation, however, the client may never know that an invocation
failed.
One workaround is to use the connection checking facility of the socket transport, which
does preliminary i/o on a socket to determine if the connection is still working.
Alternatively, the application can verify that an intended invocation has succeeded.
Once the socket of a callback server timeouts, it starts to silently
discard traffic
------------------------------------------------------------------------------------
Key: JBREM-690
URL: http://jira.jboss.com/jira/browse/JBREM-690
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: callbacks
Affects Versions: 2.2.0.Alpha6
Reporter: Ovidiu Feodorov
Assigned To: Ron Sigal
Priority: Blocker
Fix For: 2.2.0.Alpha7
Please write the following test (and I actually mean it, please do, and keep it your test
suite):
Create a "socket" transport client and register a listener to it, so the push
callback server is initialized.
Send a callback to the client, to make sure a socket is created and traffic is sent over
it.
Wait enough for the callback socket to timeout (a little bit longer than
ServerInvoker.DEFAULT_TIMEOUT_PERIOD).
Send a new callback to the client.
The callback will be silently discarded, never to be heard of again.
For the Messaging version of this bug, please see
http://jira.jboss.org/jira/browse/JBMESSAGING-371 and the associated RemotingTest.test
testMessageListenerTimeout()
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:37 p.m.
New subject: [JBoss JIRA] Commented: (JBREM-690) Once the socket of a callback server timeouts, it starts to silently discard traffic
[ http://jira.jboss.com/jira/browse/JBREM-690?page=comments#action_12352252 ]
Ron Sigal commented on JBREM-690:
---------------------------------
All communication in Remoting is initiated by the client (in the functional sense - it
could be a callback client). The server never sends bytes except in response to the
client. Based on that fact, I've been playing with a "lite" connection
checking idea. When the ServerSocketWrapper closes, it writes a CLOSING byte just before
it closes. ClientSocketWrapper gets a new checkOpenConnection() method which looks for
getInputStream.available() > 0, which would only be true if the ServerSocketWrapper
wrote a CLOSING byte. SocketClientInvoker.getPooledConnection() uses this method to test
if a pooled socket's remote endpoint has closed, and, if so, discards it. So this
isn't a full-fledged, expensive connection check, but it works to avoid reusing a
socket when the server's socket has timed out.
More particularly, the following changes have been made:
1. There's a new interface org.jboss.remoting.transport.socket.OpenConnectionChecker,
with the method checkOpenConnection(). ClientSocketWrapper now implements
OpenConnectionChecker, and ClientSocketWrapper.checkOpenConnection() throws an IOException
if it finds a byte available on the input stream.
2. ServerSocketWrapper overrides SocketWrapper.close() and writes a CLOSING byte when it
is called.
3. MicroSocketClientInvoker.getPooledConnection() and
SocketClientInvoker.getPooledConnection() check if a socket wrapper implements
OpenConnectionChecker, and if it does, calls checkOpenConnection. They do this
automatically, whether or not connection checking is turned on. If checkOpenConnection()
throws an exception, the socket wrapper is discarded.
4 The code to close the socket's input and output streams (which is probably not
necessary but couldn't hurt) has been moved from ServerThread to
SocketWrapper.close(). This has been done so that the output stream is still open for
ServerSocketWrapper.close() to write its CLOSING byte.
Once the socket of a callback server timeouts, it starts to silently
discard traffic
------------------------------------------------------------------------------------
Key: JBREM-690
URL: http://jira.jboss.com/jira/browse/JBREM-690
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: callbacks
Affects Versions: 2.2.0.Alpha6
Reporter: Ovidiu Feodorov
Assigned To: Ron Sigal
Priority: Blocker
Fix For: 2.2.0.Alpha7
Please write the following test (and I actually mean it, please do, and keep it your test
suite):
Create a "socket" transport client and register a listener to it, so the push
callback server is initialized.
Send a callback to the client, to make sure a socket is created and traffic is sent over
it.
Wait enough for the callback socket to timeout (a little bit longer than
ServerInvoker.DEFAULT_TIMEOUT_PERIOD).
Send a new callback to the client.
The callback will be silently discarded, never to be heard of again.
For the Messaging version of this bug, please see
http://jira.jboss.org/jira/browse/JBMESSAGING-371 and the associated RemotingTest.test
testMessageListenerTimeout()
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:51 a.m.
New subject: [JBoss JIRA] Updated: (JBREM-690) Once the socket of a callback server timeouts, it starts to silently discard traffic
[ http://jira.jboss.com/jira/browse/JBREM-690?page=all ]
Ron Sigal updated JBREM-690:
----------------------------
Fix Version/s: 2.2.0.Beta1 (Bluto)
(was: 2.2.0.Alpha7)
Affects Version/s: 2.2.0.Beta1 (Bluto)
(was: 2.2.0.Alpha6)
Once the socket of a callback server timeouts, it starts to silently
discard traffic
------------------------------------------------------------------------------------
Key: JBREM-690
URL: http://jira.jboss.com/jira/browse/JBREM-690
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: callbacks
Affects Versions: 2.2.0.Beta1 (Bluto)
Reporter: Ovidiu Feodorov
Assigned To: Ron Sigal
Priority: Blocker
Fix For: 2.2.0.Beta1 (Bluto)
Please write the following test (and I actually mean it, please do, and keep it your test
suite):
Create a "socket" transport client and register a listener to it, so the push
callback server is initialized.
Send a callback to the client, to make sure a socket is created and traffic is sent over
it.
Wait enough for the callback socket to timeout (a little bit longer than
ServerInvoker.DEFAULT_TIMEOUT_PERIOD).
Send a new callback to the client.
The callback will be silently discarded, never to be heard of again.
For the Messaging version of this bug, please see
http://jira.jboss.org/jira/browse/JBMESSAGING-371 and the associated RemotingTest.test
testMessageListenerTimeout()
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:57 a.m.
New subject: [JBoss JIRA] Closed: (JBREM-690) Once the socket of a callback server timeouts, it starts to silently discard traffic
[ http://jira.jboss.com/jira/browse/JBREM-690?page=all ]
Ovidiu Feodorov closed JBREM-690.
---------------------------------
Resolution: Done
org.jboss.test.thirdparty.remoting.RemotingTest.testMessageListenerTimeout() passes with
bisocket.
Once the socket of a callback server timeouts, it starts to silently
discard traffic
------------------------------------------------------------------------------------
Key: JBREM-690
URL: http://jira.jboss.com/jira/browse/JBREM-690
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: callbacks
Affects Versions: 2.2.0.Beta1 (Bluto)
Reporter: Ovidiu Feodorov
Assigned To: Ron Sigal
Priority: Blocker
Fix For: 2.2.0.Beta1 (Bluto)
Please write the following test (and I actually mean it, please do, and keep it your test
suite):
Create a "socket" transport client and register a listener to it, so the push
callback server is initialized.
Send a callback to the client, to make sure a socket is created and traffic is sent over
it.
Wait enough for the callback socket to timeout (a little bit longer than
ServerInvoker.DEFAULT_TIMEOUT_PERIOD).
Send a new callback to the client.
The callback will be silently discarded, never to be heard of again.
For the Messaging version of this bug, please see
http://jira.jboss.org/jira/browse/JBMESSAGING-371 and the associated RemotingTest.test
testMessageListenerTimeout()
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7031
days inactive
7053
days old
8 comments
4 participants
participants (4)
-
Ovidiu Feodorov (JIRA) -
Ovidiu Feodorov (JIRA) -
Ron Sigal (JIRA)
-
Ron Sigal (JIRA)