[ https://issues.jboss.org/browse/AS7-4917?page=com.atlassian.jira.plugin.s... ] Jeff Mesnil commented on AS7-4917: ---------------------------------- IRC log about this issue: [16:49:36] <jmesnil> kkhan, before leaving, brian asked me to look at AS7-4917 [16:49:37] <jbossbot> jira [AS7-4917] paths need to allow expressions in its 'path' attribute [Open (Unresolved) Feature Request, Major, Jeff Mesnil] https://issues.jboss.org/browse/AS7-4917 [16:50:32] <jmesnil> kkhan, afaict, the fix is easy, just allow expressions for the path attribute and I check it works both in standalone and domain mode [16:51:22] <jmesnil> kkhan, but brian told me that there were things to discuss about this. Am I missing something about allowing expression for the paths? [16:51:27] * kkhan looks [16:52:04] <emuckenhuber> perhaps about the implications for backwards compatibility [16:52:42] <jmesnil> emuckenhuber, yeah, we'd need to bump up the management version if we allow expressions for paths [16:53:16] <jmesnil> emuckenhuber, but if it was not allowed before, I don't see how we could break existings paths by allowing it now [16:53:35] <ctomc> jmesnil: maybe it is also how attributes are beeing read, you need to use resolveModelAttribute(context,model)... [16:53:46] <kkhan> ctomc/emuckenhuber: How do expressions work with transformers [16:53:53] <emuckenhuber> kkhan: that is the main problem :) [16:53:55] <kkhan> e.g. DC's version allows expressions [16:54:05] <emuckenhuber> basically they can't be resolved properly [16:54:06] <kkhan> and then the legacy HC does not [16:54:23] <emuckenhuber> i mean we can resolve them against domain properties [16:54:30] <emuckenhuber> however not against host / server properties [16:54:33] <ctomc> kkhan: currently we have no special handling for this, but it will be added as part of "default transformer" [16:55:04] <kkhan> So DC would call resolveExpression on legacy HC and massage the op or something? [16:55:33] <kkhan> jmesnil: ^^ is what I felt it could break :-) [16:55:43] <emuckenhuber> it can't [16:56:00] <emuckenhuber> since there might be multiple server-groups on the legacy HC [16:56:20] <emuckenhuber> so it won't have the information any longer when it starts the server [16:56:36] <emuckenhuber> i mean as it is now... i was thinking adding that information somewhere [16:57:13] <emuckenhuber> we could do it for runtime operations though - although not sure if that makes sense [16:57:53] <kkhan> emuckenhuber: ok, could you not resolve per server group? [16:58:36] <kkhan> I'm just throwing out ideas without looking in case that is not clear :-) [16:58:43] <emuckenhuber> profiles can be shared, so i guess not [17:02:29] <ctomc> jmesnil: from my point of view, fix for this issue should be trivial, except for maybe transformation stuff :| [17:03:56] <kkhan> jmesnil: Nothing springs to mind about what would be bad apart from transformations for me either so go ahead. Surely this will not be the only thing introducing expressions [17:04:44] <jmesnil> kkhan, ok, thanks! :) [17:05:42] <kkhan> jmesnil: Add more stuff to org.jboss.as.controller.services.path.PathsTestCase and if there is stuff we can't see now it will hopefully make it clear [17:06:05] <jmesnil> kkhan, +1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira