[ https://issues.jboss.org/browse/JBRULES-2734?page=com.atlassian.jira.plug... ] Mark Proctor commented on JBRULES-2734: --------------------------------------- Turn off incremental, and it should work ok for now. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-2734?page=com.atlassian.jira.plug... ] Mark Proctor updated JBRULES-2734: ---------------------------------- Fix Version/s: 5.2.0.CR1 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-2734?page=com.atlassian.jira.plug... ] Mark Proctor commented on JBRULES-2734: --------------------------------------- Look at the DialectRuntimeData and the life cycles there, and where's it's called from RuleBase to understand the wiring life cycle. You might be able to write some code to artificially wire the package. Remember to make the target kbase the root parent classloader, so that it can find any type declaration classes it may need. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-2734?page=com.atlassian.jira.plug... ] Esteban Aliverti commented on JBRULES-2734: ------------------------------------------- I tried to reproduce the error using the following rule: {code:none} package org.drools global Integer salesChannelId; global Boolean includeFinishing; global java.util.List list; rule "Rule A" dialect "java" ruleflow-group "finishing-price" when $s : String() eval(salesChannelId @operator@ 4 && includeFinishing) then list.add("@message@"); end {code} In the code above, I'm using @operator@ and @message@ as placeholders that helps me to modify the rule so the agent can process it. What I do first is to replace @operator@ with "!=" and let the agent to compile the rule. After that, I replace @operator@ with "==" and notify the agent about this change. The change is applied correctly. If I debug the test, I can see how EvalCondition.equals() is invoked and how it returns the correct value. @Tommy, do you see any significant difference between your rule and the one I'm using? Can you test your code using Drools 5.2? BTW, I will implement the missing comparison for WorkFlowProcess. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-2734?page=com.atlassian.jira.plug... ] Anton Litvinenko edited comment on JBRULES-2734 at 5/17/11 2:11 PM: -------------------------------------------------------------------- @Esteban, for me it is failing when a rule is present in the package (compiled and distributed by Guvnor). The change set pointed to that package and ruleflow is not even using it. I change the ruleflow (not even touching the rule), commit it to Guvnor, re-build the package and see change-set update crash in the log. change-set: {code:xml} <change-set xmlns='http://drools.org/drools-5.0/change-set' xmlns:xs='http://www.w3.org/2001/XMLSchema-instance' xs:schemaLocation='http://drools.org/drools-5.0/change-set drools-change-set-5.0.xsd'> <add> <resource source='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST' type='PKG' basicAuthentication='enabled' username='' password=''/> </add> </change-set> {code} Rule: {code:xml} #created on: Apr 7, 2011 package my.package; import java.util.Map; rule "HelloWorldRule" when params : Map() eval( params.get("Greeting") == null ) then params.put("Greeting", "Hello World!" ); update( params ); end {code} And the stack trace: {code} [2011:05:137 14:05:167:debug] ResourceChangeScanner thread is waiting for 30 seconds. [2011:05:137 14:05:166:debug] ResourceChangeScanner attempt to scan 1 resources [2011:05:137 14:05:173:debug] ResourceChangeScanner modified resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] : 1305640544000 : 1305640889000 [2011:05:137 14:05:173:debug] ResourceChangeNotification received ChangeSet notification [2011:05:137 14:05:173:debug] ResourceChangeScanner thread is waiting for 30 seconds. [2011:05:137 14:05:173:debug] ResourceChangeNotification processing ChangeSet [2011:05:137 14:05:174:debug] ResourceChangeNotification ChangeSet modified resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] for listener=org.drools.agent.impl.KnowledgeAgentImpl@602fe64a [2011:05:137 14:05:174:debug] KnowledgeAgent received ChangeSet changed notification [2011:05:137 14:05:175:debug] ResourceChangeNotification thread is waiting for queue update [2011:05:137 14:05:175:info] KnowledgeAgent applying ChangeSet [2011:05:137 14:05:175:debug] KnowledgeAgent removing mappings for resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] with unsubscribe=true [2011:05:137 14:05:176:debug] KnowledgeAgent notifier unsubscribing to resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] [2011:05:137 14:05:176:debug] ResourceChangeNotification unsubscribing listener=org.drools.agent.impl.KnowledgeAgentImpl@602fe64a to resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] [2011:05:137 14:05:176:debug] ResourceChangeScanner unsubcribing notifier=org.drools.io.impl.ResourceChangeNotifierImpl@68b8359b to resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] [2011:05:137 14:05:176:debug] ResourceChangeScanner resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] now has no subscribers [2011:05:137 14:05:176:debug] KnowledgeAgent rebuilding KnowledgeBase using ChangeSet [2011:05:137 14:05:176:info] KnowledgeAgent performing an incremental build of the ChangeSet [2011:05:137 14:05:229:debug] KnowledgeAgent: Diffing: [UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] no visitor implementation for : class org.drools.ruleflow.core.RuleFlowProcess : org.drools.ruleflow.core.RuleFlowProcess@30138b [2011:05:137 14:05:234:debug] BinaryResourceDiffProducerImpl: Comparing [Rule name=HelloWorldRule, agendaGroup=MAIN, salience=0, no-loop=false] against [Rule name=HelloWorldRule, agendaGroup=MAIN, salience=0, no-loop=false] Exception in thread "Thread-17" org.drools.RuntimeDroolsException: java.lang.reflect.InvocationTargetException : [Rule name=HelloWorldRule, agendaGroup=MAIN, salience=0, no-loop=false] at org.drools.core.util.ReflectiveVisitor.visit(ReflectiveVisitor.java:56) at org.drools.agent.impl.BinaryResourceDiffProducerImpl.diff(BinaryResourceDiffProducerImpl.java:63) at org.drools.agent.impl.KnowledgeAgentImpl.incrementalBuildResources(KnowledgeAgentImpl.java:785) at org.drools.agent.impl.KnowledgeAgentImpl.buildKnowledgeBase(KnowledgeAgentImpl.java:586) at org.drools.agent.impl.KnowledgeAgentImpl.applyChangeSet(KnowledgeAgentImpl.java:185) at org.drools.agent.impl.KnowledgeAgentImpl$ChangeSetNotificationDetector.run(KnowledgeAgentImpl.java:1106) at java.lang.Thread.run(Thread.java:680) Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.drools.core.util.ReflectiveVisitor.visit(ReflectiveVisitor.java:47) ... 6 more Caused by: java.lang.NullPointerException at org.drools.rule.EvalCondition.equals(EvalCondition.java:169) at org.drools.rule.GroupElement.equals(GroupElement.java:273) at org.drools.agent.impl.BinaryResourceDiffProducerImpl.compareRules(BinaryResourceDiffProducerImpl.java:258) at org.drools.agent.impl.BinaryResourceDiffProducerImpl.visitRule(BinaryResourceDiffProducerImpl.java:117) ... 11 more [2011:05:137 14:05:172:debug] ResourceChangeScanner attempt to scan 0 resources [2011:05:137 14:05:172:debug] ResourceChangeScanner thread is waiting for 30 seconds. {code} Whenever I delete rule from package -> I dont see this error anymore was (Author: anton.litvinenko): @Esteban, for me it is failing when a rule is present in the package (compiled and distributed by Guvnor). The change set pointed to that package and ruleflow is not even using it. change-set: {code:xml} <change-set xmlns='http://drools.org/drools-5.0/change-set' xmlns:xs='http://www.w3.org/2001/XMLSchema-instance' xs:schemaLocation='http://drools.org/drools-5.0/change-set drools-change-set-5.0.xsd'> <add> <resource source='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST' type='PKG' basicAuthentication='enabled' username='' password=''/> </add> </change-set> {code} Rule: {code:xml} #created on: Apr 7, 2011 package my.package; import java.util.Map; rule "HelloWorldRule" when params : Map() eval( params.get("Greeting") == null ) then params.put("Greeting", "Hello World!" ); update( params ); end {code} And the stack trace: {code} [2011:05:137 14:05:167:debug] ResourceChangeScanner thread is waiting for 30 seconds. [2011:05:137 14:05:166:debug] ResourceChangeScanner attempt to scan 1 resources [2011:05:137 14:05:173:debug] ResourceChangeScanner modified resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] : 1305640544000 : 1305640889000 [2011:05:137 14:05:173:debug] ResourceChangeNotification received ChangeSet notification [2011:05:137 14:05:173:debug] ResourceChangeScanner thread is waiting for 30 seconds. [2011:05:137 14:05:173:debug] ResourceChangeNotification processing ChangeSet [2011:05:137 14:05:174:debug] ResourceChangeNotification ChangeSet modified resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] for listener=org.drools.agent.impl.KnowledgeAgentImpl@602fe64a [2011:05:137 14:05:174:debug] KnowledgeAgent received ChangeSet changed notification [2011:05:137 14:05:175:debug] ResourceChangeNotification thread is waiting for queue update [2011:05:137 14:05:175:info] KnowledgeAgent applying ChangeSet [2011:05:137 14:05:175:debug] KnowledgeAgent removing mappings for resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] with unsubscribe=true [2011:05:137 14:05:176:debug] KnowledgeAgent notifier unsubscribing to resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] [2011:05:137 14:05:176:debug] ResourceChangeNotification unsubscribing listener=org.drools.agent.impl.KnowledgeAgentImpl@602fe64a to resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] [2011:05:137 14:05:176:debug] ResourceChangeScanner unsubcribing notifier=org.drools.io.impl.ResourceChangeNotifierImpl@68b8359b to resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] [2011:05:137 14:05:176:debug] ResourceChangeScanner resource=[UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] now has no subscribers [2011:05:137 14:05:176:debug] KnowledgeAgent rebuilding KnowledgeBase using ChangeSet [2011:05:137 14:05:176:info] KnowledgeAgent performing an incremental build of the ChangeSet [2011:05:137 14:05:229:debug] KnowledgeAgent: Diffing: [UrlResource path='http://localhost:8080/guvnor/org.drools.guvnor.Guvnor/package/my.package/LATEST'] no visitor implementation for : class org.drools.ruleflow.core.RuleFlowProcess : org.drools.ruleflow.core.RuleFlowProcess@30138b [2011:05:137 14:05:234:debug] BinaryResourceDiffProducerImpl: Comparing [Rule name=HelloWorldRule, agendaGroup=MAIN, salience=0, no-loop=false] against [Rule name=HelloWorldRule, agendaGroup=MAIN, salience=0, no-loop=false] Exception in thread "Thread-17" org.drools.RuntimeDroolsException: java.lang.reflect.InvocationTargetException : [Rule name=HelloWorldRule, agendaGroup=MAIN, salience=0, no-loop=false] at org.drools.core.util.ReflectiveVisitor.visit(ReflectiveVisitor.java:56) at org.drools.agent.impl.BinaryResourceDiffProducerImpl.diff(BinaryResourceDiffProducerImpl.java:63) at org.drools.agent.impl.KnowledgeAgentImpl.incrementalBuildResources(KnowledgeAgentImpl.java:785) at org.drools.agent.impl.KnowledgeAgentImpl.buildKnowledgeBase(KnowledgeAgentImpl.java:586) at org.drools.agent.impl.KnowledgeAgentImpl.applyChangeSet(KnowledgeAgentImpl.java:185) at org.drools.agent.impl.KnowledgeAgentImpl$ChangeSetNotificationDetector.run(KnowledgeAgentImpl.java:1106) at java.lang.Thread.run(Thread.java:680) Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.drools.core.util.ReflectiveVisitor.visit(ReflectiveVisitor.java:47) ... 6 more Caused by: java.lang.NullPointerException at org.drools.rule.EvalCondition.equals(EvalCondition.java:169) at org.drools.rule.GroupElement.equals(GroupElement.java:273) at org.drools.agent.impl.BinaryResourceDiffProducerImpl.compareRules(BinaryResourceDiffProducerImpl.java:258) at org.drools.agent.impl.BinaryResourceDiffProducerImpl.visitRule(BinaryResourceDiffProducerImpl.java:117) ... 11 more [2011:05:137 14:05:172:debug] ResourceChangeScanner attempt to scan 0 resources [2011:05:137 14:05:172:debug] ResourceChangeScanner thread is waiting for 30 seconds. {code} Whenever I delete rule from package -> I dont see this error anymore -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-2734?page=com.atlassian.jira.plug... ] Esteban Aliverti commented on JBRULES-2734: ------------------------------------------- Ok, I made a fix for this issue: https://github.com/droolsjbpm/drools/compare/585cf7b...735b629 Please test if this fix your problem. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-2734?page=com.atlassian.jira.plug... ] Esteban Aliverti resolved JBRULES-2734. --------------------------------------- Labels: knowledge_agent package_serialization (was: ) Resolution: Done Done -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira