3:07 p.m.
Martin Vanek created AS7-5802:
---------------------------------
Summary: New instance of the filter in always created
Key: AS7-5802
URL: https://issues.jboss.org/browse/AS7-5802
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.1.Final
Reporter: Martin Vanek
Assignee: Remy Maucherat
I have created Servlet 3.0 filter in WebApplicationInitializer.onStartup() for example the
following way:
public void onStartup(ServletContext servletContext) throws ServletException {
String servletName = "someServlet";
String[] mappings = new String[] {"*.html"};
Servlet servlet = FooServlet();
ServletRegistration.Dynamic s = servletContext.addServlet(servletName, servlet);
s.setLoadOnStartup(1);
s.addMapping(mappings);
Filter filter = new FooFilter("argument");
String[] servletNames = new String[] {servletName};
FilterRegistration.Dynamic f = servletContext.addFilter("fooFilter", filter);
f.addMappingForServletNames(null, false, servletNames);
}
My problem is that jboss-web implemntation 7.0.13+ in StartdardContext.filterStart() along
with ApplicationFilterConfig.getFilter() always tries to create new instance of the Filter
via default constructor.
My FooFilter does not have default constructor and therefore my application cannot be
deployed.
Please, check current implementation in Tomcat 7.0.32, which does not contain this
problem.
Also I have found that ApplicationFilterConfig has two similar atributes named filter and
filterInstance. I guess it is quite wrong implementation and it is related to my problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:29 a.m.
[
https://issues.jboss.org/browse/AS7-5802?page=com.atlassian.jira.plugin.s...
]
Remy Maucherat commented on AS7-5802:
-------------------------------------
I don't see anything wrong in the implementation, the filterInstance should get used
if it is present. Tomcat is not the same implementation, but that's a problem by
itself obviously.
Can you provide a test war ?
New instance of the filter in always created
--------------------------------------------
Key: AS7-5802
URL: https://issues.jboss.org/browse/AS7-5802
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.1.Final
Reporter: Martin Vanek
Assignee: Remy Maucherat
Labels: filter
I have created Servlet 3.0 filter in WebApplicationInitializer.onStartup() for example
the following way:
public void onStartup(ServletContext servletContext) throws ServletException {
String servletName = "someServlet";
String[] mappings = new String[] {"*.html"};
Servlet servlet = FooServlet();
ServletRegistration.Dynamic s = servletContext.addServlet(servletName, servlet);
s.setLoadOnStartup(1);
s.addMapping(mappings);
Filter filter = new FooFilter("argument");
String[] servletNames = new String[] {servletName};
FilterRegistration.Dynamic f = servletContext.addFilter("fooFilter",
filter);
f.addMappingForServletNames(null, false, servletNames);
}
My problem is that jboss-web implemntation 7.0.13+ in StartdardContext.filterStart()
along with ApplicationFilterConfig.getFilter() always tries to create new instance of the
Filter via default constructor.
My FooFilter does not have default constructor and therefore my application cannot be
deployed.
Please, check current implementation in Tomcat 7.0.32, which does not contain this
problem.
Also I have found that ApplicationFilterConfig has two similar atributes named filter and
filterInstance. I guess it is quite wrong implementation and it is related to my problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:02 p.m.
[
https://issues.jboss.org/browse/AS7-5802?page=com.atlassian.jira.plugin.s...
]
Martin Vanek updated AS7-5802:
------------------------------
Attachment: filtertest-0.0.1-SNAPSHOT.war
New instance of the filter in always created
--------------------------------------------
Key: AS7-5802
URL: https://issues.jboss.org/browse/AS7-5802
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.1.Final
Reporter: Martin Vanek
Assignee: Remy Maucherat
Labels: filter
Attachments: filtertest-0.0.1-SNAPSHOT.war, filtertest.zip
I have created Servlet 3.0 filter in WebApplicationInitializer.onStartup() for example
the following way:
public void onStartup(ServletContext servletContext) throws ServletException {
String servletName = "someServlet";
String[] mappings = new String[] {"*.html"};
Servlet servlet = FooServlet();
ServletRegistration.Dynamic s = servletContext.addServlet(servletName, servlet);
s.setLoadOnStartup(1);
s.addMapping(mappings);
Filter filter = new FooFilter("argument");
String[] servletNames = new String[] {servletName};
FilterRegistration.Dynamic f = servletContext.addFilter("fooFilter",
filter);
f.addMappingForServletNames(null, false, servletNames);
}
My problem is that jboss-web implemntation 7.0.13+ in StartdardContext.filterStart()
along with ApplicationFilterConfig.getFilter() always tries to create new instance of the
Filter via default constructor.
My FooFilter does not have default constructor and therefore my application cannot be
deployed.
Please, check current implementation in Tomcat 7.0.32, which does not contain this
problem.
Also I have found that ApplicationFilterConfig has two similar atributes named filter and
filterInstance. I guess it is quite wrong implementation and it is related to my problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:02 p.m.
[
https://issues.jboss.org/browse/AS7-5802?page=com.atlassian.jira.plugin.s...
]
Martin Vanek updated AS7-5802:
------------------------------
Attachment: filtertest.zip
New instance of the filter in always created
--------------------------------------------
Key: AS7-5802
URL: https://issues.jboss.org/browse/AS7-5802
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.1.Final
Reporter: Martin Vanek
Assignee: Remy Maucherat
Labels: filter
Attachments: filtertest-0.0.1-SNAPSHOT.war, filtertest.zip
I have created Servlet 3.0 filter in WebApplicationInitializer.onStartup() for example
the following way:
public void onStartup(ServletContext servletContext) throws ServletException {
String servletName = "someServlet";
String[] mappings = new String[] {"*.html"};
Servlet servlet = FooServlet();
ServletRegistration.Dynamic s = servletContext.addServlet(servletName, servlet);
s.setLoadOnStartup(1);
s.addMapping(mappings);
Filter filter = new FooFilter("argument");
String[] servletNames = new String[] {servletName};
FilterRegistration.Dynamic f = servletContext.addFilter("fooFilter",
filter);
f.addMappingForServletNames(null, false, servletNames);
}
My problem is that jboss-web implemntation 7.0.13+ in StartdardContext.filterStart()
along with ApplicationFilterConfig.getFilter() always tries to create new instance of the
Filter via default constructor.
My FooFilter does not have default constructor and therefore my application cannot be
deployed.
Please, check current implementation in Tomcat 7.0.32, which does not contain this
problem.
Also I have found that ApplicationFilterConfig has two similar atributes named filter and
filterInstance. I guess it is quite wrong implementation and it is related to my problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:02 p.m.
[
https://issues.jboss.org/browse/AS7-5802?page=com.atlassian.jira.plugin.s...
]
Martin Vanek commented on AS7-5802:
-----------------------------------
JBossWeb implementation creates always new instance ignoring the fact the instance of the
filter is already created in ServletContainerInitializer.
Anyway I have attached the source code and war file.
New instance of the filter in always created
--------------------------------------------
Key: AS7-5802
URL: https://issues.jboss.org/browse/AS7-5802
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.1.Final
Reporter: Martin Vanek
Assignee: Remy Maucherat
Labels: filter
Attachments: filtertest-0.0.1-SNAPSHOT.war, filtertest.zip
I have created Servlet 3.0 filter in WebApplicationInitializer.onStartup() for example
the following way:
public void onStartup(ServletContext servletContext) throws ServletException {
String servletName = "someServlet";
String[] mappings = new String[] {"*.html"};
Servlet servlet = FooServlet();
ServletRegistration.Dynamic s = servletContext.addServlet(servletName, servlet);
s.setLoadOnStartup(1);
s.addMapping(mappings);
Filter filter = new FooFilter("argument");
String[] servletNames = new String[] {servletName};
FilterRegistration.Dynamic f = servletContext.addFilter("fooFilter",
filter);
f.addMappingForServletNames(null, false, servletNames);
}
My problem is that jboss-web implemntation 7.0.13+ in StartdardContext.filterStart()
along with ApplicationFilterConfig.getFilter() always tries to create new instance of the
Filter via default constructor.
My FooFilter does not have default constructor and therefore my application cannot be
deployed.
Please, check current implementation in Tomcat 7.0.32, which does not contain this
problem.
Also I have found that ApplicationFilterConfig has two similar atributes named filter and
filterInstance. I guess it is quite wrong implementation and it is related to my problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:57 a.m.
[
https://issues.jboss.org/browse/AS7-5802?page=com.atlassian.jira.plugin.s...
]
Cheng Fang commented on AS7-5802:
---------------------------------
ServletContext javadoc
http://docs.oracle.com/javaee/6/api/javax/servlet/ServletContext.html#add...
says
Registers the given filter instance with this ServletContext under the given filterName.
---------------
Currently AS 7 always uses the container-managed instance (instantiated with default
no-arg constructor), instead of the application-created filter instance, to perform
doFilter. In most cases, this is ok, but if the filter has instance-specific state,
things can go wrong.
The application-created filter instance is not used and GC'ed once it's out of
scope, even before undeployment.
New instance of the filter in always created
--------------------------------------------
Key: AS7-5802
URL: https://issues.jboss.org/browse/AS7-5802
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.1.Final
Reporter: Martin Vanek
Assignee: Remy Maucherat
Labels: filter
Attachments: filtertest-0.0.1-SNAPSHOT.war, filtertest.zip
I have created Servlet 3.0 filter in WebApplicationInitializer.onStartup() for example
the following way:
public void onStartup(ServletContext servletContext) throws ServletException {
String servletName = "someServlet";
String[] mappings = new String[] {"*.html"};
Servlet servlet = FooServlet();
ServletRegistration.Dynamic s = servletContext.addServlet(servletName, servlet);
s.setLoadOnStartup(1);
s.addMapping(mappings);
Filter filter = new FooFilter("argument");
String[] servletNames = new String[] {servletName};
FilterRegistration.Dynamic f = servletContext.addFilter("fooFilter",
filter);
f.addMappingForServletNames(null, false, servletNames);
}
My problem is that jboss-web implemntation 7.0.13+ in StartdardContext.filterStart()
along with ApplicationFilterConfig.getFilter() always tries to create new instance of the
Filter via default constructor.
My FooFilter does not have default constructor and therefore my application cannot be
deployed.
Please, check current implementation in Tomcat 7.0.32, which does not contain this
problem.
Also I have found that ApplicationFilterConfig has two similar atributes named filter and
filterInstance. I guess it is quite wrong implementation and it is related to my problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:39 a.m.
[
https://issues.jboss.org/browse/AS7-5802?page=com.atlassian.jira.plugin.s...
]
Remy Maucherat commented on AS7-5802:
-------------------------------------
Thanks for the test case.
New instance of the filter in always created
--------------------------------------------
Key: AS7-5802
URL: https://issues.jboss.org/browse/AS7-5802
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.1.Final
Reporter: Martin Vanek
Assignee: Remy Maucherat
Labels: filter
Attachments: filtertest-0.0.1-SNAPSHOT.war, filtertest.zip
I have created Servlet 3.0 filter in WebApplicationInitializer.onStartup() for example
the following way:
public void onStartup(ServletContext servletContext) throws ServletException {
String servletName = "someServlet";
String[] mappings = new String[] {"*.html"};
Servlet servlet = FooServlet();
ServletRegistration.Dynamic s = servletContext.addServlet(servletName, servlet);
s.setLoadOnStartup(1);
s.addMapping(mappings);
Filter filter = new FooFilter("argument");
String[] servletNames = new String[] {servletName};
FilterRegistration.Dynamic f = servletContext.addFilter("fooFilter",
filter);
f.addMappingForServletNames(null, false, servletNames);
}
My problem is that jboss-web implemntation 7.0.13+ in StartdardContext.filterStart()
along with ApplicationFilterConfig.getFilter() always tries to create new instance of the
Filter via default constructor.
My FooFilter does not have default constructor and therefore my application cannot be
deployed.
Please, check current implementation in Tomcat 7.0.32, which does not contain this
problem.
Also I have found that ApplicationFilterConfig has two similar atributes named filter and
filterInstance. I guess it is quite wrong implementation and it is related to my problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:07 p.m.
[
https://issues.jboss.org/browse/AS7-5802?page=com.atlassian.jira.plugin.s...
]
Martin Vanek commented on AS7-5802:
-----------------------------------
Do I understand it correctly that if specification says: "Registers the given filter
instance with this ServletContext under the given filterName.", that
application-created filter has to become part of container-managed part?
Probably the (I do not check the code the jbossweb implementation yet), but the very same
problem could be with the instance of the Servlet in addServlet method.
New instance of the filter in always created
--------------------------------------------
Key: AS7-5802
URL: https://issues.jboss.org/browse/AS7-5802
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.1.Final
Reporter: Martin Vanek
Assignee: Remy Maucherat
Labels: filter
Attachments: filtertest-0.0.1-SNAPSHOT.war, filtertest.zip
I have created Servlet 3.0 filter in WebApplicationInitializer.onStartup() for example
the following way:
public void onStartup(ServletContext servletContext) throws ServletException {
String servletName = "someServlet";
String[] mappings = new String[] {"*.html"};
Servlet servlet = FooServlet();
ServletRegistration.Dynamic s = servletContext.addServlet(servletName, servlet);
s.setLoadOnStartup(1);
s.addMapping(mappings);
Filter filter = new FooFilter("argument");
String[] servletNames = new String[] {servletName};
FilterRegistration.Dynamic f = servletContext.addFilter("fooFilter",
filter);
f.addMappingForServletNames(null, false, servletNames);
}
My problem is that jboss-web implemntation 7.0.13+ in StartdardContext.filterStart()
along with ApplicationFilterConfig.getFilter() always tries to create new instance of the
Filter via default constructor.
My FooFilter does not have default constructor and therefore my application cannot be
deployed.
Please, check current implementation in Tomcat 7.0.32, which does not contain this
problem.
Also I have found that ApplicationFilterConfig has two similar atributes named filter and
filterInstance. I guess it is quite wrong implementation and it is related to my problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:07 p.m.
[
https://issues.jboss.org/browse/AS7-5802?page=com.atlassian.jira.plugin.s...
]
Martin Vanek edited comment on AS7-5802 at 10/23/12 2:06 PM:
-------------------------------------------------------------
Do I understand it correctly that if specification says: "Registers the given filter
instance with this ServletContext under the given filterName.", that
application-created filter has to become part of container-managed?
Probably the (I do not check the code the jbossweb implementation yet), but the very same
problem could be with the instance of the Servlet in addServlet method.
was (Author: momega2):
Do I understand it correctly that if specification says: "Registers the given
filter instance with this ServletContext under the given filterName.", that
application-created filter has to become part of container-managed part?
Probably the (I do not check the code the jbossweb implementation yet), but the very same
problem could be with the instance of the Servlet in addServlet method.
New instance of the filter in always created
--------------------------------------------
Key: AS7-5802
URL: https://issues.jboss.org/browse/AS7-5802
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.1.Final
Reporter: Martin Vanek
Assignee: Remy Maucherat
Labels: filter
Attachments: filtertest-0.0.1-SNAPSHOT.war, filtertest.zip
I have created Servlet 3.0 filter in WebApplicationInitializer.onStartup() for example
the following way:
public void onStartup(ServletContext servletContext) throws ServletException {
String servletName = "someServlet";
String[] mappings = new String[] {"*.html"};
Servlet servlet = FooServlet();
ServletRegistration.Dynamic s = servletContext.addServlet(servletName, servlet);
s.setLoadOnStartup(1);
s.addMapping(mappings);
Filter filter = new FooFilter("argument");
String[] servletNames = new String[] {servletName};
FilterRegistration.Dynamic f = servletContext.addFilter("fooFilter",
filter);
f.addMappingForServletNames(null, false, servletNames);
}
My problem is that jboss-web implemntation 7.0.13+ in StartdardContext.filterStart()
along with ApplicationFilterConfig.getFilter() always tries to create new instance of the
Filter via default constructor.
My FooFilter does not have default constructor and therefore my application cannot be
deployed.
Please, check current implementation in Tomcat 7.0.32, which does not contain this
problem.
Also I have found that ApplicationFilterConfig has two similar atributes named filter and
filterInstance. I guess it is quite wrong implementation and it is related to my problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:17 a.m.
[
https://issues.jboss.org/browse/AS7-5802?page=com.atlassian.jira.plugin.s...
]
Remy Maucherat commented on AS7-5802:
-------------------------------------
No, it should be fine. The problem was that the filter config was overwritten, very simple
issue.
New instance of the filter in always created
--------------------------------------------
Key: AS7-5802
URL: https://issues.jboss.org/browse/AS7-5802
Project: Application Server 7
Issue Type: Bug
Components: Web
Affects Versions: 7.1.1.Final
Reporter: Martin Vanek
Assignee: Remy Maucherat
Labels: filter
Attachments: filtertest-0.0.1-SNAPSHOT.war, filtertest.zip
I have created Servlet 3.0 filter in WebApplicationInitializer.onStartup() for example
the following way:
public void onStartup(ServletContext servletContext) throws ServletException {
String servletName = "someServlet";
String[] mappings = new String[] {"*.html"};
Servlet servlet = FooServlet();
ServletRegistration.Dynamic s = servletContext.addServlet(servletName, servlet);
s.setLoadOnStartup(1);
s.addMapping(mappings);
Filter filter = new FooFilter("argument");
String[] servletNames = new String[] {servletName};
FilterRegistration.Dynamic f = servletContext.addFilter("fooFilter",
filter);
f.addMappingForServletNames(null, false, servletNames);
}
My problem is that jboss-web implemntation 7.0.13+ in StartdardContext.filterStart()
along with ApplicationFilterConfig.getFilter() always tries to create new instance of the
Filter via default constructor.
My FooFilter does not have default constructor and therefore my application cannot be
deployed.
Please, check current implementation in Tomcat 7.0.32, which does not contain this
problem.
Also I have found that ApplicationFilterConfig has two similar atributes named filter and
filterInstance. I guess it is quite wrong implementation and it is related to my problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4941
days inactive
4944
days old
9 comments
3 participants
participants (3)
-
Cheng Fang (JIRA) -
Martin Vanek (JIRA)
-
Remy Maucherat (JIRA)