Re: [jboss-l10n] Fixing BRMS / BPMS 6.0 translations

Thank you Mike, I have noted those tips and information in this page. https://community.jboss.org/wiki/HowI18NIsBuiltInDroolsjbpmWorkbenchProjects Cheers, Toshiya ------------------------------------------------------------------------ *From: *"Michael Anstis" <manstis(a)redhat.com <mailto:manstis@redhat.com>> *To: *"Toshiya Kobayashi" <tkobayas(a)redhat.com <mailto:tkobayas@redhat.com>> *Cc: *"Mauricio Salatino" <msalatin(a)redhat.com <mailto:msalatin@redhat.com>>, jboss-l10n(a)lists.jboss.org <mailto:jboss-l10n@lists.jboss.org> *Sent: *Tuesday, November 19, 2013 8:13:26 PM *Subject: *Re: [jboss-l10n] Fixing BRMS / BPMS 6.0 translations It's not so simple ;) You'd need to build everything upwards (after having pulled the translations and ran the apostrophe fix):- * uberfire * guvnor * kie-wb-common * drools-wb * jbpm-form-builder * jbpm-console * jbpm-designer * Possibly some others I've missed that are jbpm centric - Salaboy? * kie-wb-distributions The translations for each project are stored in their respective JAR that is added to kie-wb-distributions' dependencies. With kind regards, Mike On 19/11/13 11:09, Toshiya Kobayashi wrote: Thanks Mike, When translations complete, I'll pull translations and build kie-wb-distributions on my local machine first so I hope I can fix such errors before disturbing you. Cheers, Toshiya ----- Original Message ----- From: "Michael Anstis&quot;&lt;manstis(a)redhat.com&gt; To: "Toshiya Kobayashi&quot;&lt;tkobayas(a)redhat.com&gt; Cc: "Mauricio Salatino&quot;&lt;msalatin@redhat.com&gt;,jboss-l10n(a)lists.jboss.org Sent: Tuesday, November 19, 2013 7:22:36 PM Subject: Re: [jboss-l10n] Fixing BRMS / BPMS 6.0 translations Hi Toshiya, Here's an example of the "missing place-holder" issue:- Source document: hello0=Hello {0} Translation: hello0=Salute The translation is missing the {0} parameter. I fixed a couple of missing parameters when I last pulled the translations. Unfortunately I've not been able to find the commit; as I can't remember the project or when I did it :( If I find a repeat occurrence when I next pull the translations I'll let you know. With kind regards, Mike On 12/11/13 11:46, Toshiya Kobayashi wrote: Hi Mike and Salaboy, I'd like to understand about issues other than apostrophe so that I can detect the issue before pushing translations to github/Jenkins. I'm asking because I built fullProfile kie-wb-distributions without error for pt_BR and zh_CN which are currently disabled. Also after applying mvn replacer, I could built all locales including fr_FR. You said that issues are hard to spot but do you happened to have any additional information about that (e.g. Jenkins log)? (2) Removal of variable place-holders. A source string may contain {0} (or 1, 2, 3 etc). This represents a place-holder where our code substitutes a value at runtime. These are sometimes been removed which breaks our code. I wrote a small program to detect missing place-holders but I couldn't find the issue in resources in master branch. (Actually, there is bad Constants_es.properties but it's not compiled because Constants_es_ES.properties is used instead) Cheers, Toshiya ----- Original Message ----- From: "Toshiya Kobayashi&quot;&lt;tkobayas(a)redhat.com&gt; To: &quot;salaboy&quot;&lt;salaboy(a)redhat.com&gt;, "Michael Anstis&quot;&lt;manstis(a)redhat.com&gt; Cc: "Mark Proctor&quot;&lt;mproctor(a)codehaus.org&gt;, "Mauricio Salatino&quot;&lt;msalatin(a)redhat.com&gt;, "Pedro Zapata Fernandez&quot;&lt;pzapataf(a)redhat.com&gt;, "Kris Verlaenen&quot;&lt;kris.verlaenen(a)gmail.com&gt;, "Edson Tirelli&quot;&lt;etirelli@redhat.com&gt;,jboss-l10n(a)lists.jboss.org Sent: Tuesday, November 5, 2013 2:22:21 PM Subject: Re: [jboss-l10n] Fixing BRMS / BPMS 6.0 translations Thank you for pointing that, Mike and Salaboy. I'll check with translators (I guess most of them are subscribers of this mailing list) and coordinate "fix" and "education". Regards, Toshiya ----- Original Message ----- From: &quot;salaboy&quot;&lt;salaboy(a)redhat.com&gt; To: "Michael Anstis&quot;&lt;manstis(a)redhat.com&gt; Cc: "Toshiya Kobayashi&quot;&lt;tkobayas@redhat.com&gt;,jboss-l10n(a)lists.jboss.org, "Mauricio Salatino&quot;&lt;msalatin(a)redhat.com&gt;, "Pedro Zapata Fernandez&quot;&lt;pzapataf(a)redhat.com&gt;, "Edson Tirelli&quot;&lt;etirelli(a)redhat.com&gt;, "Mark Proctor&quot;&lt;mproctor(a)codehaus.org&gt;, "Kris Verlaenen&quot;&lt;kris.verlaenen(a)gmail.com&gt; Sent: Monday, November 4, 2013 8:55:22 PM Subject: Re: Fixing BRMS / BPMS 6.0 translations The current state is: 1) All the languages that are not causing issues are enabled 2) All the languages that are causing issues are commented out and not included in the builds Look here: https://github.com/droolsjbpm/kie-wb-distributions/blob/master/kie-wb/kie... It’s just matter of enabling the languages again to see all the error that those files are causing. Once we have all the languages working we can start to translate the missing screens, so we can add the new variables to all the languages files. On 4 Nov 2013, at 11:52, Michael Anstis&lt;manstis(a)redhat.com&gt; wrote: Hi Toshiya, IDK if you're who we need to talk to, but I'm sure you can direct me to the appropriate person. We've started pulling in various translations from Zanata and some are causing problems. These are examples I've witnessed:- (1) Use of certain characters, e.g. apostrophe. These need to be escaped with i.e. replaced with two apostrophes. (2) Removal of variable place-holders. A source string may contain {0} (or 1, 2, 3 etc). This represents a place-holder where our code substitutes a value at runtime. These are sometimes been removed which breaks our code. There are various Jenkins jobs that can be examined to check our code compiles; but failures due to i18n issues are hard to spot (or at least you'd need to know what to look for). How can we educate translators as to these issues; and ensure fixes are made to the translation files in Zanata? With kind regards, Mike _______________________________________________ jboss-l10n mailing list jboss-l10n(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-l10n -- Michael Anstis Senior Developer Red Hat Business Systems and Intelligence Group