JBoss Tools SVN: r43881 - trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/internal.
by jbosstools-commits＠lists.jboss.org
Author: scabanovich
Date: 2012-09-20 16:24:43 -0400 (Thu, 20 Sep 2012)
New Revision: 43881
Modified:
trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/internal/ELValidatorContext.java
trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/internal/LinkCollection.java
trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/internal/ProjectValidationContext.java
Log:
JBIDE-12479
https://issues.jboss.org/browse/JBIDE-12479
Reduce maps in LinkCollection.
Modified: trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/internal/ELValidatorContext.java
===================================================================
--- trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/internal/ELValidatorContext.java 2012-09-20 20:21:47 UTC (rev 43880)
+++ trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/internal/ELValidatorContext.java 2012-09-20 20:24:43 UTC (rev 43881)
@@ -59,7 +59,7 @@
variableNames = new HashSet<String>();
variableNamesByEl.put(el, variableNames);
}
- if(variableNames.add(variableName)) {
+ if(variableNames.add(variableName.intern())) {
modifications++;
}
}
Modified: trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/internal/LinkCollection.java
===================================================================
--- trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/internal/LinkCollection.java 2012-09-20 20:21:47 UTC (rev 43880)
+++ trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/internal/LinkCollection.java 2012-09-20 20:24:43 UTC (rev 43881)
@@ -37,6 +37,10 @@
this.id = id;
}
+ public void disableResourcesByVariableName() {
+ resourcesByVariableName = null;
+ }
+
protected int modifications = 0;
/**
@@ -51,17 +55,19 @@
throw new IllegalArgumentException(ValidationMessages.VALIDATION_CONTEXT_VARIABLE_NAME_MUST_NOT_BE_NULL);
}
- synchronized(this) {
- Set<IPath> linkedResources = resourcesByVariableName.get(variableName);
- if(linkedResources==null) {
- // create set of linked resources with variable name.
- linkedResources = new HashSet<IPath>();
- resourcesByVariableName.put(variableName, linkedResources);
+ if(resourcesByVariableName != null) {
+ synchronized(this) {
+ Set<IPath> linkedResources = resourcesByVariableName.get(variableName);
+ if(linkedResources==null) {
+ // create set of linked resources with variable name.
+ linkedResources = new HashSet<IPath>();
+ resourcesByVariableName.put(variableName, linkedResources);
+ }
+ //save linked resources.
+ if(linkedResources.add(linkedResourcePath)) {
+ modifications++;
+ }
}
- // save linked resources.
- if(linkedResources.add(linkedResourcePath)) {
- modifications++;
- }
}
// Save link between resource and variable names. It's needed if variable name changes in resource file.
@@ -70,7 +76,7 @@
variableNames = new HashSet<String>();
variableNamesByResource.put(linkedResourcePath, variableNames);
}
- if(variableNames.add(variableName)) {
+ if(variableNames.add(variableName.intern())) {
modifications++;
}
@@ -106,17 +112,19 @@
* @param linkedResourcePath
*/
public void removeLinkedResource(String name, IPath linkedResourcePath) {
- synchronized(this) {
- Set<IPath> linkedResources = resourcesByVariableName.get(name);
- if(linkedResources!=null) {
- // remove linked resource.
- if(linkedResources.remove(linkedResourcePath)) {
- modifications++;
+ if(resourcesByVariableName != null) {
+ synchronized(this) {
+ Set<IPath> linkedResources = resourcesByVariableName.get(name);
+ if(linkedResources!=null) {
+ // remove linked resource.
+ if(linkedResources.remove(linkedResourcePath)) {
+ modifications++;
+ }
}
+ if(linkedResources.isEmpty()) {
+ resourcesByVariableName.remove(name);
+ }
}
- if(linkedResources.isEmpty()) {
- resourcesByVariableName.remove(name);
- }
}
// Remove link between resource and declaring variable names.
Set<String> variableNames = variableNamesByResource.get(linkedResourcePath);
@@ -168,7 +176,7 @@
*/
public synchronized void removeLinkedResource(IPath resource) {
Set<String> resourceNames = variableNamesByResource.get(resource);
- if(resourceNames!=null) {
+ if(resourceNames!=null && resourcesByVariableName != null) {
for (String name : resourceNames) {
Set<IPath> linkedResources = resourcesByVariableName.get(name);
if(linkedResources!=null) {
@@ -205,7 +213,10 @@
}
public Set<IPath> getResourcesByVariableName(String variableName, boolean declaration) {
- return declaration?resourcesByDeclaringVariableName.get(variableName):resourcesByVariableName.get(variableName);
+ if(!declaration && resourcesByVariableName == null) {
+ throw new RuntimeException("ResourcesByVariableName are disabled.");
+ }
+ return declaration ? resourcesByDeclaringVariableName.get(variableName) : resourcesByVariableName.get(variableName);
}
public synchronized Set<String> getVariableNamesByResource(IPath fullPath, boolean declaration) {
@@ -244,7 +255,9 @@
* Clear all references
*/
public synchronized void clearAll() {
- resourcesByVariableName.clear();
+ if(resourcesByVariableName != null) {
+ resourcesByVariableName.clear();
+ }
variableNamesByResource.clear();
declaringVariableNamesByResource.clear();
resourcesByDeclaringVariableName.clear();
@@ -257,30 +270,30 @@
* @param root
*/
public synchronized void store(Element root, Map<String, String> pathAliases) {
- Set<String> variables = resourcesByVariableName.keySet();
- for (String name: variables) {
- Set<IPath> paths = resourcesByVariableName.get(name);
- if(paths == null) continue;
- String nameAlias = ELReference.getAlias(pathAliases, name);
- StringBuilder declarationFalsePaths = new StringBuilder();
- StringBuilder declarationTruePaths = new StringBuilder();
- for (IPath path: paths) {
- String pathAlias = ELReference.getAlias(pathAliases, path.toString());
+ Set<IPath> paths = variableNamesByResource.keySet();
+ for (IPath path: paths) {
+ String pathAlias = ELReference.getAlias(pathAliases, path.toString());
+ Set<String> variables = variableNamesByResource.get(path);
+ if(variables == null || variables.isEmpty()) continue;
+ StringBuilder declarationFalseNames = new StringBuilder();
+ StringBuilder declarationTrueNames = new StringBuilder();
+ for (String name: variables) {
+ String nameAlias = ELReference.getAlias(pathAliases, name);
if(checkDeclaration(path, name)) {
- declarationTruePaths.append(pathAlias).append(";");
+ declarationTrueNames.append(nameAlias).append(";");
} else {
- declarationFalsePaths.append(pathAlias).append(";");
+ declarationFalseNames.append(nameAlias).append(";");
}
}
- if(declarationFalsePaths.length() > 0) {
+ if(declarationFalseNames.length() > 0) {
Element linkedResource = XMLUtilities.createElement(root, "linked-resource"); //$NON-NLS-1$
- linkedResource.setAttribute("name", nameAlias); //$NON-NLS-1$
- linkedResource.setAttribute("path", declarationFalsePaths.toString()); //$NON-NLS-1$
+ linkedResource.setAttribute("path", pathAlias); //$NON-NLS-1$
+ linkedResource.setAttribute("name", declarationFalseNames.toString()); //$NON-NLS-1$
}
- if(declarationTruePaths.length() > 0) {
+ if(declarationTrueNames.length() > 0) {
Element linkedResource = XMLUtilities.createElement(root, "linked-resource"); //$NON-NLS-1$
- linkedResource.setAttribute("name", nameAlias); //$NON-NLS-1$
- linkedResource.setAttribute("path", declarationTruePaths.toString()); //$NON-NLS-1$
+ linkedResource.setAttribute("path", pathAlias); //$NON-NLS-1$
+ linkedResource.setAttribute("name", declarationTrueNames.toString()); //$NON-NLS-1$
linkedResource.setAttribute("declaration", "true"); //$NON-NLS-1$ //$NON-NLS-2$
}
}
@@ -304,17 +317,21 @@
if(root == null) return;
Element[] linkedResources = XMLUtilities.getChildren(root, "linked-resource"); //$NON-NLS-1$
if(linkedResources != null) for (int i = 0; i < linkedResources.length; i++) {
- String name = linkedResources[i].getAttribute("name"); //$NON-NLS-1$
- if(name == null || name.trim().length() == 0) continue;
- name = ELReference.getPath(pathAliases, name);
- String path1 = linkedResources[i].getAttribute("path"); //$NON-NLS-1$
- if(path1 == null || path1.trim().length() == 0) continue;
+ String path = linkedResources[i].getAttribute("path"); //$NON-NLS-1$
+ if(path == null || path.trim().length() == 0) continue;
+ if(path.indexOf(';') > 0) {
+ //support to old format
+ path = path.substring(0, path.indexOf(';'));
+ }
+ path = ELReference.getPath(pathAliases, path);
+ IPath pathObject = new Path(path);
+ String name1 = linkedResources[i].getAttribute("name"); //$NON-NLS-1$
+ if(name1 == null || name1.trim().length() == 0) continue;
String declaration = linkedResources[i].getAttribute("declaration"); //$NON-NLS-1$
boolean declarationFlag = "true".equals(declaration); //$NON-NLS-1$
- String[] paths = path1.split(";");
- for (String path: paths) {
- path = ELReference.getPath(pathAliases, path);
- IPath pathObject = new Path(path);
+ String[] names = name1.split(";");
+ for (String name: names) {
+ name = ELReference.getPath(pathAliases, name);
addLinkedResource(name, pathObject, declarationFlag);
}
}
@@ -352,6 +369,6 @@
}
public boolean isEmpty() {
- return resourcesByVariableName.isEmpty() && variableNamesByResource.isEmpty() && resourcesByDeclaringVariableName.isEmpty() && declaringVariableNamesByResource.isEmpty() && unnamedResources.isEmpty();
+ return (resourcesByVariableName == null || resourcesByVariableName.isEmpty()) && variableNamesByResource.isEmpty() && resourcesByDeclaringVariableName.isEmpty() && declaringVariableNamesByResource.isEmpty() && unnamedResources.isEmpty();
}
}
\ No newline at end of file
Modified: trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/internal/ProjectValidationContext.java
===================================================================
--- trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/internal/ProjectValidationContext.java 2012-09-20 20:21:47 UTC (rev 43880)
+++ trunk/common/plugins/org.jboss.tools.common.validation/src/org/jboss/tools/common/validation/internal/ProjectValidationContext.java 2012-09-20 20:24:43 UTC (rev 43881)
@@ -45,6 +45,9 @@
LinkCollection linkCollection = coreLinks.get(validatorId);
if(linkCollection==null) {
linkCollection = new LinkCollection(validatorId);
+ if(validatorId.equals("jboss.cdi.core")) {
+ linkCollection.disableResourcesByVariableName();
+ }
coreLinks.put(validatorId, linkCollection);
}
return linkCollection;
13 years, 6 months
JBoss Tools SVN: r43879 - in trunk/common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el: internal/core/model and 1 other directory.
by jbosstools-commits＠lists.jboss.org
Author: scabanovich
Date: 2012-09-20 16:21:19 -0400 (Thu, 20 Sep 2012)
New Revision: 43879
Modified:
trunk/common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el/core/ELReference.java
trunk/common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el/internal/core/model/ELObjectImpl.java
Log:
JBIDE-12479
https://issues.jboss.org/browse/JBIDE-12479
Do not keep EL model objects in ELReference.
Modified: trunk/common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el/core/ELReference.java
===================================================================
--- trunk/common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el/core/ELReference.java 2012-09-20 18:15:42 UTC (rev 43878)
+++ trunk/common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el/core/ELReference.java 2012-09-20 20:21:19 UTC (rev 43879)
@@ -10,6 +10,7 @@
******************************************************************************/
package org.jboss.tools.common.el.core;
+import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
@@ -44,10 +45,8 @@
private int length;
private int lineNumber;
private int startPosition;
- private ELExpression[] el;
private Set<IMarker> markers;
private boolean needToInitMarkers = false;
- private List<SyntaxError> syntaxErrors;
private String source;
private String elMarkerGroupID;
@@ -137,8 +136,8 @@
}
public String getSourceText() {
- if(source==null) {
- source = getELModel().getSource();
+ if(source == null) {
+ source = getText();// getELModel().getSource();
}
return source;
}
@@ -157,44 +156,45 @@
*
* @param text
*/
- public void init(String text) {
+ public ELExpression[] init(String text) {
ELParser parser = ELParserUtil.getJbossFactory().createParser();
ELModel model = parser.parse(text);
- setSyntaxErrors(model.getSyntaxErrors());
- setEl(model.getInstances());
+ return setEl(model.getInstances());
}
/**
* @return the el
*/
public ELExpression[] getEl() {
- if(el == null) {
- String text = FileUtil.getContentFromEditorOrFile(resource);
- if(getStartPosition() >= 0 && getLength() >= 0 && text.length() >= getStartPosition() + getLength()) {
- init(text.substring(getStartPosition(), getStartPosition() + getLength()));
+ ELExpression[] el = null;
+ String text = getSourceText();
+ if(text.length() > 0) {
+ el = init(text);
} else {
el = new ELExpression[0];
}
- }
return el;
}
- /**
- * @param el the el to set
- */
- public void setEl(ELExpression[] el) {
- this.el = el;
+ private String getText() {
+ String text = FileUtil.getContentFromEditorOrFile(resource);
+ if(getStartPosition() >= 0 && getLength() >= 0 && text.length() >= getStartPosition() + getLength()) {
+ return source = "" + text.substring(getStartPosition(), getStartPosition() + getLength());
+ } else {
+ return source = "";
+ }
+
}
/**
* @param insts
*/
- public void setEl(List<ELInstance> insts) {
+ public ELExpression[] setEl(List<ELInstance> insts) {
Set<ELExpression> exps = new HashSet<ELExpression>();
for (ELInstance el : insts) {
exps.add(el.getExpression());
}
- el = exps.toArray(new ELExpression[0]);
+ return exps.toArray(new ELExpression[0]);
}
private static final IMarker[] EMPTY_MARKER_ARRAY = new IMarker[0];
@@ -228,15 +228,13 @@
* @return the syntaxErrors
*/
public List<SyntaxError> getSyntaxErrors() {
- return syntaxErrors;
+ ELParser parser = ELParserUtil.getJbossFactory().createParser();
+ String text = getSourceText();
+ if(text.length() == 0) return Collections.emptyList();
+ ELModel model = parser.parse(text);
+ return model.getSyntaxErrors();
}
- /**
- * @param syntaxErrors the syntaxErrors to set
- */
- public void setSyntaxErrors(List<SyntaxError> syntaxErrors) {
- this.syntaxErrors = syntaxErrors;
- }
public String getMarkerGroupId() {
return this.elMarkerGroupID;
Modified: trunk/common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el/internal/core/model/ELObjectImpl.java
===================================================================
--- trunk/common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el/internal/core/model/ELObjectImpl.java 2012-09-20 18:15:42 UTC (rev 43878)
+++ trunk/common/plugins/org.jboss.tools.common.el.core/src/org/jboss/tools/common/el/internal/core/model/ELObjectImpl.java 2012-09-20 20:21:19 UTC (rev 43879)
@@ -11,6 +11,7 @@
package org.jboss.tools.common.el.internal.core.model;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.List;
import org.jboss.tools.common.el.core.model.ELObject;
@@ -25,7 +26,7 @@
protected LexicalToken firstToken;
protected LexicalToken lastToken;
protected ELObjectImpl parent;
- protected List<ELObject> children = new ArrayList<ELObject>();
+ protected List<ELObject> children = null;
public ELObjectImpl() {
}
@@ -58,9 +59,11 @@
public ELObjectImpl getParent() {
return parent;
}
+
+ static List<ELObject> empty = Collections.emptyList();
public List<ELObject> getChildren() {
- return children;
+ return children == null ? empty : children;
}
public LexicalToken getFirstToken() {
@@ -76,12 +79,15 @@
}
public void addChild(ELObjectImpl child) {
+ if(children == null) {
+ children = new ArrayList<ELObject>(1);
+ }
children.add(child);
child.setParent(this);
}
protected void removeChild(ELObjectImpl child) {
- if(children.contains(child)) {
+ if(children != null && children.contains(child)) {
children.remove(child);
child.setParent(null);
}
13 years, 6 months
JBoss Tools SVN: r43878 - in trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui: wizard and 1 other directory.
by jbosstools-commits＠lists.jboss.org
Author: adietish
Date: 2012-09-20 14:15:42 -0400 (Thu, 20 Sep 2012)
New Revision: 43878
Added:
trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/utils/LinkSelectionAdapter.java
Modified:
trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java
Log:
[JBIDE-11912] corrected error text and link text. merged the 2 texts with links to a single one
Added: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/utils/LinkSelectionAdapter.java
===================================================================
--- trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/utils/LinkSelectionAdapter.java (rev 0)
+++ trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/utils/LinkSelectionAdapter.java 2012-09-20 18:15:42 UTC (rev 43878)
@@ -0,0 +1,40 @@
+/*******************************************************************************
+ * Copyright (c) 2012 Red Hat, Inc.
+ * Distributed under license by Red Hat, Inc. All rights reserved.
+ * This program is made available under the terms of the
+ * Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ * Red Hat Incorporated - initial API and implementation
+ ******************************************************************************/
+package org.jboss.tools.openshift.express.internal.ui.utils;
+
+import org.eclipse.core.runtime.Assert;
+import org.eclipse.swt.events.SelectionAdapter;
+import org.eclipse.swt.events.SelectionEvent;
+
+/**
+ * @author Andre Dietisheim
+ */
+public abstract class LinkSelectionAdapter extends SelectionAdapter {
+
+ private String text;
+
+ public LinkSelectionAdapter(String text) {
+ Assert.isLegal(text != null
+ && !text.isEmpty());
+ this.text = text;
+ }
+
+ @Override
+ public final void widgetSelected(SelectionEvent e) {
+ if (text.equals(e.text)) {
+ doWidgetSelected(e);
+ }
+ }
+
+ protected abstract void doWidgetSelected(SelectionEvent e);
+
+
+}
Property changes on: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/utils/LinkSelectionAdapter.java
___________________________________________________________________
Added: svn:mime-type
+ text/plain
Modified: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java
===================================================================
--- trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java 2012-09-20 17:54:44 UTC (rev 43877)
+++ trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java 2012-09-20 18:15:42 UTC (rev 43878)
@@ -56,6 +56,7 @@
import org.jboss.tools.openshift.express.internal.ui.OpenShiftUIActivator;
import org.jboss.tools.openshift.express.internal.ui.job.LoadKeysJob;
import org.jboss.tools.openshift.express.internal.ui.utils.JobChainBuilder;
+import org.jboss.tools.openshift.express.internal.ui.utils.LinkSelectionAdapter;
import org.jboss.tools.openshift.express.internal.ui.utils.StringUtils;
import org.jboss.tools.openshift.express.internal.ui.utils.UIUtils;
import org.jboss.tools.openshift.express.internal.ui.wizard.ssh.ManageSSHKeysWizard;
@@ -190,23 +191,16 @@
dbc.addValidationStatusProvider(
new RemoteNameValidationStatusProvider(remoteNameTextObservable, projectNameModelObservable));
- Link sshPrefsLink = new Link(parent, SWT.NONE);
- sshPrefsLink.setText("Make sure your SSH key used with your user " + wizardModel.getUser().getUsername()
- + "\nis listed in <a>SSH2 Preferences</a>.");
+ Link sshLink = new Link(parent, SWT.NONE);
+ sshLink.setText("Make sure that you have SSH keys added to your OpenShift account " + wizardModel.getUser().getUsername() +"\n"
+ + "via <a>SSH Keys wizard</a> and that the private keys are listed in <a>SSH2 Preferences</a>");
GridDataFactory.fillDefaults()
- .align(SWT.FILL, SWT.CENTER).grab(true, false).indent(10, 0).applyTo(sshPrefsLink);
- sshPrefsLink.addSelectionListener(onSshPrefs());
-
- Link sshManagementLink = new Link(parent, SWT.NONE);
- sshManagementLink.setText(
- "Please make sure that you have SSH keys added to your OpenShift account.\n" +
- "You may check them in the <a>SSH2 keys wizard</a>.");
- GridDataFactory.fillDefaults()
- .align(SWT.FILL, SWT.CENTER).grab(true, false).indent(10,0).applyTo(sshManagementLink);
- sshManagementLink.addSelectionListener(onManageSSHKeys());
-
+ .align(SWT.FILL, SWT.CENTER).grab(true, false).indent(10, 0).applyTo(sshLink);
+ sshLink.addSelectionListener(onSshPrefs("SSH2 Preferences"));
+ sshLink.addSelectionListener(onManageSSHKeys("SSH Keys wizard"));
+
ValueBindingBuilder
- .bind(WidgetProperties.text().observe(sshManagementLink))
+ .bind(WidgetProperties.text().observe(sshLink))
.notUpdating(BeanProperties.value(
GitCloningSettingsWizardPageModel.PROPERTY_HAS_REMOTEKEYS).observe(pageModel))
.withStrategy(new UpdateValueStrategy(UpdateValueStrategy.POLICY_CONVERT))
@@ -222,7 +216,7 @@
return ValidationStatus.ok();
} else {
return ValidationStatus
- .error("You have not added any SSH public keys to OpenShift yet. Please use the SSH2 keys wizard.");
+ .error("No public keys found in your account. Please use the SSH keys wizard.");
}
}
})
@@ -257,16 +251,30 @@
};
}
- private SelectionAdapter onSshPrefs() {
- return new SelectionAdapter() {
+ private SelectionAdapter onSshPrefs(String text) {
+ return new LinkSelectionAdapter(text) {
@Override
- public void widgetSelected(SelectionEvent e) {
+ public void doWidgetSelected(SelectionEvent e) {
SshPrivateKeysPreferences.openPreferencesPage(getShell());
}
};
}
+ private SelectionAdapter onManageSSHKeys(String text) {
+ return new LinkSelectionAdapter(text) {
+
+ @Override
+ public void doWidgetSelected(SelectionEvent e) {
+ WizardDialog manageSSHKeysWizard =
+ new OkButtonWizardDialog(getShell(), new ManageSSHKeysWizard(wizardModel.getUser()));
+ if (manageSSHKeysWizard.open() == Dialog.OK) {
+ refreshHasRemoteKeys();
+ }
+ }
+ };
+ }
+
protected void onPageActivated(DataBindingContext dbc) {
enableWidgets(pageModel.isNewProject());
repoPathValidator.forceRevalidate();
@@ -425,19 +433,4 @@
}
}
}
-
- private SelectionAdapter onManageSSHKeys() {
- return new SelectionAdapter() {
-
- @Override
- public void widgetSelected(SelectionEvent e) {
- WizardDialog manageSSHKeysWizard =
- new OkButtonWizardDialog(getShell(), new ManageSSHKeysWizard(wizardModel.getUser()));
- if (manageSSHKeysWizard.open() == Dialog.OK) {
- refreshHasRemoteKeys();
- }
- }
- };
- }
-
}
13 years, 6 months
JBoss Tools SVN: r43877 - trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard.
by jbosstools-commits＠lists.jboss.org
Author: adietish
Date: 2012-09-20 13:54:44 -0400 (Thu, 20 Sep 2012)
New Revision: 43877
Modified:
trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java
Log:
[JBIDE-11912] corrected typo
Modified: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java
===================================================================
--- trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java 2012-09-20 17:52:21 UTC (rev 43876)
+++ trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java 2012-09-20 17:54:44 UTC (rev 43877)
@@ -200,7 +200,7 @@
Link sshManagementLink = new Link(parent, SWT.NONE);
sshManagementLink.setText(
"Please make sure that you have SSH keys added to your OpenShift account.\n" +
- "You may check them in the <a>SSH2 keys wizard</a>");
+ "You may check them in the <a>SSH2 keys wizard</a>.");
GridDataFactory.fillDefaults()
.align(SWT.FILL, SWT.CENTER).grab(true, false).indent(10,0).applyTo(sshManagementLink);
sshManagementLink.addSelectionListener(onManageSSHKeys());
13 years, 6 months
JBoss Tools SVN: r43876 - in trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui: wizard and 1 other directories.
by jbosstools-commits＠lists.jboss.org
Author: adietish
Date: 2012-09-20 13:52:21 -0400 (Thu, 20 Sep 2012)
New Revision: 43876
Added:
trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/job/LoadKeysJob.java
Modified:
trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/job/VerifySSHSessionJob.java
trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java
trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPageModel.java
trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/NewDomainWizardPage.java
trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/ssh/ManageSSHKeysWizardPage.java
Log:
[JBIDE-11912] add link to "ssh2 keys management" in "git clonging settings" wizard page. Added validation in "git cloning settings" wizard page that would error if user has no keys on OpenShift
Added: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/job/LoadKeysJob.java
===================================================================
--- trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/job/LoadKeysJob.java (rev 0)
+++ trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/job/LoadKeysJob.java 2012-09-20 17:52:21 UTC (rev 43876)
@@ -0,0 +1,45 @@
+/*******************************************************************************
+ * Copyright (c) 2012 Red Hat, Inc.
+ * Distributed under license by Red Hat, Inc. All rights reserved.
+ * This program is made available under the terms of the
+ * Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ * Red Hat, Inc. - initial API and implementation
+ ******************************************************************************/
+package org.jboss.tools.openshift.express.internal.ui.job;
+
+import java.util.List;
+
+import org.eclipse.core.runtime.IProgressMonitor;
+import org.eclipse.core.runtime.IStatus;
+import org.eclipse.core.runtime.Status;
+import org.eclipse.core.runtime.jobs.Job;
+import org.jboss.tools.openshift.express.internal.core.console.UserDelegate;
+
+import com.openshift.client.IOpenShiftSSHKey;
+
+/**
+ * @author Andre Dietisheim
+ */
+public class LoadKeysJob extends Job {
+
+ private UserDelegate user;
+ private List<IOpenShiftSSHKey> keys;
+
+ public LoadKeysJob(UserDelegate user) {
+ super("Loading SSH keys... ");
+ this.user = user;
+ }
+
+ @Override
+ protected IStatus run(IProgressMonitor monitor) {
+ this.keys = user.getSSHKeys();
+ return Status.OK_STATUS;
+ }
+
+ public List<IOpenShiftSSHKey> getKeys() {
+ return keys;
+ }
+}
Property changes on: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/job/LoadKeysJob.java
___________________________________________________________________
Added: svn:mime-type
+ text/plain
Modified: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/job/VerifySSHSessionJob.java
===================================================================
--- trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/job/VerifySSHSessionJob.java 2012-09-20 17:20:08 UTC (rev 43875)
+++ trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/job/VerifySSHSessionJob.java 2012-09-20 17:52:21 UTC (rev 43876)
@@ -14,12 +14,10 @@
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Status;
import org.eclipse.core.runtime.jobs.Job;
-import org.eclipse.osgi.util.NLS;
import org.jboss.tools.openshift.express.internal.ui.OpenShiftUIActivator;
import org.jboss.tools.openshift.express.internal.ui.utils.Logger;
import org.jboss.tools.openshift.express.internal.ui.utils.OpenShiftSshSessionFactory;
-import com.jcraft.jsch.JSchException;
import com.jcraft.jsch.Session;
import com.openshift.client.IApplication;
import com.openshift.client.OpenShiftSSHOperationException;
Modified: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java
===================================================================
--- trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java 2012-09-20 17:20:08 UTC (rev 43875)
+++ trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPage.java 2012-09-20 17:52:21 UTC (rev 43876)
@@ -11,22 +11,27 @@
package org.jboss.tools.openshift.express.internal.ui.wizard;
import org.eclipse.core.databinding.DataBindingContext;
+import org.eclipse.core.databinding.UpdateValueStrategy;
import org.eclipse.core.databinding.beans.BeanProperties;
import org.eclipse.core.databinding.observable.value.IObservableValue;
+import org.eclipse.core.databinding.validation.IValidator;
import org.eclipse.core.databinding.validation.MultiValidator;
import org.eclipse.core.databinding.validation.ValidationStatus;
import org.eclipse.core.resources.IProject;
import org.eclipse.core.resources.ResourcesPlugin;
import org.eclipse.core.runtime.IPath;
+import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Path;
import org.eclipse.core.runtime.Status;
import org.eclipse.jface.databinding.fieldassist.ControlDecorationSupport;
import org.eclipse.jface.databinding.swt.WidgetProperties;
+import org.eclipse.jface.dialogs.Dialog;
import org.eclipse.jface.dialogs.PageChangingEvent;
import org.eclipse.jface.layout.GridDataFactory;
import org.eclipse.jface.layout.GridLayoutFactory;
import org.eclipse.jface.wizard.IWizardPage;
+import org.eclipse.jface.wizard.WizardDialog;
import org.eclipse.jgit.lib.Repository;
import org.eclipse.osgi.util.NLS;
import org.eclipse.swt.SWT;
@@ -41,13 +46,19 @@
import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Link;
import org.eclipse.swt.widgets.Text;
+import org.eclipse.ui.progress.UIJob;
+import org.eclipse.ui.statushandlers.StatusManager;
+import org.jboss.tools.common.ui.WizardUtils;
import org.jboss.tools.common.ui.databinding.InvertingBooleanConverter;
import org.jboss.tools.common.ui.databinding.ValueBindingBuilder;
import org.jboss.tools.common.ui.ssh.SshPrivateKeysPreferences;
import org.jboss.tools.openshift.egit.core.EGitUtils;
import org.jboss.tools.openshift.express.internal.ui.OpenShiftUIActivator;
+import org.jboss.tools.openshift.express.internal.ui.job.LoadKeysJob;
+import org.jboss.tools.openshift.express.internal.ui.utils.JobChainBuilder;
import org.jboss.tools.openshift.express.internal.ui.utils.StringUtils;
import org.jboss.tools.openshift.express.internal.ui.utils.UIUtils;
+import org.jboss.tools.openshift.express.internal.ui.wizard.ssh.ManageSSHKeysWizard;
/**
* @author Andre Dietisheim
@@ -65,7 +76,8 @@
private Label remoteNameLabel;
private RepoPathValidationStatusProvider repoPathValidator;
- public GitCloningSettingsWizardPage(OpenShiftExpressApplicationWizard wizard, IOpenShiftExpressWizardModel wizardModel) {
+ public GitCloningSettingsWizardPage(OpenShiftExpressApplicationWizard wizard,
+ IOpenShiftExpressWizardModel wizardModel) {
super(
"Import an existing OpenShift application",
"Configure the cloning settings by specifying the clone destination if you create a new project, and the git remote name if you're using an existing project.",
@@ -130,8 +142,9 @@
GitCloningSettingsWizardPageModel.PROPERTY_APPLICATION_NAME).observe(pageModel);
final IObservableValue newProjectModelObservable = BeanProperties.value(
GitCloningSettingsWizardPageModel.PROPERTY_NEW_PROJECT).observe(pageModel);
- this.repoPathValidator =
- new RepoPathValidationStatusProvider(repoPathObservable, applicationNameModelObservable, newProjectModelObservable);
+ this.repoPathValidator =
+ new RepoPathValidationStatusProvider(repoPathObservable, applicationNameModelObservable,
+ newProjectModelObservable);
dbc.addValidationStatusProvider(repoPathValidator);
ControlDecorationSupport.create(repoPathValidator, SWT.LEFT | SWT.TOP);
@@ -178,11 +191,43 @@
new RemoteNameValidationStatusProvider(remoteNameTextObservable, projectNameModelObservable));
Link sshPrefsLink = new Link(parent, SWT.NONE);
- sshPrefsLink.setText("Make sure your SSH key used with your user " + wizardModel.getUser().getUsername() + "\nis listed in <a>SSH2 Preferences</a>.");
- GridDataFactory.fillDefaults().align(SWT.FILL, SWT.CENTER).grab(true, false).indent(10, 0)
- .applyTo(sshPrefsLink);
+ sshPrefsLink.setText("Make sure your SSH key used with your user " + wizardModel.getUser().getUsername()
+ + "\nis listed in <a>SSH2 Preferences</a>.");
+ GridDataFactory.fillDefaults()
+ .align(SWT.FILL, SWT.CENTER).grab(true, false).indent(10, 0).applyTo(sshPrefsLink);
sshPrefsLink.addSelectionListener(onSshPrefs());
+ Link sshManagementLink = new Link(parent, SWT.NONE);
+ sshManagementLink.setText(
+ "Please make sure that you have SSH keys added to your OpenShift account.\n" +
+ "You may check them in the <a>SSH2 keys wizard</a>");
+ GridDataFactory.fillDefaults()
+ .align(SWT.FILL, SWT.CENTER).grab(true, false).indent(10,0).applyTo(sshManagementLink);
+ sshManagementLink.addSelectionListener(onManageSSHKeys());
+
+ ValueBindingBuilder
+ .bind(WidgetProperties.text().observe(sshManagementLink))
+ .notUpdating(BeanProperties.value(
+ GitCloningSettingsWizardPageModel.PROPERTY_HAS_REMOTEKEYS).observe(pageModel))
+ .withStrategy(new UpdateValueStrategy(UpdateValueStrategy.POLICY_CONVERT))
+ .validatingAfterGet(new IValidator() {
+
+ @Override
+ public IStatus validate(Object value) {
+ if (!(value instanceof Boolean)) {
+ return ValidationStatus.ok();
+ }
+ Boolean hasRemoteKeys = (Boolean) value;
+ if (hasRemoteKeys) {
+ return ValidationStatus.ok();
+ } else {
+ return ValidationStatus
+ .error("You have not added any SSH public keys to OpenShift yet. Please use the SSH2 keys wizard.");
+ }
+ }
+ })
+ .in(dbc);
+ refreshHasRemoteKeys();
return cloneGroup;
}
@@ -203,7 +248,7 @@
DirectoryDialog dialog = new DirectoryDialog(getShell());
dialog.setText("Git clone location");
dialog.setMessage("Choose the location for git clone...");
- dialog.setFilterPath(pageModel.getRepositoryPath());
+ dialog.setFilterPath(pageModel.getRepositoryPath());
String repositoryPath = dialog.open();
if (repositoryPath != null) {
pageModel.setRepositoryPath(repositoryPath);
@@ -225,8 +270,27 @@
protected void onPageActivated(DataBindingContext dbc) {
enableWidgets(pageModel.isNewProject());
repoPathValidator.forceRevalidate();
+ refreshHasRemoteKeys();
}
+ private void refreshHasRemoteKeys() {
+ try {
+ final LoadKeysJob loadKeysJob = new LoadKeysJob(wizardModel.getUser());
+ new JobChainBuilder(loadKeysJob).andRunWhenDone(new UIJob("") {
+
+ @Override
+ public IStatus runInUIThread(IProgressMonitor monitor) {
+ pageModel.setHasRemoteKeys(loadKeysJob.getKeys().size() > 0);
+ return Status.OK_STATUS;
+ }
+ });
+ WizardUtils.runInWizard(loadKeysJob, getContainer());
+ } catch (Exception e) {
+ StatusManager.getManager().handle(
+ OpenShiftUIActivator.createErrorStatus("Could not load ssh keys.", e), StatusManager.LOG);
+ }
+ }
+
@Override
protected void onPageWillGetActivated(Direction direction, PageChangingEvent event, DataBindingContext dbc) {
if (direction == Direction.FORWARDS) {
@@ -234,7 +298,7 @@
dbc.updateTargets();
}
}
-
+
private void enableWidgets(boolean isNewProject) {
if (isNewProject) {
useDefaultRepoPathButton.setEnabled(true);
@@ -296,7 +360,7 @@
public void forceRevalidate() {
revalidate();
}
-
+
}
/**
@@ -308,7 +372,8 @@
private final IObservableValue remoteNameObservable;
private final IObservableValue projectNameObservable;
- public RemoteNameValidationStatusProvider(final IObservableValue remoteNameTextObservable, final IObservableValue projectNameObservable) {
+ public RemoteNameValidationStatusProvider(final IObservableValue remoteNameTextObservable,
+ final IObservableValue projectNameObservable) {
this.remoteNameObservable = remoteNameTextObservable;
this.projectNameObservable = projectNameObservable;
}
@@ -341,7 +406,7 @@
}
return ResourcesPlugin.getWorkspace().getRoot().getProject(projectName);
}
-
+
private boolean hasRemoteName(String remoteName, IProject project) {
try {
if (project == null
@@ -361,4 +426,18 @@
}
}
+ private SelectionAdapter onManageSSHKeys() {
+ return new SelectionAdapter() {
+
+ @Override
+ public void widgetSelected(SelectionEvent e) {
+ WizardDialog manageSSHKeysWizard =
+ new OkButtonWizardDialog(getShell(), new ManageSSHKeysWizard(wizardModel.getUser()));
+ if (manageSSHKeysWizard.open() == Dialog.OK) {
+ refreshHasRemoteKeys();
+ }
+ }
+ };
+ }
+
}
Modified: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPageModel.java
===================================================================
--- trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPageModel.java 2012-09-20 17:20:08 UTC (rev 43875)
+++ trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/GitCloningSettingsWizardPageModel.java 2012-09-20 17:52:21 UTC (rev 43876)
@@ -36,10 +36,12 @@
public static final String PROPERTY_REMOTE_NAME = "remoteName";
public static final String PROPERTY_USE_DEFAULT_REPO_PATH = "useDefaultRepoPath";
public static final String PROPERTY_USE_DEFAULT_REMOTE_NAME = "useDefaultRemoteName";
+ public static final String PROPERTY_HAS_REMOTEKEYS = "hasRemoteKeys";
private IOpenShiftExpressWizardModel wizardModel;
private boolean useDefaultRepoPath = true;
private boolean useDefaultRemoteName = true;
+ private boolean hasRemoteKeys;
public GitCloningSettingsWizardPageModel(IOpenShiftExpressWizardModel wizardModel) {
this.wizardModel = wizardModel;
@@ -174,6 +176,14 @@
return useDefaultRemoteName;
}
+ public boolean getHasRemoteKeys() {
+ return hasRemoteKeys;
+ }
+
+ public void setHasRemoteKeys(boolean hasRemoteKeys) {
+ firePropertyChange(PROPERTY_HAS_REMOTEKEYS, this.hasRemoteKeys, this.hasRemoteKeys = hasRemoteKeys);
+ }
+
public void reset() {
setRemoteName(wizardModel.getRemoteName());
setRepositoryPath(wizardModel.getRepositoryPath());
Modified: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/NewDomainWizardPage.java
===================================================================
--- trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/NewDomainWizardPage.java 2012-09-20 17:20:08 UTC (rev 43875)
+++ trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/NewDomainWizardPage.java 2012-09-20 17:52:21 UTC (rev 43876)
@@ -70,13 +70,13 @@
ValueBindingBuilder.bind(namespaceTextObservable).to(namespaceModelObservable).in(dbc);
new Label(container, SWT.NONE); // spacer
- Link sshPrefsLink = new Link(container, SWT.NONE);
- sshPrefsLink.setText(
+ Link sshManagementLink = new Link(container, SWT.NONE);
+ sshManagementLink.setText(
"Please make sure that you have SSH keys added to your OpenShift account.\n" +
"You may check them in the <a>SSH2 keys wizard</a>");
GridDataFactory.fillDefaults()
- .span(3, 1).align(SWT.FILL, SWT.CENTER).applyTo(sshPrefsLink);
- sshPrefsLink.addSelectionListener(onManageSSHKeys());
+ .span(3, 1).align(SWT.FILL, SWT.CENTER).applyTo(sshManagementLink);
+ sshManagementLink.addSelectionListener(onManageSSHKeys());
}
private SelectionAdapter onManageSSHKeys() {
Modified: trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/ssh/ManageSSHKeysWizardPage.java
===================================================================
--- trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/ssh/ManageSSHKeysWizardPage.java 2012-09-20 17:20:08 UTC (rev 43875)
+++ trunk/openshift/plugins/org.jboss.tools.openshift.express.ui/src/org/jboss/tools/openshift/express/internal/ui/wizard/ssh/ManageSSHKeysWizardPage.java 2012-09-20 17:52:21 UTC (rev 43876)
@@ -43,6 +43,7 @@
import org.jboss.tools.common.ui.databinding.ValueBindingBuilder;
import org.jboss.tools.openshift.express.internal.core.console.UserDelegate;
import org.jboss.tools.openshift.express.internal.ui.OpenShiftUIActivator;
+import org.jboss.tools.openshift.express.internal.ui.job.LoadKeysJob;
import org.jboss.tools.openshift.express.internal.ui.utils.JobChainBuilder;
import org.jboss.tools.openshift.express.internal.ui.utils.SSHUtils;
import org.jboss.tools.openshift.express.internal.ui.utils.StringUtils;
@@ -243,7 +244,7 @@
@Override
protected void onPageActivated(DataBindingContext dbc) {
try {
- Job loadKeysJob = new LoadKeysJob();
+ Job loadKeysJob = new LoadKeysJob(pageModel.getUser());
new JobChainBuilder(loadKeysJob).andRunWhenDone(new RefreshViewerJob());
WizardUtils.runInWizard(loadKeysJob, getContainer());
} catch (Exception e) {
@@ -306,19 +307,6 @@
}
}
- private class LoadKeysJob extends Job {
-
- private LoadKeysJob() {
- super("Loading SSH keys... ");
- }
-
- @Override
- protected IStatus run(IProgressMonitor monitor) {
- pageModel.loadSSHKeys();
- return Status.OK_STATUS;
- }
- }
-
private class RefreshViewerJob extends UIJob {
public RefreshViewerJob() {
13 years, 6 months
JBoss Tools SVN: r43872 - trunk/build.
by jbosstools-commits＠lists.jboss.org
Author: nickboldt
Date: 2012-09-20 13:18:24 -0400 (Thu, 20 Sep 2012)
New Revision: 43872
Removed:
trunk/build/component/
Log:
purge empty folder
13 years, 6 months
JBoss Tools SVN: r43871 - trunk/build/results.
by jbosstools-commits＠lists.jboss.org
Author: nickboldt
Date: 2012-09-20 13:17:58 -0400 (Thu, 20 Sep 2012)
New Revision: 43871
Removed:
trunk/build/results/surefire-reports/
Log:
purge empty folder
13 years, 6 months