November 2009 - jbossts-issues - Jboss List Archives

[JBoss JIRA] Created: (JBTM-641) com.arjuna.common.util.logging.LogFactory#loadFactory does not handle properly null argument

by Jacques-Olivier Goussard (JIRA)

com.arjuna.common.util.logging.LogFactory#loadFactory does not handle properly null argument -------------------------------------------------------------------------------------------- Key: JBTM-641 URL: https://jira.jboss.org/jira/browse/JBTM-641 Project: JBoss Transaction Manager Issue Type: Bug Security Level: Public (Everyone can see) Components: JTS Affects Versions: 4.8.0 Environment: standalone (J2SE) use of jbossts-jta-4.8.0.GA.zip Reporter: Jacques-Olivier Goussard com.arjuna.common.util.logging.LogFactory#setupLogSystem makes calls to com.arjuna.common.util.logging.LogFactory#loadFactory("com.arjuna.common.internal.util.logging.jakarta.JakartaLogFactory", null) when the jakarta log system is selected. When the logger class name argument is nullm the loadfactory will try to instanciate the "com.arjuna.common.internal.util.logging.jakarta.JakartaLogFactory" class with a no-arg constructor and this class does NOT have a no-arg ctor. private static LogFactoryInterface loadFactory(String classname, String arg) throws LogConfigurationException { try { Class factoryClass = Thread.currentThread().getContextClassLoader().loadClass(classname); LogFactoryInterface logFactoryInterface = null; if(arg == null) { // THIS WILL FAIL AS "com.arjuna.common.internal.util.logging.jakarta.JakartaLogFactory" AS NO SUCH CTOR logFactoryInterface = (LogFactoryInterface)factoryClass.newInstance(); } else { Constructor ctor = factoryClass.getConstructor(new Class[] { String.class}); logFactoryInterface = (LogFactoryInterface)ctor.newInstance(arg); } return logFactoryInterface; } catch (Exception e) { throw new LogConfigurationException(e); } } Proposed fix: The fix is to simply always forward the argument to the String arg ctor - with a null arg, the JakartaLogFactory will properly use the default logger from commons.logging private static LogFactoryInterface loadFactory(String classname, String arg) throws LogConfigurationException { try { Class factoryClass = Thread.currentThread().getContextClassLoader().loadClass(classname); LogFactoryInterface logFactoryInterface = null; Constructor ctor = factoryClass.getConstructor(new Class[] { String.class}); logFactoryInterface = (LogFactoryInterface)ctor.newInstance(arg); return logFactoryInterface; } catch (Exception e) { throw new LogConfigurationException(e); } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years

2
6
0 / 0

[JBoss JIRA] Created: (JBTM-637) remove obsolete JDBC code

by Jonathan Halliday (JIRA)

remove obsolete JDBC code ------------------------- Key: JBTM-637 URL: https://jira.jboss.org/jira/browse/JBTM-637 Project: JBoss Transaction Manager Issue Type: Task Security Level: Public (Everyone can see) Components: JTA Affects Versions: 4.8.0 Reporter: Jonathan Halliday Assignee: Jonathan Halliday Fix For: 4.9.0 The JDBC module contains much deprecated code, mainly plugins to work around issues in 3rd party drivers we no longer test or support anyhow. The more recent versions of the drivers are more spec compliant and no longer force us to jump through so many hoops. Remove the obsolete hoop jumping code. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years

1
1
0 / 0

[JBoss JIRA] Created: (JBTM-638) clean up CLF

by Jonathan Halliday (JIRA)

clean up CLF ------------ Key: JBTM-638 URL: https://jira.jboss.org/jira/browse/JBTM-638 Project: JBoss Transaction Manager Issue Type: Task Security Level: Public (Everyone can see) Components: Common Affects Versions: 4.8.0 Reporter: Jonathan Halliday Assignee: Jonathan Halliday Fix For: 4.9.0 CLF is an unnecessarily complex mess. Throw out the unused bits and rework the factory mechanism to make it more flexible (needed for JBTM-595). Cleaning up the API usage (JBTM-612 and other issue) will probably help too. Ensure no runtime dep on commons logging unless it is selected via config. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years

1
1
0 / 0

[JBoss JIRA] Created: (JBTM-612) check use of isDebugEnabled/debugAllowed

by Jonathan Halliday (JIRA)

check use of isDebugEnabled/debugAllowed ---------------------------------------- Key: JBTM-612 URL: https://jira.jboss.org/jira/browse/JBTM-612 Project: JBoss Transaction Manager Issue Type: Task Security Level: Public (Everyone can see) Components: Common Affects Versions: 4.7.0 Reporter: Jonathan Halliday Assignee: Jonathan Halliday Fix For: 4.9 The CLF exposes an rather complex API, in which isDebugEnabled and debugAllowed have different semantics. As pretty much everything is logged, the cost of these methods, and especially the cost of incorrect usage that leads to creating debug messages that just get throw away, is a non-trivial overhead. Both the implementation of these methods and their usage is suspect and needs a review. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years

1
2
0 / 0

[JBoss JIRA] Created: (JBTM-414) atsintegration classes not internationalized

by Mark Little (JIRA)

atsintegration classes not internationalized -------------------------------------------- Key: JBTM-414 URL: https://jira.jboss.org/jira/browse/JBTM-414 Project: JBoss Transaction Manager Issue Type: Task Security Level: Public (Everyone can see) Components: Application Server Integration Affects Versions: 4.4.0.GA Reporter: Mark Little Assignee: Mark Little Fix For: 4.6 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years

2
3
0 / 0

[JBoss JIRA] Created: (JBTM-626) make EnvironmentBean fields volatile

by Jonathan Halliday (JIRA)

make EnvironmentBean fields volatile ------------------------------------ Key: JBTM-626 URL: https://jira.jboss.org/jira/browse/JBTM-626 Project: JBoss Transaction Manager Issue Type: Bug Security Level: Public (Everyone can see) Components: Configuration Affects Versions: 4.8.0 Reporter: Jonathan Halliday Assignee: Jonathan Halliday Fix For: 4.9.0 The EnvironmentBeans are accessed from multiple threads, so fields need to be volatile or stale values may be read, which can cause some wonderfully difficult to debug problems. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years

1
1
0 / 0

[JBoss JIRA] Created: (JBTM-418) ExpiredEntryScanner does not delete old state after move

by Mark Little (JIRA)

ExpiredEntryScanner does not delete old state after move -------------------------------------------------------- Key: JBTM-418 URL: https://jira.jboss.org/jira/browse/JBTM-418 Project: JBoss Transaction Manager Issue Type: Bug Security Level: Public (Everyone can see) Components: Recovery Affects Versions: 4.4.0.GA Reporter: Mark Little Assignee: Mark Little Fix For: 4.5 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years

3
6
0 / 0

[JBoss JIRA] Created: (JBTM-658) The Object Store Browser does not work in JTA mode

by Michael Musgrove (JIRA)

The Object Store Browser does not work in JTA mode -------------------------------------------------- Key: JBTM-658 URL: https://jira.jboss.org/jira/browse/JBTM-658 Project: JBoss Transaction Manager Issue Type: Bug Security Level: Public (Everyone can see) Components: Tooling Affects Versions: 4.6.1 Reporter: Michael Musgrove Assignee: Michael Musgrove Fix For: 4.9.0 The object store browser plugin loads JTS log record viewers when running in JTA mode. The tool should only load JTA viewers when running the JTA version of the TM. In addition the creation time of a transaction is incorrect. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years

1
1
0 / 0

[JBoss JIRA] Created: (JBTM-300) Move stale transaction logs

by Mark Little (JIRA)

Move stale transaction logs --------------------------- Key: JBTM-300 URL: http://jira.jboss.com/jira/browse/JBTM-300 Project: JBoss Transaction Manager Issue Type: Feature Request Security Level: Public (Everyone can see) Components: Transaction Core Reporter: Mark Little Assigned To: Mark Little Priority: Optional We should generalise the ExpiryScanner implementation of TopLevelTransaction in JTS so that logs that cannot be recovered after a set period of time are moved elsewhere for manual intervention. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years

3
6
0 / 0

[JBoss JIRA] Created: (JBTM-656) Remove BOA methods from ORB Portability

by Mark Little (JIRA)

Remove BOA methods from ORB Portability --------------------------------------- Key: JBTM-656 URL: https://jira.jboss.org/jira/browse/JBTM-656 Project: JBoss Transaction Manager Issue Type: Task Security Level: Public (Everyone can see) Components: JTS Affects Versions: 4.8.0 Reporter: Mark Little Assignee: Mark Little Fix For: 4.10.0 No longer needed. Haven't been for years. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years

1
3
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues November 2009