[JBoss JIRA] Created: (JBTM-535) CLONE -make RecoveryManager restartable
by Mauro Molinari (JIRA)
CLONE -make RecoveryManager restartable
---------------------------------------
Key: JBTM-535
URL: https://jira.jboss.org/jira/browse/JBTM-535
Project: JBoss Transaction Manager
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: Application Server Integration, Recovery
Affects Versions: 4.5.0
Reporter: Mauro Molinari
Assignee: Jonathan Halliday
Fix …
[View More]For: 4.6.0
Stopping and restarting the transaction manager inside JBossAS causes problems, because the recovery system does not like to be restarted once it is stopped:
java.lang.IllegalThreadStateException
at java.lang.Thread.start(Thread.java:571)
at com.arjuna.ats.internal.arjuna.recovery.RecoveryManagerImple.start(RecoveryManagerImple.java:236)
at com.arjuna.ats.arjuna.recovery.RecoveryManager.startRecoveryManagerThread(RecoveryManager.java:226)
at com.arjuna.ats.jbossatx.jts.TransactionManagerService.start(TransactionManagerService.java:285)
Options would seem to be disposing the static singleton _recoveryManager in RecoveryManager and recreating it on the next start, effectively causing a new RecoveryManagerImple to be instantiated, or keep the RecoveryManagerImple instance and rework its impl so that the PeriodicRecovery _periodicRecovery is disposed and recreated on restart.
Either one has slightly odd semantics as the PeriodicRecovery is a Thread (which can't be restarted so has to be replaced) and also the object that has the module list and the server socket, so disposal and/or recreation of this state will be needed on restart. Maybe better to rename stop() to dispose() or something similarly final, to indicate the semantics are 'throw this away and start again' rather than giving the impression that stop/start == suspend/resume which is misleading.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[View Less]
15 years, 9 months
[JBoss JIRA] Created: (JBTM-503) Shutdown the ExpiredEntryMonitor when stopping the RecoveryManager
by Mauro Molinari (JIRA)
Shutdown the ExpiredEntryMonitor when stopping the RecoveryManager
------------------------------------------------------------------
Key: JBTM-503
URL: https://jira.jboss.org/jira/browse/JBTM-503
Project: JBoss Transaction Manager
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: Recovery
Affects Versions: 4.5
Environment: Tomcat + Spring + DBCP + JBossJTA
Reporter:…
[View More] Mauro Molinari
When the recovery manager is started, the implementation RecoveryManagerImple starts the ExpiredEntryMonitor.
When you stop the recovery manager, however, the ExpiredEntryMonitor is not shut down.
On line 250 of com.arjuna.ats.internal.arjuna.recovery.RecoveryManagerImple there's the line ExpiredEntryMonitor.shutdown() commented out, with a "TODO why?" comment immediately before.
I don't know exactly what should be the lifecylce of ExpiredEntryMonitor versus that of RecoveryManagerImple, however I think that one of the following should happen:
- ExpiredEntryMonitor is started when RecoveryManagerImple is started (rather than constructed), so that it is shut down when the RecoveryManagerImple is stopped
OTHERWISE
- RecoveryManagerImple provides a way to "dispose" or "disable" it and this includes the shutdown of ExpiredEntryMonitor
OTHERWISE
- it is documented that stopping the recovery manager needs the ExpiredEntryMonitor to be stopped too: however, please consider that com.arjuna.ats.internal.arjuna.recovery.ExpiredEntryMonitor.shutdown() throws a NullPointerException if called while the ExpiredEntryMonitor has not been started before and there is no public method to test if it has been started or not; so if I need to write some code that stops the ExpiredEntryMonitor (without knowing if it has been started or not) I have to write some ugly code like:
{code:java}
try
{
ExpiredEntryMonitor.shutdown();
}
catch(final NullPointerException e)
{
// ExpiredEntryMonitor had not been started
}
{code}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[View Less]
15 years, 9 months
[JBoss JIRA] Created: (JBTM-537) JTS compilation with IBM jdk1.5 fails due to "Failed to copy ... due to MalformedInputException"
by Ivo Studensky (JIRA)
JTS compilation with IBM jdk1.5 fails due to "Failed to copy ... due to MalformedInputException"
------------------------------------------------------------------------------------------------
Key: JBTM-537
URL: https://jira.jboss.org/jira/browse/JBTM-537
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: JTS
Environment: IBM JDK 1.5, Apache Ant 1.6.5, Linux
…
[View More] Reporter: Ivo Studensky
Fix For: 4.6.1
The copying of binary files in combination with filtering failed in case of IBM jdk 1.5.
See the snippet of compilation output:
...
[java] /mnt/hudson_workspace/workspace/jbossts-test-rhel4-ibm15-temp/trunk/ArjunaJTS/build.xml:312: Failed to copy /mnt/hudson_workspace/workspace/jbossts-test-rhel4-ibm15-temp/trunk/ArjunaJTS/services/bin/hpux/wrapper to /mnt/hudson_workspace/workspace/jbossts-test-rhel4-ibm15-temp/trunk/install/services/bin/hpux/wrapper due to sun.io.MalformedInputException
[java] This is normally due to the input file containing invalid
[java] bytes for the character encoding used : UTF8
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[View Less]
15 years, 10 months