[JBoss JIRA] Created: (JBTM-761) Errors in JBossTS JTA documentation
by Mauro Molinari (JIRA)
Errors in JBossTS JTA documentation
-----------------------------------
Key: JBTM-761
URL: https://jira.jboss.org/browse/JBTM-761
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Documentation
Affects Versions: 4.11.0
Reporter: Mauro Molinari
Priority: Minor
While reading the JBossTS JTA documentation, I found the following problems:
Administration Guide:
- page 7: in the "ArjunaTA runtime information" chapter there's a typographic error ("<name>EnvironmentBean classes")
- page 8: in the "Configuring the Recovery Manager" chapter I think that "arjuna.properties" should rather be "jbossts-properties.xml"
Programmers Guide:
- page 8: in the last paragraph there's a repetition: "and contains also contains a mapping of the X/Open XA protocol"
- page 12: in the "Resource enlistment" chapter, second paragraph, there: "See [? missing reference?] for details on how the implementation of the XAResource can affect recovery..."
Moreover, all the chapters are numbered as "Chapter 1".
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 1 month
[JBoss JIRA] Created: (JBTM-758) Errors in documentation: Transaction Core Programmers Guide
by Mauro Molinari (JIRA)
Errors in documentation: Transaction Core Programmers Guide
-----------------------------------------------------------
Key: JBTM-758
URL: https://jira.jboss.org/browse/JBTM-758
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Documentation
Affects Versions: 4.11.0
Reporter: Mauro Molinari
Priority: Minor
I'm going to highlight some errors I found during the reading of the Transaction Core Programmers Guide (TX-PG-5/11/10):
- page 31: when describing LogManager: "The *shared* parameter only has meaning if *ot* is RECOVERABLE"; actually the two parameters are named *objectModel* and *ObjectType* respectively in the caption of the paragraph
- page 36: in the example, I think the line with "A.add(new ShutdownRecord(...)" is not pertinent
- page 64: the last sentence says that the issues described in that paragraph will be addressed in the next section, but the next section is about configuration
- page 65: the second paragraph has some typographic problem (<module>propertyManager, <name>EnvironmentBean)
- page 69: in the second paragraph: "All of the implementations are derived from the ObjectStore interface"; actually, ObjectStore is a class to extend, not an interface to implement
Lastly, an observation about the depiction of finalizers as "destructors": in this guide, the finalize method is considered a destructor. However, in Java it is not actually. Anyway, it's not clear if calling terminate() in the finalize() is mandatory or not. If so, why isn't it called directly in com.arjuna.ats.arjuna.StateManager.finalize()? If not, I have another doubt. In all the examples of user classes (i.e. page 60) the finalize() is implemented as:
public void finalize()
{
super.terminate();
}
However, super.finalize() is not called. Isn't it risky? I mean, in this way the code in com.arjuna.ats.arjuna.StateManager.finalize() is never called... I think the documentation should be more clear on this subject.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 1 month
[JBoss JIRA] Created: (JBTM-314) JDBCStore.getJDBCClass does not work for some JDBC drivers
by Jeremy Stone (JIRA)
JDBCStore.getJDBCClass does not work for some JDBC drivers
----------------------------------------------------------
Key: JBTM-314
URL: http://jira.jboss.com/jira/browse/JBTM-314
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Transaction Core
Reporter: Jeremy Stone
Implementation of com.arjuna.ats.internal.arjuna.objectstore.JDBCStore getJDBCClass(Connection) breaks if JDBC driver DatabaseMetaData getDriverName() is not consistent between driver releases or driver implementations (e.g. SQLServer), and tries to load illegally named classes if first word of reported driver name contains illegal characters (e.g. MySql).
Maybe a pluggable strategy for determination of the class should be used instead.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 1 month
[JBoss JIRA] Created: (JBTM-527) Adding PMD to build system
by Romain PELISSE (JIRA)
Adding PMD to build system
---------------------------
Key: JBTM-527
URL: https://jira.jboss.org/jira/browse/JBTM-527
Project: JBoss Transaction Manager
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: Build System
Affects Versions: future
Reporter: Romain PELISSE
Priority: Trivial
Attachments: adding-pmd-as-qa-tools.patch
I have a small patch that offers an integration of PMD (http://pmd.sourceforge.net/) into the current build system of JBoss Transaction. Obviously, this is not an highly important feature request, having PMD checking java code is just nice to have. Anyway, as your project is not likely to integrate this patch quickly, I also published the result of a PMD run on the current source code:
http://belaran.eu/jbosstm-pmd.html
(this way you can already check what PMD find out without setting up the tool itself)
I integrated PMD into the qa/ directory which seems the most appropriate directory at first glance... An other strategy would have been to define a "pmd" task inside some common build file ( maybe common/build.xml but it does not look like it), and then have each module call for this anttask with the appropriate java source folder... If you fell this approach is better, please let me know, i'll adapt my patch.
All "violation" detected by PMD are not relevant, a pmd report is just a set of hints of something that may be a bad idea or could be improved.
PMD rulesets (what kind of violation is looking for) are defined in the qa/pmd.xml. In this file you can easily include/exclude rules, and you can use it to configure the PMD Eclipse Plugin.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 1 month
[JBoss JIRA] Created: (JBTM-673) Investigate other object store implementations
by Mark Little (JIRA)
Investigate other object store implementations
----------------------------------------------
Key: JBTM-673
URL: https://jira.jboss.org/jira/browse/JBTM-673
Project: JBoss Transaction Manager
Issue Type: Task
Security Level: Public (Everyone can see)
Components: Transaction Core
Reporter: Mark Little
Assignee: Mark Little
Fix For: 4.10.0
"... spin out messaging journal into separate component so we can consume it. Also look at other disk I/O alternatives, basically trying to batch syncs so one is shared by many tx rather than one per tx. Also maybe preliminary investigation of in-memory replication of logs via jgroups."
See related links. Need to re-check performance of transaction log and maybe make it the default implementation.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12 years, 1 month