[JBoss JIRA] (JBTM-1041) IP: A parameter is dead upon entry to a method but overwritten (IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN)
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1041?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson commented on JBTM-1041:
-------------------------------------
I don't think the methods are actually called mind you, maybe delete the methods?
> IP: A parameter is dead upon entry to a method but overwritten (IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN)
> -----------------------------------------------------------------------------------------------------
>
> Key: JBTM-1041
> URL: https://issues.jboss.org/browse/JBTM-1041
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: XTS
> Reporter: Amos Feng
> Assignee: Paul Robinson
> Priority: Minor
> Fix For: 5.0.0.M5
>
>
> 1.XTS/WSCF
> com.arjuna.mwlabs.wscf.model.sagas.arjunacore.ParticipantRecord Line 540
> The parameter toDelete to com.arjuna.mwlabs.wscf.model.sagas.arjunacore.ParticipantRecord.remove(AbstractRecord) is dead upon entry but overwritten
> 2.XTS/WSCF
> com.arjuna.mwlabs.wscf.model.twophase.arjunacore.ParticipantRecord Line 523
> The parameter toDelete to com.arjuna.mwlabs.wscf.model.twophase.arjunacore.ParticipantRecord.remove(AbstractRecord) is dead upon entry but overwritten
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (JBTM-1041) IP: A parameter is dead upon entry to a method but overwritten (IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN)
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1041?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson commented on JBTM-1041:
-------------------------------------
I reviewed the code, it will require the architect to understand whether something was intended to be performed on the AbstractRecord that is passed in sorry.
I could have removed the assignment of null but that would maybe have masked an issue
> IP: A parameter is dead upon entry to a method but overwritten (IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN)
> -----------------------------------------------------------------------------------------------------
>
> Key: JBTM-1041
> URL: https://issues.jboss.org/browse/JBTM-1041
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: XTS
> Reporter: Amos Feng
> Assignee: Paul Robinson
> Priority: Minor
> Fix For: 5.0.0.M5
>
>
> 1.XTS/WSCF
> com.arjuna.mwlabs.wscf.model.sagas.arjunacore.ParticipantRecord Line 540
> The parameter toDelete to com.arjuna.mwlabs.wscf.model.sagas.arjunacore.ParticipantRecord.remove(AbstractRecord) is dead upon entry but overwritten
> 2.XTS/WSCF
> com.arjuna.mwlabs.wscf.model.twophase.arjunacore.ParticipantRecord Line 523
> The parameter toDelete to com.arjuna.mwlabs.wscf.model.twophase.arjunacore.ParticipantRecord.remove(AbstractRecord) is dead upon entry but overwritten
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (JBTM-1041) IP: A parameter is dead upon entry to a method but overwritten (IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN)
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1041?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-1041:
--------------------------------
Assignee: Paul Robinson (was: Tom Jenkinson)
> IP: A parameter is dead upon entry to a method but overwritten (IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN)
> -----------------------------------------------------------------------------------------------------
>
> Key: JBTM-1041
> URL: https://issues.jboss.org/browse/JBTM-1041
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: XTS
> Reporter: Amos Feng
> Assignee: Paul Robinson
> Priority: Minor
> Fix For: 5.0.0.M5
>
>
> 1.XTS/WSCF
> com.arjuna.mwlabs.wscf.model.sagas.arjunacore.ParticipantRecord Line 540
> The parameter toDelete to com.arjuna.mwlabs.wscf.model.sagas.arjunacore.ParticipantRecord.remove(AbstractRecord) is dead upon entry but overwritten
> 2.XTS/WSCF
> com.arjuna.mwlabs.wscf.model.twophase.arjunacore.ParticipantRecord Line 523
> The parameter toDelete to com.arjuna.mwlabs.wscf.model.twophase.arjunacore.ParticipantRecord.remove(AbstractRecord) is dead upon entry but overwritten
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (JBTM-1036) NP: Possible null pointer dereference (NP_NULL_ON_SOME_PATH)
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1036?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson resolved JBTM-1036.
---------------------------------
Resolution: Partially Completed
Will leave the JDBC and HashedStore for now as current statemachine should provide enough protection
> NP: Possible null pointer dereference (NP_NULL_ON_SOME_PATH)
> ------------------------------------------------------------
>
> Key: JBTM-1036
> URL: https://issues.jboss.org/browse/JBTM-1036
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: JTA, JTS, Transaction Core
> Reporter: Amos Feng
> Assignee: Tom Jenkinson
> Priority: Minor
> Fix For: 5.0.0.M5
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> 1.ArjunaJTA/jdbc
> Possible null pointer dereference of conn in com.arjuna.ats.internal.jdbc.recovery.BasicXARecovery.getXAResource() Line 169
> 3.ArjunaCore/arjuna
> com.arjuna.ats.internal.arjuna.objectstore.HashedStore Line 131
> Possible null pointer dereference of aUid in com.arjuna.ats.internal.arjuna.objectstore.HashedStore.allObjUids(String, InputObjectState, int)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (JBTM-1036) NP: Possible null pointer dereference (NP_NULL_ON_SOME_PATH)
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1036?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson commented on JBTM-1036:
-------------------------------------
https://github.com/jbosstm/narayana/pull/442
5.ArjunaJTS/jts
com.arjuna.ats.internal.jts.context.ContextManager Line 553
Possible null pointer dereference of action in com.arjuna.ats.internal.jts.context.ContextManager.pushAction(ControlWrapper)
removed null check as action cannot be null
https://github.com/jbosstm/narayana/pull/443
6.ArjunaJTS/jts
com.arjuna.ats.jts.extensions.AtomicTransaction Line 617
Possible null pointer dereference of AtomicTransaction._theAction in com.arjuna.ats.jts.extensions.AtomicTransaction.equals(Object)
There was an assumption that both ControlWrappers are null or neither, although the statemachine today guarantees that it is possible that in the future the code may use the .equals in an unpredicted manner.
> NP: Possible null pointer dereference (NP_NULL_ON_SOME_PATH)
> ------------------------------------------------------------
>
> Key: JBTM-1036
> URL: https://issues.jboss.org/browse/JBTM-1036
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: JTA, JTS, Transaction Core
> Reporter: Amos Feng
> Assignee: Tom Jenkinson
> Priority: Minor
> Fix For: 5.0.0.M5
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> 1.ArjunaJTA/jdbc
> Possible null pointer dereference of conn in com.arjuna.ats.internal.jdbc.recovery.BasicXARecovery.getXAResource() Line 169
> 3.ArjunaCore/arjuna
> com.arjuna.ats.internal.arjuna.objectstore.HashedStore Line 131
> Possible null pointer dereference of aUid in com.arjuna.ats.internal.arjuna.objectstore.HashedStore.allObjUids(String, InputObjectState, int)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (JBTM-1036) NP: Possible null pointer dereference (NP_NULL_ON_SOME_PATH)
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1036?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson commented on JBTM-1036:
-------------------------------------
{quote}
1.ArjunaJTA/jdbc
Possible null pointer dereference of conn in com.arjuna.ats.internal.jdbc.recovery.BasicXARecovery.getXAResource() Line 169
{quote}
This is community code
This can happy if the user has not set a user name for their JDBC connection
{quote}
3.ArjunaCore/arjuna
com.arjuna.ats.internal.arjuna.objectstore.HashedStore Line 131
Possible null pointer dereference of aUid in com.arjuna.ats.internal.arjuna.objectstore.HashedStore.allObjUids(String, InputObjectState, int)
{quote}
community code, if the uid is in the cache it looks like you get an NPE?
> NP: Possible null pointer dereference (NP_NULL_ON_SOME_PATH)
> ------------------------------------------------------------
>
> Key: JBTM-1036
> URL: https://issues.jboss.org/browse/JBTM-1036
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: JTA, JTS, Transaction Core
> Reporter: Amos Feng
> Assignee: Tom Jenkinson
> Priority: Minor
> Fix For: 5.0.0.M5
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> 1.ArjunaJTA/jdbc
> Possible null pointer dereference of conn in com.arjuna.ats.internal.jdbc.recovery.BasicXARecovery.getXAResource() Line 169
> 3.ArjunaCore/arjuna
> com.arjuna.ats.internal.arjuna.objectstore.HashedStore Line 131
> Possible null pointer dereference of aUid in com.arjuna.ats.internal.arjuna.objectstore.HashedStore.allObjUids(String, InputObjectState, int)
> 5.ArjunaJTS/jts
> com.arjuna.ats.internal.jts.context.ContextManager Line 553
> Possible null pointer dereference of action in com.arjuna.ats.internal.jts.context.ContextManager.pushAction(ControlWrapper)
> 6.ArjunaJTS/jts
> com.arjuna.ats.jts.extensions.AtomicTransaction Line 617
> Possible null pointer dereference of AtomicTransaction._theAction in com.arjuna.ats.jts.extensions.AtomicTransaction.equals(Object)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (JBTM-1036) NP: Possible null pointer dereference (NP_NULL_ON_SOME_PATH)
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1036?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-1036:
--------------------------------
Description:
1.ArjunaJTA/jdbc
Possible null pointer dereference of conn in com.arjuna.ats.internal.jdbc.recovery.BasicXARecovery.getXAResource() Line 169
3.ArjunaCore/arjuna
com.arjuna.ats.internal.arjuna.objectstore.HashedStore Line 131
Possible null pointer dereference of aUid in com.arjuna.ats.internal.arjuna.objectstore.HashedStore.allObjUids(String, InputObjectState, int)
was:
1.ArjunaJTA/jdbc
Possible null pointer dereference of conn in com.arjuna.ats.internal.jdbc.recovery.BasicXARecovery.getXAResource() Line 169
3.ArjunaCore/arjuna
com.arjuna.ats.internal.arjuna.objectstore.HashedStore Line 131
Possible null pointer dereference of aUid in com.arjuna.ats.internal.arjuna.objectstore.HashedStore.allObjUids(String, InputObjectState, int)
5.ArjunaJTS/jts
com.arjuna.ats.internal.jts.context.ContextManager Line 553
Possible null pointer dereference of action in com.arjuna.ats.internal.jts.context.ContextManager.pushAction(ControlWrapper)
6.ArjunaJTS/jts
com.arjuna.ats.jts.extensions.AtomicTransaction Line 617
Possible null pointer dereference of AtomicTransaction._theAction in com.arjuna.ats.jts.extensions.AtomicTransaction.equals(Object)
> NP: Possible null pointer dereference (NP_NULL_ON_SOME_PATH)
> ------------------------------------------------------------
>
> Key: JBTM-1036
> URL: https://issues.jboss.org/browse/JBTM-1036
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: JTA, JTS, Transaction Core
> Reporter: Amos Feng
> Assignee: Tom Jenkinson
> Priority: Minor
> Fix For: 5.0.0.M5
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> 1.ArjunaJTA/jdbc
> Possible null pointer dereference of conn in com.arjuna.ats.internal.jdbc.recovery.BasicXARecovery.getXAResource() Line 169
> 3.ArjunaCore/arjuna
> com.arjuna.ats.internal.arjuna.objectstore.HashedStore Line 131
> Possible null pointer dereference of aUid in com.arjuna.ats.internal.arjuna.objectstore.HashedStore.allObjUids(String, InputObjectState, int)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (JBTM-1036) NP: Possible null pointer dereference (NP_NULL_ON_SOME_PATH)
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1036?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson commented on JBTM-1036:
-------------------------------------
https://github.com/jbosstm/narayana/pull/441
4.ArjunaJTS/jtax
com.arjuna.ats.internal.jta.transaction.jts.subordinate.jca.coordinator.ServerTransaction Line 108
Possible null pointer dereference of ServerTransaction._theXid in com.arjuna.ats.internal.jta.transaction.jts.subordinate.jca.coordinator.ServerTransaction.save_state(OutputObjectState, int)
As mark says, state machine should have stopped that scenario but it looked like it was worth a quick fix in case the class is used in an as yet untested code path
> NP: Possible null pointer dereference (NP_NULL_ON_SOME_PATH)
> ------------------------------------------------------------
>
> Key: JBTM-1036
> URL: https://issues.jboss.org/browse/JBTM-1036
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: JTA, JTS, Transaction Core
> Reporter: Amos Feng
> Assignee: Tom Jenkinson
> Priority: Minor
> Fix For: 5.0.0.M5
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> 1.ArjunaJTA/jdbc
> Possible null pointer dereference of conn in com.arjuna.ats.internal.jdbc.recovery.BasicXARecovery.getXAResource() Line 169
> 3.ArjunaCore/arjuna
> com.arjuna.ats.internal.arjuna.objectstore.HashedStore Line 131
> Possible null pointer dereference of aUid in com.arjuna.ats.internal.arjuna.objectstore.HashedStore.allObjUids(String, InputObjectState, int)
> 4.ArjunaJTS/jtax
> com.arjuna.ats.internal.jta.transaction.jts.subordinate.jca.coordinator.ServerTransaction Line 108
> Possible null pointer dereference of ServerTransaction._theXid in com.arjuna.ats.internal.jta.transaction.jts.subordinate.jca.coordinator.ServerTransaction.save_state(OutputObjectState, int)
> 5.ArjunaJTS/jts
> com.arjuna.ats.internal.jts.context.ContextManager Line 553
> Possible null pointer dereference of action in com.arjuna.ats.internal.jts.context.ContextManager.pushAction(ControlWrapper)
> 6.ArjunaJTS/jts
> com.arjuna.ats.jts.extensions.AtomicTransaction Line 617
> Possible null pointer dereference of AtomicTransaction._theAction in com.arjuna.ats.jts.extensions.AtomicTransaction.equals(Object)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months
[JBoss JIRA] (JBTM-1036) NP: Possible null pointer dereference (NP_NULL_ON_SOME_PATH)
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1036?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-1036:
--------------------------------
Description:
1.ArjunaJTA/jdbc
Possible null pointer dereference of conn in com.arjuna.ats.internal.jdbc.recovery.BasicXARecovery.getXAResource() Line 169
3.ArjunaCore/arjuna
com.arjuna.ats.internal.arjuna.objectstore.HashedStore Line 131
Possible null pointer dereference of aUid in com.arjuna.ats.internal.arjuna.objectstore.HashedStore.allObjUids(String, InputObjectState, int)
5.ArjunaJTS/jts
com.arjuna.ats.internal.jts.context.ContextManager Line 553
Possible null pointer dereference of action in com.arjuna.ats.internal.jts.context.ContextManager.pushAction(ControlWrapper)
6.ArjunaJTS/jts
com.arjuna.ats.jts.extensions.AtomicTransaction Line 617
Possible null pointer dereference of AtomicTransaction._theAction in com.arjuna.ats.jts.extensions.AtomicTransaction.equals(Object)
was:
1.ArjunaJTA/jdbc
Possible null pointer dereference of conn in com.arjuna.ats.internal.jdbc.recovery.BasicXARecovery.getXAResource() Line 169
3.ArjunaCore/arjuna
com.arjuna.ats.internal.arjuna.objectstore.HashedStore Line 131
Possible null pointer dereference of aUid in com.arjuna.ats.internal.arjuna.objectstore.HashedStore.allObjUids(String, InputObjectState, int)
4.ArjunaJTS/jtax
com.arjuna.ats.internal.jta.transaction.jts.subordinate.jca.coordinator.ServerTransaction Line 108
Possible null pointer dereference of ServerTransaction._theXid in com.arjuna.ats.internal.jta.transaction.jts.subordinate.jca.coordinator.ServerTransaction.save_state(OutputObjectState, int)
5.ArjunaJTS/jts
com.arjuna.ats.internal.jts.context.ContextManager Line 553
Possible null pointer dereference of action in com.arjuna.ats.internal.jts.context.ContextManager.pushAction(ControlWrapper)
6.ArjunaJTS/jts
com.arjuna.ats.jts.extensions.AtomicTransaction Line 617
Possible null pointer dereference of AtomicTransaction._theAction in com.arjuna.ats.jts.extensions.AtomicTransaction.equals(Object)
> NP: Possible null pointer dereference (NP_NULL_ON_SOME_PATH)
> ------------------------------------------------------------
>
> Key: JBTM-1036
> URL: https://issues.jboss.org/browse/JBTM-1036
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: JTA, JTS, Transaction Core
> Reporter: Amos Feng
> Assignee: Tom Jenkinson
> Priority: Minor
> Fix For: 5.0.0.M5
>
> Original Estimate: 1 hour
> Remaining Estimate: 1 hour
>
> 1.ArjunaJTA/jdbc
> Possible null pointer dereference of conn in com.arjuna.ats.internal.jdbc.recovery.BasicXARecovery.getXAResource() Line 169
> 3.ArjunaCore/arjuna
> com.arjuna.ats.internal.arjuna.objectstore.HashedStore Line 131
> Possible null pointer dereference of aUid in com.arjuna.ats.internal.arjuna.objectstore.HashedStore.allObjUids(String, InputObjectState, int)
> 5.ArjunaJTS/jts
> com.arjuna.ats.internal.jts.context.ContextManager Line 553
> Possible null pointer dereference of action in com.arjuna.ats.internal.jts.context.ContextManager.pushAction(ControlWrapper)
> 6.ArjunaJTS/jts
> com.arjuna.ats.jts.extensions.AtomicTransaction Line 617
> Possible null pointer dereference of AtomicTransaction._theAction in com.arjuna.ats.jts.extensions.AtomicTransaction.equals(Object)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 2 months