[JBoss JIRA] (JBTM-2284) XID.toString broken: indexing mistake in array
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-2284?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-2284:
--------------------------------
Fix Version/s: 4.17.24
> XID.toString broken: indexing mistake in array
> ----------------------------------------------
>
> Key: JBTM-2284
> URL: https://issues.jboss.org/browse/JBTM-2284
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Affects Versions: 4.17.15
> Environment: EAP 6.2.4 with JBoss JTS module in version 4.17.15
> Reporter: Christian von Kutzleben
> Assignee: Tom Jenkinson
> Fix For: 4.17.24
>
>
> com.arjuna.ats.internal.jta.xa.XID
>
> public String toString ()
> {
> //...
> stringBuilder.append(", ");
> for (int i = 0; i < bqual_length; i++) {
> stringBuilder.append(gtrid_length+data[i]);
> }
> //...
> }
>
> correct: stringBuilder.append(data[i+gtrid_length]);
> The result is, that the Xid instances logged in log files are corrupted and multiple different Xid share the same String representation, which makes the logging information unusable
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
10 years, 3 months
[JBoss JIRA] (JBTM-2284) XID.toString broken: indexing mistake in array
by Christian von Kutzleben (JIRA)
Christian von Kutzleben created JBTM-2284:
---------------------------------------------
Summary: XID.toString broken: indexing mistake in array
Key: JBTM-2284
URL: https://issues.jboss.org/browse/JBTM-2284
Project: JBoss Transaction Manager
Issue Type: Bug
Affects Versions: 4.17.15
Environment: EAP 6.2.4 with JBoss JTS module in version 4.17.15
Reporter: Christian von Kutzleben
Assignee: Tom Jenkinson
com.arjuna.ats.internal.jta.xa.XID
public String toString ()
{
//...
stringBuilder.append(", ");
for (int i = 0; i < bqual_length; i++) {
stringBuilder.append(gtrid_length+data[i]);
}
//...
}
correct: stringBuilder.append(data[i+gtrid_length]);
The result is, that the Xid instances logged in log files are corrupted and multiple different Xid share the same String representation, which makes the logging information unusable
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
10 years, 3 months
[JBoss JIRA] (JBTM-2279) Provide a way to allow overriding of a set CheckedActionFactory
by Mark Little (JIRA)
[ https://issues.jboss.org/browse/JBTM-2279?page=com.atlassian.jira.plugin.... ]
Mark Little edited comment on JBTM-2279 at 11/11/14 8:14 AM:
-------------------------------------------------------------
Wouldn't it have been easier/better/less invasive to have hidden this within a call to something like getCheckedActionFactory()?
_checkedAction = _checkedActionFactory.getCheckedAction(get_uid(), type());
+ _checkedAction = allowCheckedActionFactoryToBeOverriden ? arjPropertyManager
+ .getCoordinatorEnvironmentBean().getCheckedActionFactory()
+ .getCheckedAction(get_uid(), type())
+ : defaultCheckedActionFactory.getCheckedAction(get_uid(),
+ type());
was (Author: marklittle):
Wouldn't it have been easier/better/less invasive to have hidden this within the call to getCheckedAction?
_checkedAction = _checkedActionFactory.getCheckedAction(get_uid(), type());
+ _checkedAction = allowCheckedActionFactoryToBeOverriden ? arjPropertyManager
+ .getCoordinatorEnvironmentBean().getCheckedActionFactory()
+ .getCheckedAction(get_uid(), type())
+ : defaultCheckedActionFactory.getCheckedAction(get_uid(),
+ type());
> Provide a way to allow overriding of a set CheckedActionFactory
> ---------------------------------------------------------------
>
> Key: JBTM-2279
> URL: https://issues.jboss.org/browse/JBTM-2279
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Components: Transaction Core
> Reporter: Tom Jenkinson
> Assignee: Tom Jenkinson
> Fix For: 5.0.4
>
>
> Out of the box the BasicAction caches the reference to the checkedactionfactory and so if a users classpath is not available to narayana there is no way for a user to provide a CAF to Narayana.
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
10 years, 3 months
[JBoss JIRA] (JBTM-2279) Provide a way to allow overriding of a set CheckedActionFactory
by Mark Little (JIRA)
[ https://issues.jboss.org/browse/JBTM-2279?page=com.atlassian.jira.plugin.... ]
Mark Little commented on JBTM-2279:
-----------------------------------
Wouldn't it have been easier/better/less invasive to have hidden this within the call to getCheckedAction?
_checkedAction = _checkedActionFactory.getCheckedAction(get_uid(), type());
+ _checkedAction = allowCheckedActionFactoryToBeOverriden ? arjPropertyManager
+ .getCoordinatorEnvironmentBean().getCheckedActionFactory()
+ .getCheckedAction(get_uid(), type())
+ : defaultCheckedActionFactory.getCheckedAction(get_uid(),
+ type());
> Provide a way to allow overriding of a set CheckedActionFactory
> ---------------------------------------------------------------
>
> Key: JBTM-2279
> URL: https://issues.jboss.org/browse/JBTM-2279
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Components: Transaction Core
> Reporter: Tom Jenkinson
> Assignee: Tom Jenkinson
> Fix For: 5.0.4
>
>
> Out of the box the BasicAction caches the reference to the checkedactionfactory and so if a users classpath is not available to narayana there is no way for a user to provide a CAF to Narayana.
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)
10 years, 3 months