[JBoss JIRA] (JBTM-2593) Suggest making this read_state INFO not WARN
by Mark Little (JIRA)
[ https://issues.jboss.org/browse/JBTM-2593?page=com.atlassian.jira.plugin.... ]
Mark Little commented on JBTM-2593:
-----------------------------------
OK, so for full details of why this really shouldn't have been a warning in the first place here goes ...
read_state takes a file type (ft in the parameters) ...
protected InputObjectState read_state (Uid objUid, String tName, int ft)
Within the method we get the current state of the instance ...
int state = currentState(objUid, tName);
Now that state could be one of OS_UNKNOWN, OS_COMMITTED, OS_UNCOMMITTED, OS_HIDDEN, OS_COMMITTED_HIDDEN or OS_UNCOMMITTED_HIDDEN.
All of these are valid values for the state to have (OS_UNKNOWN typically means "it's not there").
Assuming it's OS_COMMITTED or OS_UNCOMMITTED we're going to see if that's the state we expected when read_state was called, i.e., if ft is one of these. Then we do other "stuff"/
If the state isn't OS_COMMITTED or OS_UNCOMMITTED then we're not going to bother reading the state. If it's hidden (committed hidden or even uncommitted hidden) then we're going to return a null state and the caller interprets this at the higher level. For example, if it expected to find a state and got null back then it can call currentState and base its next actions on that value, e.g., then calling reveal_state and read_state once again. But the important thing is that just because the state is neither committed nor uncommitted does not mean that it's an error or a warning. That's for the caller to determine and not the ObjectStore implementation.
> Suggest making this read_state INFO not WARN
> --------------------------------------------
>
> Key: JBTM-2593
> URL: https://issues.jboss.org/browse/JBTM-2593
> Project: JBoss Transaction Manager
> Issue Type: Task
> Components: Transaction Core
> Affects Versions: 5.2.11.Final
> Reporter: Mark Little
> Assignee: Mark Little
> Priority: Minor
>
> I'm not sure why it was added or why it's a warning. Maybe should be info or debug?
> read_state operation, ShadowingStore_6
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (JBTM-2593) Suggest making this read_state INFO not WARN
by Mark Little (JIRA)
[ https://issues.jboss.org/browse/JBTM-2593?page=com.atlassian.jira.plugin.... ]
Mark Little commented on JBTM-2593:
-----------------------------------
I'm changing this to to trace so that anyone who really needs to see this message at runtime can. However, it shouldn't be the default or we get warnings for no good reason.
> Suggest making this read_state INFO not WARN
> --------------------------------------------
>
> Key: JBTM-2593
> URL: https://issues.jboss.org/browse/JBTM-2593
> Project: JBoss Transaction Manager
> Issue Type: Task
> Components: Transaction Core
> Affects Versions: 5.2.11.Final
> Reporter: Mark Little
> Assignee: Mark Little
> Priority: Minor
>
> I'm not sure why it was added or why it's a warning. Maybe should be info or debug?
> read_state operation, ShadowingStore_6
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (JBTM-2593) Suggest making this read_state INFO not WARN
by Mark Little (JIRA)
[ https://issues.jboss.org/browse/JBTM-2593?page=com.atlassian.jira.plugin.... ]
Mark Little commented on JBTM-2593:
-----------------------------------
So I'm still not sure why this was added. The reason it was never there in the past is because we have many occasions where an application may try to activate an object for which the state isn't there and it will fail at the application level if the state is expected and not present. Something calling read_state on an instance that is no longer there isn't necessarily a failure, or at least at the level of the ObjectStore it's not possible to determine if it's a failure. Now we're printing warnings for a lot of cases where it's not actually an error!
> Suggest making this read_state INFO not WARN
> --------------------------------------------
>
> Key: JBTM-2593
> URL: https://issues.jboss.org/browse/JBTM-2593
> Project: JBoss Transaction Manager
> Issue Type: Task
> Components: Transaction Core
> Affects Versions: 5.2.11.Final
> Reporter: Mark Little
> Priority: Minor
>
> I'm not sure why it was added or why it's a warning. Maybe should be info or debug?
> read_state operation, ShadowingStore_6
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (JBTM-2592) Incorrect warning messaging in ShadowingStore
by Mark Little (JIRA)
[ https://issues.jboss.org/browse/JBTM-2592?page=com.atlassian.jira.plugin.... ]
Mark Little closed JBTM-2592.
-----------------------------
Resolution: Done
> Incorrect warning messaging in ShadowingStore
> ---------------------------------------------
>
> Key: JBTM-2592
> URL: https://issues.jboss.org/browse/JBTM-2592
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Components: Transaction Core
> Affects Versions: 5.2.11.Final
> Reporter: Mark Little
> Assignee: Mark Little
> Priority: Minor
>
> warn_objectstore_ShadowingStore_6 currently says ...
> "ShadowingStore::read_state() - no type name given for object state"
> ... when in fact the else clause is triggered when the state isn't committed or uncommitted (typically when it's unknown and the state doesn't exist).
> I'm not sure when this warning message was added because it wasn't there in JBossTS 4.8 or 4.15.3.
> I'm going to fix this issue (the text). I'll create a separate issue because I think this should be info not warning.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (JBTM-2592) Incorrect warning messaging in ShadowingStore
by Mark Little (JIRA)
[ https://issues.jboss.org/browse/JBTM-2592?page=com.atlassian.jira.plugin.... ]
Work on JBTM-2592 started by Mark Little.
-----------------------------------------
> Incorrect warning messaging in ShadowingStore
> ---------------------------------------------
>
> Key: JBTM-2592
> URL: https://issues.jboss.org/browse/JBTM-2592
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Components: Transaction Core
> Affects Versions: 5.2.11.Final
> Reporter: Mark Little
> Assignee: Mark Little
> Priority: Minor
>
> warn_objectstore_ShadowingStore_6 currently says ...
> "ShadowingStore::read_state() - no type name given for object state"
> ... when in fact the else clause is triggered when the state isn't committed or uncommitted (typically when it's unknown and the state doesn't exist).
> I'm not sure when this warning message was added because it wasn't there in JBossTS 4.8 or 4.15.3.
> I'm going to fix this issue (the text). I'll create a separate issue because I think this should be info not warning.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (JBTM-2593) Suggest making this read_state INFO not WARN
by Mark Little (JIRA)
[ https://issues.jboss.org/browse/JBTM-2593?page=com.atlassian.jira.plugin.... ]
Mark Little updated JBTM-2593:
------------------------------
Description:
I'm not sure why it was added or why it's a warning. Maybe should be info or debug?
read_state operation, ShadowingStore_6
was:I'm not sure why it was added or why it's a warning. Maybe should be info or debug?
Summary: Suggest making this read_state INFO not WARN (was: Suggest making this INFO not WARN)
> Suggest making this read_state INFO not WARN
> --------------------------------------------
>
> Key: JBTM-2593
> URL: https://issues.jboss.org/browse/JBTM-2593
> Project: JBoss Transaction Manager
> Issue Type: Task
> Components: Transaction Core
> Affects Versions: 5.2.11.Final
> Reporter: Mark Little
> Priority: Minor
>
> I'm not sure why it was added or why it's a warning. Maybe should be info or debug?
> read_state operation, ShadowingStore_6
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (JBTM-2593) Suggest making this INFO not WARN
by Mark Little (JIRA)
Mark Little created JBTM-2593:
---------------------------------
Summary: Suggest making this INFO not WARN
Key: JBTM-2593
URL: https://issues.jboss.org/browse/JBTM-2593
Project: JBoss Transaction Manager
Issue Type: Task
Components: Transaction Core
Affects Versions: 5.2.11.Final
Reporter: Mark Little
Priority: Minor
I'm not sure why it was added or why it's a warning. Maybe should be info or debug?
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (JBTM-2592) Incorrect warning messaging in ShadowingStore
by Mark Little (JIRA)
Mark Little created JBTM-2592:
---------------------------------
Summary: Incorrect warning messaging in ShadowingStore
Key: JBTM-2592
URL: https://issues.jboss.org/browse/JBTM-2592
Project: JBoss Transaction Manager
Issue Type: Bug
Components: Transaction Core
Affects Versions: 5.2.11.Final
Reporter: Mark Little
Assignee: Mark Little
Priority: Minor
warn_objectstore_ShadowingStore_6 currently says ...
"ShadowingStore::read_state() - no type name given for object state"
... when in fact the else clause is triggered when the state isn't committed or uncommitted (typically when it's unknown and the state doesn't exist).
I'm not sure when this warning message was added because it wasn't there in JBossTS 4.8 or 4.15.3.
I'm going to fix this issue (the text). I'll create a separate issue because I think this should be info not warning.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months
[JBoss JIRA] (JBTM-2591) WildFly quick start example fails to build
by Mark Little (JIRA)
[ https://issues.jboss.org/browse/JBTM-2591?page=com.atlassian.jira.plugin.... ]
Mark Little commented on JBTM-2591:
-----------------------------------
Yes, using 5.2.9.Final produces an example that works ...
15:43:35,988 INFO [org.jboss.weld.deployer] (MSC service thread 1-1) WFLYWELD0006: Starting Services for CDI deployment: ROOT.war
15:43:36,055 INFO [org.jboss.weld.Version] (MSC service thread 1-1) WELD-000900: 2.2.16 (SP1)
15:43:36,303 INFO [org.jboss.weld.deployer] (MSC service thread 1-3) WFLYWELD0009: Starting weld service for deployment ROOT.war
15:43:38,196 INFO [stdout] (ServerService Thread Pool -- 58) StartupBean call
15:43:38,217 INFO [stdout] (ServerService Thread Pool -- 58) MyEJB call
15:43:38,217 WARN [com.arjuna.ats.arjuna] (ServerService Thread Pool -- 58) ARJUNA012094: Commit of action id 0:ffffc0a80121:-26a9308d:567c12a6:b invoked while multiple threads active within it.
15:43:38,218 WARN [com.arjuna.ats.arjuna] (ServerService Thread Pool -- 58) ARJUNA012107: CheckedAction::check - atomic action 0:ffffc0a80121:-26a9308d:567c12a6:b commiting with 1 threads active!
15:43:38,602 INFO [javax.enterprise.resource.webcontainer.jsf.config] (ServerService Thread Pool -- 58) Initializing Mojarra 2.2.12-jbossorg-2 20150729-1131 for context ''
15:43:40,112 INFO [org.wildfly.extension.undertow] (ServerService Thread Pool -- 58) WFLYUT0021: Registered web context: /
15:43:40,151 INFO [org.jboss.as.server] (ServerService Thread Pool -- 34) WFLYSRV0010: Deployed "ROOT.war" (runtime-name : "ROOT.war")
15:43:40,264 INFO [org.jboss.as] (Controller Boot Thread) WFLYSRV0060: Http management interface listening on http://127.0.0.1:9990/management
15:43:40,266 INFO [org.jboss.as] (Controller Boot Thread) WFLYSRV0051: Admin console listening on http://127.0.0.1:9990
15:43:40,266 INFO [org.jboss.as] (Controller Boot Thread) WFLYSRV0025: WildFly Full 9.0.2.Final (WildFly Core 1.0.2.Final) started in 14595ms - Started 330 of 510 services (221 services are lazy, passive or on-demand)
I won't raise a pull request because maybe there's a reason it shouldn't be 5.2.9.Final. Whoever takes this issue should provide the right fix, i.e., don't wait for me :)
> WildFly quick start example fails to build
> ------------------------------------------
>
> Key: JBTM-2591
> URL: https://issues.jboss.org/browse/JBTM-2591
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Components: Application Server Integration, Demonstrator
> Affects Versions: 5.2.11.Final
> Reporter: Mark Little
> Assignee: Amos Feng
>
> Trying to build the example here ...
> https://github.com/jbosstm/quickstart/tree/master/wildfly/setCheckedActio...
> The pom refers to a version of JTA that isn't in the repo, so it fails.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19.553 s
> [INFO] Finished at: 2015-12-24T15:30:31+00:00
> [INFO] Final Memory: 8M/149M
> [INFO] ------------------------------------------------------------------------
> [ERROR] Failed to execute goal on project setCheckedActionFactoryExample: Could not resolve dependencies for project org.jboss.narayana:setCheckedActionFactoryExample:war:0.0.1-SNAPSHOT: Could not find artifact org.jboss.narayana.jta:jta:jar:5.2.12.Final-SNAPSHOT in jboss-public-repository-group (https://repository.jboss.org/nexus/content/groups/public/) -> [Help 1]
> Changing to 5.2.9.Final at least lets the example build (and hopefully run).
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
8 years, 11 months