[ http://jira.jboss.com/jira/browse/JBTM-319?page=comments#action_12394694 ] Jonathan Halliday commented on JBTM-319: ---------------------------------------- The existing JNDIXARecovery approach is almost right, except it reads datasource parameters from a xml file. For integration with AS, it would be better if we have a similar module that just takes a JNDI name for the DataSource and looks it up from the AS. Requiring manual configuration of this is not elegant, since new xa data source then need defining in the -ds.xml for the AS and their JNDI name referencing the in jbossjta-properties.xml for TS recovery. It would be possible to walk the JNDI tree at startup and populate the recovery system with one instance of this Recovery class per defined XADataSource, but it's problematic for two reasons: data sources may not yet be deployed at that time and we may not want to recovery for them e.g. if they are shared with other systems. Ideally the AS code that does deployment of XADataSources should call the recovery system when it does so, perhaps conditional on a flag in the -ds.xml so that recovery could be disabled on a per-datasource basis in the config ds file. Until then the config will have to remain split between the -ds.xml and the ts properties file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBTM-319?page=comments#action_12394702 ] Jonathan Halliday commented on JBTM-319: ---------------------------------------- Hmm, on further thought the JNDI name alone is not going to be sufficient. Doing a lookup on that name returns a WrapperDataSource, which is not a XADataSource. We either need a Recovery class that takes the name of the -ds.xml file and parses the xml itself, or a modified data source deployer that can feed the required data to the recovery system, either via JNDI or directly. The Recovery class would require changes to the TS only, but would couple it against a file format used by the AS and require duplicating a chunk of AS code to parse that format. In short, it's not an ideal solution. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBTM-319?page=comments#action_12394852 ] Mark Little commented on JBTM-319: ---------------------------------- Or the ConnectionFactory? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBTM-319?page=all ] Jonathan Halliday updated JBTM-319: ----------------------------------- Fix Version/s: 4.2.3.SP8 4.3.0.BETA3 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBTM-319?page=comments#action_12401090 ] Jonathan Halliday commented on JBTM-319: ---------------------------------------- Won't port to trunk as integration with AS 5.0 needs a different approach and we have the luxury of being able to change the integration API for it. See JBTM-335 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBTM-319?page=all ] Jonathan Halliday closed JBTM-319. ---------------------------------- Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBTM-319?page=comments#action_12413122 ] Mark Little commented on JBTM-319: ---------------------------------- Can you take any queries and discussion to the forums, where it's easier to track? Thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira