March 2013 - jbossts-issues - Jboss List Archives

[JBoss JIRA] (JBTM-1602) Determine why 4 locks acquired in LockManager.propagate

by Michael Musgrove (JIRA)

[ https://issues.jboss.org/browse/JBTM-1602?page=com.atlassian.jira.plugin.... ] Michael Musgrove commented on JBTM-1602: ---------------------------------------- The test that originally showed up the race condition (org.jboss.jbossts.qa.junit.testgroup.TestGroup_jtsremote#JTSRemote_DistributedHammerTest2) used to fail on average after about 20 runs so 1000 runs with your changes certainly looks to have fixed the original issue. Thanks for fixing this. > Determine why 4 locks acquired in LockManager.propagate > ------------------------------------------------------- > > Key: JBTM-1602 > URL: https://issues.jboss.org/browse/JBTM-1602 > Project: JBoss Transaction Manager > Issue Type: Task > Security Level: Public(Everyone can see) > Components: Transaction Core > Affects Versions: 5.0.0.M2 > Reporter: Mark Little > Assignee: Mark Little > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-1602) Determine why 4 locks acquired in LockManager.propagate

by Mark Little (JIRA)

[ https://issues.jboss.org/browse/JBTM-1602?page=com.atlassian.jira.plugin.... ] Mark Little commented on JBTM-1602: ----------------------------------- Reverted some of the optimisations and re-tested against jtsremote qa test runs. Added to run-tests.xml: <target name="foobar">  <junit-tests tests="jtsremote"/> </target> (Will not commit this change - it's only to test these changes locally.) Then run: ant -f run-tests.xml foobar 1000 times, with the output below from each run: Buildfile: /Users/marklittle/github/narayana/qa/run-tests.xml foobar: [echo] Running junit test group jtsremote from basedir=/Users/marklittle/github/narayana/qa [junit] Running org.jboss.jbossts.qa.junit.testgroup.TestGroup_jtsremote [junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 75.86 sec BUILD SUCCESSFUL Total time: 1 minute 17 seconds > Determine why 4 locks acquired in LockManager.propagate > ------------------------------------------------------- > > Key: JBTM-1602 > URL: https://issues.jboss.org/browse/JBTM-1602 > Project: JBoss Transaction Manager > Issue Type: Task > Security Level: Public(Everyone can see) > Components: Transaction Core > Affects Versions: 5.0.0.M2 > Reporter: Mark Little > Assignee: Mark Little > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-1608) Reconsider whether all STLA 2PC methods need context associating (for TXOJ)

by Mark Little (JIRA)

Mark Little created JBTM-1608: --------------------------------- Summary: Reconsider whether all STLA 2PC methods need context associating (for TXOJ) Key: JBTM-1608 URL: https://issues.jboss.org/browse/JBTM-1608 Project: JBoss Transaction Manager Issue Type: Task Security Level: Public (Everyone can see) Components: JTS, STM, Transaction Core Affects Versions: 5.0.0.M2 Reporter: Mark Little Assignee: Mark Little All of the ServerTopLevelAction 2PC methods have local context association commented out, since it's not strictly needed in the JTS (a Resource is implicitly associated with a single transaction). It's not invalid either though, but we commented it out years ago. It's been added back for the rollback method. Check to see if it needs to be added back to all methods for consistency. May be needed for distributed STM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-1602) Determine why 4 locks acquired in LockManager.propagate

by Mark Little (JIRA)

[ https://issues.jboss.org/browse/JBTM-1602?page=com.atlassian.jira.plugin.... ] Mark Little commented on JBTM-1602: ----------------------------------- This may also relate to https://issues.jboss.org/browse/JBTM-648 in so much as the issue could have been masked by the use of our own locking implementation in the past which was less optimal (e.g., reduced the chance of race conditions.) > Determine why 4 locks acquired in LockManager.propagate > ------------------------------------------------------- > > Key: JBTM-1602 > URL: https://issues.jboss.org/browse/JBTM-1602 > Project: JBoss Transaction Manager > Issue Type: Task > Security Level: Public(Everyone can see) > Components: Transaction Core > Affects Versions: 5.0.0.M2 > Reporter: Mark Little > Assignee: Mark Little > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-648) TXOJ Lock as java Lock?

by Mark Little (JIRA)

[ https://issues.jboss.org/browse/JBTM-648?page=com.atlassian.jira.plugin.s... ] Mark Little closed JBTM-648. ---------------------------- > TXOJ Lock as java Lock? > ----------------------- > > Key: JBTM-648 > URL: https://issues.jboss.org/browse/JBTM-648 > Project: JBoss Transaction Manager > Issue Type: Task > Security Level: Public(Everyone can see) > Components: Transaction Core > Reporter: Mark Little > Assignee: Mark Little > Priority: Optional > Fix For: 4.17.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-648) TXOJ Lock as java Lock?

by Mark Little (JIRA)

[ https://issues.jboss.org/browse/JBTM-648?page=com.atlassian.jira.plugin.s... ] Mark Little resolved JBTM-648. ------------------------------ Fix Version/s: 4.17.0 Resolution: Done Removed BasicMutex and replaced with language locks (Reentrant). > TXOJ Lock as java Lock? > ----------------------- > > Key: JBTM-648 > URL: https://issues.jboss.org/browse/JBTM-648 > Project: JBoss Transaction Manager > Issue Type: Task > Security Level: Public(Everyone can see) > Components: Transaction Core > Reporter: Mark Little > Assignee: Mark Little > Priority: Optional > Fix For: 4.17.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-648) TXOJ Lock as java Lock?

by Mark Little (JIRA)

[ https://issues.jboss.org/browse/JBTM-648?page=com.atlassian.jira.plugin.s... ] Mark Little reopened JBTM-648: ------------------------------ Not sure why I closed this as "won't fix", since the work was done. > TXOJ Lock as java Lock? > ----------------------- > > Key: JBTM-648 > URL: https://issues.jboss.org/browse/JBTM-648 > Project: JBoss Transaction Manager > Issue Type: Task > Security Level: Public(Everyone can see) > Components: Transaction Core > Reporter: Mark Little > Assignee: Mark Little > Priority: Optional > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-1607) Hardcoded path in qa run.sh

by Mark Little (JIRA)

Mark Little created JBTM-1607: --------------------------------- Summary: Hardcoded path in qa run.sh Key: JBTM-1607 URL: https://issues.jboss.org/browse/JBTM-1607 Project: JBoss Transaction Manager Issue Type: Task Security Level: Public (Everyone can see) Components: Configuration, Testing Affects Versions: 5.0.0.M2 Reporter: Mark Little Assignee: Tom Jenkinson qa/run.sh #!/bin/bash sed -i TaskImpl.properties -e "s#^COMMAND_LINE_0=.*#COMMAND_LINE_0=java#" ant -Ddriver.url=file:///home/tom/narayana/dbdrivers get.drivers dist ant -f run-tests.xml ci-tests -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-1606) Change LockManagerProxy constructor API

by Mark Little (JIRA)

Mark Little created JBTM-1606: --------------------------------- Summary: Change LockManagerProxy constructor API Key: JBTM-1606 URL: https://issues.jboss.org/browse/JBTM-1606 Project: JBoss Transaction Manager Issue Type: Task Security Level: Public (Everyone can see) Components: STM Affects Versions: 5.0.0.M2 Reporter: Mark Little Assignee: Mark Little Priority: Minor LockManagerProxy constructors pass in a number of parameters which are actually obtainable from the first parameter, the container. Tidy it up. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 8 months

1
0
0 / 0

[JBoss JIRA] (JBTM-1602) Determine why 4 locks acquired in LockManager.propagate

by Mark Little (JIRA)

[ https://issues.jboss.org/browse/JBTM-1602?page=com.atlassian.jira.plugin.... ] Mark Little commented on JBTM-1602: ----------------------------------- I'm not convinced this change is the right one to make or has been applied consistently to the rest of the class. I'll take a look at the test case you had which reproduced the problem and revert some of the optimisations we've applied over the years to LockManager to reduce contention and which have probably introduced this vulnerability. > Determine why 4 locks acquired in LockManager.propagate > ------------------------------------------------------- > > Key: JBTM-1602 > URL: https://issues.jboss.org/browse/JBTM-1602 > Project: JBoss Transaction Manager > Issue Type: Task > Security Level: Public(Everyone can see) > Components: Transaction Core > Affects Versions: 5.0.0.M2 > Reporter: Mark Little > Assignee: Mark Little > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues March 2013