[JBoss JIRA] (JBTM-1742) Tidy up the JTS IDL
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1742?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson commented on JBTM-1742:
-------------------------------------
I put some comments on JBTM-1746 (which was raised when CI broke). I will "back port" those comments here..
Comment 1:
Note that it is in the JDK orb IDL processing, rather than jacorb.
A default build does not build the JDK orb but CI will which is where this issue was first discovered. You can reproduce this issue by:
./build.sh clean install -f ArjunaJTS/idl/idlj/pom.xml
Comment 2:
Seems to be this bit of the commit that removed
#ifdef ORB_CURRENT_SUPPORT
interface Current : CORBA::Current
#else
interface Current
#endif
and went to:
interface Current : CORBA::Current
> Tidy up the JTS IDL
> -------------------
>
> Key: JBTM-1742
> URL: https://issues.jboss.org/browse/JBTM-1742
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: JTS
> Affects Versions: 5.0.0.M3
> Reporter: Mark Little
> Assignee: Mark Little
> Fix For: 5.0.0.M4
>
>
> The IDL hasn't been updated for over a decade and has preprocessor directives in there that are probably no longer needed, unless we want to be backwardly compatible for ORBs that are no longer produced.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (JBTM-1742) Tidy up the JTS IDL
by Mark Little (JIRA)
[ https://issues.jboss.org/browse/JBTM-1742?page=com.atlassian.jira.plugin.... ]
Mark Little commented on JBTM-1742:
-----------------------------------
In what way did it break the build? I thought I had built everything when I changed this yesterday.
> Tidy up the JTS IDL
> -------------------
>
> Key: JBTM-1742
> URL: https://issues.jboss.org/browse/JBTM-1742
> Project: JBoss Transaction Manager
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: JTS
> Affects Versions: 5.0.0.M3
> Reporter: Mark Little
> Assignee: Mark Little
> Fix For: 5.0.0.M4
>
>
> The IDL hasn't been updated for over a decade and has preprocessor directives in there that are probably no longer needed, unless we want to be backwardly compatible for ORBs that are no longer produced.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (JBTM-1754) Make project names consistent in poms
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1754?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson commented on JBTM-1754:
-------------------------------------
Hi Paul, is the "Narayana: " prefix implied and therefore a little redundant (I realise I added the redundancy myself with JBossJTS, so just trying to get your opinion here)? if not the table looks good to me - thanks!
> Make project names consistent in poms
> -------------------------------------
>
> Key: JBTM-1754
> URL: https://issues.jboss.org/browse/JBTM-1754
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: Build System
> Reporter: Paul Gier
> Assignee: Paul Gier
>
> The project names used in the build are not consistent which makes it difficult for someone unfamiliar with the project to debug build issues.
> Some examples are provided:
> ||Dir Name||Artifact ID||Project Name||Proposed Name||
> |/ArjunaJTA|narayana-jta-all|JBoss JTA everything|Narayana: ArjunaJTA|
> |/ArjunaJTS/narayana-jts-idlj|narayana-jts-idlj|JBossJTS packaged module with idlj stubs|Narayana: ArjunaJTS idlj|
> |/ArjunaJTS/orbportability|orbportability|JBossJTS orb portability|Narayana: ArjunaJTS orbportability|
> The project names can be changed without disrupting the way the build works, so these should be changed to match the dir and artifactId as much as possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (JBTM-1712) perf problem in FileSystemStore.openAndLock
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/JBTM-1712?page=com.atlassian.jira.plugin.... ]
RH Bugzilla Integration commented on JBTM-1712:
-----------------------------------------------
Michael <mmusgrov(a)redhat.com> changed the Status of [bug 968125|https://bugzilla.redhat.com/show_bug.cgi?id=968125] from NEW to MODIFIED
> perf problem in FileSystemStore.openAndLock
> -------------------------------------------
>
> Key: JBTM-1712
> URL: https://issues.jboss.org/browse/JBTM-1712
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: Transaction Core
> Affects Versions: 4.16.4, 5.0.0.M2
> Reporter: Jonathan Halliday
> Assignee: Mark Little
> Fix For: 5.0.0.M3
>
>
> if(!file.exits())
> {
> if(createHierarchy(file))
> incorrectly calls the expensive (because synchronized) createHierarchy method in the common case where the file does not exist (because it's a uniq named new tx record) but the directory hierarchy does (because it's the create-once hashed dir tree). This causes excessive contention on the FileSystemStore instance object monitor lock. Should probably be something more like
> if(!file.getParent().exists())
> {
> if(createHierarchy(file))
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (JBTM-1754) Make project names consistent in poms
by Paul Gier (JIRA)
[ https://issues.jboss.org/browse/JBTM-1754?page=com.atlassian.jira.plugin.... ]
Paul Gier edited comment on JBTM-1754 at 6/6/13 11:16 AM:
----------------------------------------------------------
I updated the table with proposed project names, if those look ok, I'll submit a PR with the full set of changes.
was (Author: pgier):
I updated the table, if those look ok, I'll submit a PR with the full set of changes.
> Make project names consistent in poms
> -------------------------------------
>
> Key: JBTM-1754
> URL: https://issues.jboss.org/browse/JBTM-1754
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: Build System
> Reporter: Paul Gier
> Assignee: Paul Gier
>
> The project names used in the build are not consistent which makes it difficult for someone unfamiliar with the project to debug build issues.
> Some examples are provided:
> ||Dir Name||Artifact ID||Project Name||Proposed Name||
> |/ArjunaJTA|narayana-jta-all|JBoss JTA everything|Narayana: ArjunaJTA|
> |/ArjunaJTS/narayana-jts-idlj|narayana-jts-idlj|JBossJTS packaged module with idlj stubs|Narayana: ArjunaJTS idlj|
> |/ArjunaJTS/orbportability|orbportability|JBossJTS orb portability|Narayana: ArjunaJTS orbportability|
> The project names can be changed without disrupting the way the build works, so these should be changed to match the dir and artifactId as much as possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (JBTM-1754) Make project names consistent in poms
by Paul Gier (JIRA)
[ https://issues.jboss.org/browse/JBTM-1754?page=com.atlassian.jira.plugin.... ]
Paul Gier updated JBTM-1754:
----------------------------
Description:
The project names used in the build are not consistent which makes it difficult for someone unfamiliar with the project to debug build issues.
Some examples are provided:
||Dir Name||Artifact ID||Project Name||Proposed Name||
|/ArjunaJTA|narayana-jta-all|JBoss JTA everything|Narayana: ArjunaJTA|
|/ArjunaJTS/narayana-jts-idlj|narayana-jts-idlj|JBossJTS packaged module with idlj stubs|Narayana: ArjunaJTS idlj|
|/ArjunaJTS/orbportability|orbportability|JBossJTS orb portability|Narayana: ArjunaJTS orbportability|
The project names can be changed without disrupting the way the build works, so these should be changed to match the dir and artifactId as much as possible.
was:
The project names used in the build are not consistent which makes it difficult for someone unfamiliar with the project to debug build issues.
Some examples are provided:
||Dir Name||Artifact ID||Project Name||
|/ArjunaJTA|narayana-jta-all|JBoss JTA everything|
|/ArjunaJTS/narayana-jts-idlj|narayana-jts-idlj|JBossJTS packaged module with idlj stubs|
|/ArjunaJTS/orbportability|orbportability|JBossJTS orb portability|
The project names can be changed without disrupting the way the build works, so these should be changed to match the dir and artifactId as much as possible.
> Make project names consistent in poms
> -------------------------------------
>
> Key: JBTM-1754
> URL: https://issues.jboss.org/browse/JBTM-1754
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: Build System
> Reporter: Paul Gier
> Assignee: Paul Gier
>
> The project names used in the build are not consistent which makes it difficult for someone unfamiliar with the project to debug build issues.
> Some examples are provided:
> ||Dir Name||Artifact ID||Project Name||Proposed Name||
> |/ArjunaJTA|narayana-jta-all|JBoss JTA everything|Narayana: ArjunaJTA|
> |/ArjunaJTS/narayana-jts-idlj|narayana-jts-idlj|JBossJTS packaged module with idlj stubs|Narayana: ArjunaJTS idlj|
> |/ArjunaJTS/orbportability|orbportability|JBossJTS orb portability|Narayana: ArjunaJTS orbportability|
> The project names can be changed without disrupting the way the build works, so these should be changed to match the dir and artifactId as much as possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (JBTM-1754) Make project names consistent in poms
by Paul Gier (JIRA)
[ https://issues.jboss.org/browse/JBTM-1754?page=com.atlassian.jira.plugin.... ]
Paul Gier commented on JBTM-1754:
---------------------------------
I updated the table, if those look ok, I'll submit a PR with the full set of changes.
> Make project names consistent in poms
> -------------------------------------
>
> Key: JBTM-1754
> URL: https://issues.jboss.org/browse/JBTM-1754
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: Build System
> Reporter: Paul Gier
> Assignee: Paul Gier
>
> The project names used in the build are not consistent which makes it difficult for someone unfamiliar with the project to debug build issues.
> Some examples are provided:
> ||Dir Name||Artifact ID||Project Name||Proposed Name||
> |/ArjunaJTA|narayana-jta-all|JBoss JTA everything|Narayana: ArjunaJTA|
> |/ArjunaJTS/narayana-jts-idlj|narayana-jts-idlj|JBossJTS packaged module with idlj stubs|Narayana: ArjunaJTS idlj|
> |/ArjunaJTS/orbportability|orbportability|JBossJTS orb portability|Narayana: ArjunaJTS orbportability|
> The project names can be changed without disrupting the way the build works, so these should be changed to match the dir and artifactId as much as possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (JBTM-1754) Make project names consistent in poms
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1754?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson commented on JBTM-1754:
-------------------------------------
Hi Paul,
The dir name and artifact id are effectively fixed at the moment. However, as you say we have more flexibility on the "project name" field. Can you update your table with an example of your preferred project name for those modules you have referenced originally, please?
Thanks,
Tom
> Make project names consistent in poms
> -------------------------------------
>
> Key: JBTM-1754
> URL: https://issues.jboss.org/browse/JBTM-1754
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Security Level: Public(Everyone can see)
> Components: Build System
> Reporter: Paul Gier
> Assignee: Paul Gier
>
> The project names used in the build are not consistent which makes it difficult for someone unfamiliar with the project to debug build issues.
> Some examples are provided:
> ||Dir Name||Artifact ID||Project Name||
> |/ArjunaJTA|narayana-jta-all|JBoss JTA everything|
> |/ArjunaJTS/narayana-jts-idlj|narayana-jts-idlj|JBossJTS packaged module with idlj stubs|
> |/ArjunaJTS/orbportability|orbportability|JBossJTS orb portability|
> The project names can be changed without disrupting the way the build works, so these should be changed to match the dir and artifactId as much as possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (JBTM-1754) Make project names consistent in poms
by Paul Gier (JIRA)
Paul Gier created JBTM-1754:
-------------------------------
Summary: Make project names consistent in poms
Key: JBTM-1754
URL: https://issues.jboss.org/browse/JBTM-1754
Project: JBoss Transaction Manager
Issue Type: Enhancement
Security Level: Public (Everyone can see)
Components: Build System
Reporter: Paul Gier
Assignee: Paul Gier
The project names used in the build are not consistent which makes it difficult for someone unfamiliar with the project to debug build issues.
Some examples are provided:
||Dir Name||Artifact ID||Project Name||
|/ArjunaJTA|narayana-jta-all|JBoss JTA everything|
|/ArjunaJTS/narayana-jts-idlj|narayana-jts-idlj|JBossJTS packaged module with idlj stubs|
|/ArjunaJTS/orbportability|orbportability|JBossJTS orb portability|
The project names can be changed without disrupting the way the build works, so these should be changed to match the dir and artifactId as much as possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month
[JBoss JIRA] (JBTM-1642) Add timestamps to test output
by Michael Musgrove (JIRA)
[ https://issues.jboss.org/browse/JBTM-1642?page=com.atlassian.jira.plugin.... ]
Michael Musgrove resolved JBTM-1642.
------------------------------------
Resolution: Done
We already record the times in the QA TEST-* summary files. To get the times (on uniz) you can run the following command:
{noformat}
grep "Testcase: " -r TEST-org.jboss.jbossts.qa.junit.testgroup.TestGroup_* | cut -d\ -f2,4
{noformat}
> Add timestamps to test output
> -----------------------------
>
> Key: JBTM-1642
> URL: https://issues.jboss.org/browse/JBTM-1642
> Project: JBoss Transaction Manager
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Testing
> Reporter: Michael Musgrove
> Assignee: Michael Musgrove
> Priority: Trivial
> Fix For: 5.0.0.Final
>
>
> It is not always clear how long tests are taking by looking at the output of CI jobs. It might be handy to add date output via narayana.sh and to output the date before running each QA test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 years, 1 month