[JBoss JIRA] (JBTM-1507) Review the TXBridge tests usage of Arquillian
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1507?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson reassigned JBTM-1507:
-----------------------------------
Assignee: (was: Gytis Trikleris)
> Review the TXBridge tests usage of Arquillian
> ---------------------------------------------
>
> Key: JBTM-1507
> URL: https://issues.jboss.org/browse/JBTM-1507
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Components: Testing, TxBridge
> Reporter: Paul Robinson
> Priority: Minor
> Original Estimate: 2 days
> Remaining Estimate: 2 days
>
> The TXBridge tests don;t seem to be using Arquillian correctly. There is a servlet that is invoked to do things inside the container. As the tests (should) now run in the container, this should not be needed.
> The tests also seem to have added complexity due to the recovery tests. As the recovery tests need to be able to kill the container, it mandates manual container lifecycle management for *all* tests. We may want to pull out the recovery tests into a separate module.
> We also may want to pull out the DisabledContextPropagationTest into a separate module as they use a modified AS configuration.
> We should also take a general look at how the tests are structured and using Arq.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (JBTM-1982) Use logger to log all the exception stacktraces instead of several Exception.printStackTrace() calls which uses the stdout
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-1982?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson reassigned JBTM-1982:
-----------------------------------
Assignee: (was: Tom Jenkinson)
> Use logger to log all the exception stacktraces instead of several Exception.printStackTrace() calls which uses the stdout
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: JBTM-1982
> URL: https://issues.jboss.org/browse/JBTM-1982
> Project: JBoss Transaction Manager
> Issue Type: Feature Request
> Components: JTA, JTS
> Affects Versions: 4.17.10
> Reporter: Ondřej Chaloupka
> Priority: Minor
>
> The arjuna code uses pattern e.printStackTrace() on several places in the code. This would be better to be changed for a logger would be used.
> For ArjunaJTA I counted 28 (excluding tests) places where the logger is not used and I suppose it should be.
> Secondary. It would be nice in case of the XAException the error code would be printed together with the exception stacktrace. I have one example where I would appreciated it for example.
> It's ArjunaJTA/jta/classes/com/arjuna/ats/internal/jta/recovery/arjunacore/XARecoveryModule.java
> method handleOrphan where after the xares.rollback(xid) is called the exception is printed to stdout + log does not contain the error code.
> This issue was moved from https://bugzilla.redhat.com/show_bug.cgi?id=1007384.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (JBTM-2266) TransactionReaper is using currentTimeMillis for timeout calculation
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-2266?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson reassigned JBTM-2266:
-----------------------------------
Assignee: (was: Tom Jenkinson)
> TransactionReaper is using currentTimeMillis for timeout calculation
> --------------------------------------------------------------------
>
> Key: JBTM-2266
> URL: https://issues.jboss.org/browse/JBTM-2266
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Affects Versions: 5.0.3
> Reporter: David Lloyd
> Priority: Minor
>
> Noticed while browsing through some code that the TransactionReaper uses currentTimeMillis() to calculate timeouts. However the timestamp reported by this method can change in an unexpected way if the system clock is changed.
> An artificial clock based on System.nanoTime() should be used instead, since while this time may vary slightly between cores, in general it will be highly accurate and, most importantly, monotonic and steady (and unaffected by changes to the system time).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (JBTM-2318) Too verbose startup?
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-2318?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-2318:
--------------------------------
Fix Version/s: 5.later
> Too verbose startup?
> --------------------
>
> Key: JBTM-2318
> URL: https://issues.jboss.org/browse/JBTM-2318
> Project: JBoss Transaction Manager
> Issue Type: Task
> Components: Transaction Core
> Affects Versions: 5.0.4
> Reporter: Mark Little
> Assignee: Tom Jenkinson
> Priority: Minor
> Fix For: 5.later
>
>
> At startup of the most basic example we see ...
> Dec 17, 2014 8:23:50 PM com.arjuna.ats.arjuna.recovery.TransactionStatusManager addService
> INFO: ARJUNA012163: Starting service com.arjuna.ats.arjuna.recovery.ActionStatusService on port 52185
> Dec 17, 2014 8:23:50 PM com.arjuna.ats.internal.arjuna.recovery.TransactionStatusManagerItem <init>
> INFO: ARJUNA012337: TransactionStatusManagerItem host: 127.0.0.1 port: 52185
> Dec 17, 2014 8:23:50 PM com.arjuna.ats.arjuna.recovery.TransactionStatusManager start
> INFO: ARJUNA012170: TransactionStatusManager started on port 52185 and host 127.0.0.1 with service com.arjuna.ats.arjuna.recovery.ActionStatusService
> There's a separate conversation to be had about whether the INFO should be there (DEBUG maybe?) but ignoring those why do we print the other lines at all?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months
[JBoss JIRA] (JBTM-2183) Need finer grained control over which XAResource is used for recovery
by Tom Jenkinson (JIRA)
[ https://issues.jboss.org/browse/JBTM-2183?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson updated JBTM-2183:
--------------------------------
Fix Version/s: 5.later
(was: 6.later)
> Need finer grained control over which XAResource is used for recovery
> ---------------------------------------------------------------------
>
> Key: JBTM-2183
> URL: https://issues.jboss.org/browse/JBTM-2183
> Project: JBoss Transaction Manager
> Issue Type: Enhancement
> Components: Recovery
> Reporter: Michael Musgrove
> Assignee: Michael Musgrove
> Priority: Optional
> Fix For: 5.later
>
>
> During recovery when we recreate an XAResource we need one which knows about the xid that is being recovered. We implement this in the XARecoveryModule which calls recover() on each resource returned by registered XA recovery helpers. If the xid returned from recover matches against the one we are recovering we use that XAResource to drive recovery.
> However, some RMs will return all prepared transaction branches and not just the ones specific to the particular resource we made the recover call on. The scenario that led to the issue was configuring 2 datasources against the same database but with different credentials. If we replay the commit on the "wrong" one we get ORA-24774: "The transaction specified in the call refers to a transaction created by a different user".
> The fix is to return an XA resource that matches the JNDI name we logged in the recovery record and if the JNDI name is not available we drop back to using the current solution (note that the name is available when running in wildfly/EAP) .
> And finally, I I wonder if we want to make this new behaviour optional?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
9 years, 4 months