[JBoss JIRA] (JBTM-3089) LRA code improvements
by Michael Musgrove (Jira)
[ https://issues.jboss.org/browse/JBTM-3089?page=com.atlassian.jira.plugin.... ]
Michael Musgrove commented on JBTM-3089:
----------------------------------------
All exceptions should contain some text for easier tracking the error and a message logged.
Items marked as TODO should be analysed to determine whether or not a separate JIRA is called for.
> LRA code improvements
> ---------------------
>
> Key: JBTM-3089
> URL: https://issues.jboss.org/browse/JBTM-3089
> Project: JBoss Transaction Manager
> Issue Type: Task
> Components: LRA
> Affects Versions: 5.9.2.Final
> Reporter: Michael Musgrove
> Assignee: Michael Musgrove
> Priority: Major
> Fix For: 5.next
>
>
> Remove TODO comments from the code and replace with JIRA issues.
> Ensure that the message string in all occurrences of GenericLRAException are meaningful.
> Remove all commented out pieces of code.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (JBTM-3090) LRA TCK failures need to report more context to facilitate debugging
by Michael Musgrove (Jira)
Michael Musgrove created JBTM-3090:
--------------------------------------
Summary: LRA TCK failures need to report more context to facilitate debugging
Key: JBTM-3090
URL: https://issues.jboss.org/browse/JBTM-3090
Project: JBoss Transaction Manager
Issue Type: Task
Components: LRA
Affects Versions: 5.9.2.Final
Reporter: Michael Musgrove
Assignee: Michael Musgrove
Fix For: 5.next
The TCK test failure message reports
> failures.forEach(f -> System.out.printf("%s%n", f));
where f is the failure reason. There is also a verbose option which prints out the stack trace where the failure was reported. But in some failure cases these two pieces of information are insufficient to debug the failure. It would be nice if the resources that participated in the test also logged information which could be reported for more effective analysis of the reasons for the failure. This last requirement may affect the TCK itself so the code in the eclipse microprofile-lra repo should be analysed as well.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (JBTM-3089) LRA code improvements
by Michael Musgrove (Jira)
Michael Musgrove created JBTM-3089:
--------------------------------------
Summary: LRA code improvements
Key: JBTM-3089
URL: https://issues.jboss.org/browse/JBTM-3089
Project: JBoss Transaction Manager
Issue Type: Task
Components: LRA
Affects Versions: 5.9.2.Final
Reporter: Michael Musgrove
Assignee: Michael Musgrove
Fix For: 5.next
Remove TODO comments from the code and replace with JIRA issues.
Ensure that the message string in all occurrences of GenericLRAException are meaningful.
Remove all commented out pieces of code.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (JBTM-3088) NPE in Recovery Manager
by Tom Jenkinson (Jira)
[ https://issues.jboss.org/browse/JBTM-3088?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson commented on JBTM-3088:
-------------------------------------
It looks to me like one of the recovery helpers is returning a null. But there is not enough detail here to make a proper assesment of whether there is an issue here or not. I will close it as there is not enough information but please can you open a thread on https://developer.jboss.org/en/jbosstm/content?filterID=contentstatus[pub... so we can try to work though the possible causes with you and if necessary re-open this issue with more details.
> NPE in Recovery Manager
> -----------------------
>
> Key: JBTM-3088
> URL: https://issues.jboss.org/browse/JBTM-3088
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Components: JTA
> Affects Versions: 5.9.0.Final
> Reporter: Vadim Lotarev
> Priority: Major
>
> NPE happens during Recovery:
> Dec 12 00:01:54.559 WARN [][Periodic Recovery] ARJUNA016009: Caught: (com.arjuna.ats.jta:)
> java.lang.NullPointerException
> at com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.xaRecoverySecondPass(XARecoveryModule.java:713) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
> at com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.bottomUpRecovery(XARecoveryModule.java:494) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
> at com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.periodicWorkSecondPass(XARecoveryModule.java:245) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
> at com.arjuna.ats.internal.arjuna.recovery.PeriodicRecovery.doWorkInternal(PeriodicRecovery.java:811) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
> at com.arjuna.ats.internal.arjuna.recovery.PeriodicRecovery.run(PeriodicRecovery.java:377) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (JBTM-3088) NPE in Recovery Manager
by Tom Jenkinson (Jira)
[ https://issues.jboss.org/browse/JBTM-3088?page=com.atlassian.jira.plugin.... ]
Tom Jenkinson closed JBTM-3088.
-------------------------------
Resolution: Incomplete Description
> NPE in Recovery Manager
> -----------------------
>
> Key: JBTM-3088
> URL: https://issues.jboss.org/browse/JBTM-3088
> Project: JBoss Transaction Manager
> Issue Type: Bug
> Components: JTA
> Affects Versions: 5.9.0.Final
> Reporter: Vadim Lotarev
> Priority: Major
>
> NPE happens during Recovery:
> Dec 12 00:01:54.559 WARN [][Periodic Recovery] ARJUNA016009: Caught: (com.arjuna.ats.jta:)
> java.lang.NullPointerException
> at com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.xaRecoverySecondPass(XARecoveryModule.java:713) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
> at com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.bottomUpRecovery(XARecoveryModule.java:494) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
> at com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.periodicWorkSecondPass(XARecoveryModule.java:245) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
> at com.arjuna.ats.internal.arjuna.recovery.PeriodicRecovery.doWorkInternal(PeriodicRecovery.java:811) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
> at com.arjuna.ats.internal.arjuna.recovery.PeriodicRecovery.run(PeriodicRecovery.java:377) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months
[JBoss JIRA] (JBTM-3088) NPE in Recovery Manager
by Vadim Lotarev (Jira)
Vadim Lotarev created JBTM-3088:
-----------------------------------
Summary: NPE in Recovery Manager
Key: JBTM-3088
URL: https://issues.jboss.org/browse/JBTM-3088
Project: JBoss Transaction Manager
Issue Type: Bug
Components: JTA
Affects Versions: 5.9.0.Final
Reporter: Vadim Lotarev
NPE happens during Recovery:
Dec 12 00:01:54.559 WARN [][Periodic Recovery] ARJUNA016009: Caught: (com.arjuna.ats.jta:)
java.lang.NullPointerException
at com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.xaRecoverySecondPass(XARecoveryModule.java:713) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
at com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.bottomUpRecovery(XARecoveryModule.java:494) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
at com.arjuna.ats.internal.jta.recovery.arjunacore.XARecoveryModule.periodicWorkSecondPass(XARecoveryModule.java:245) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
at com.arjuna.ats.internal.arjuna.recovery.PeriodicRecovery.doWorkInternal(PeriodicRecovery.java:811) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
at com.arjuna.ats.internal.arjuna.recovery.PeriodicRecovery.run(PeriodicRecovery.java:377) ~[narayana-jta-5.9.0.Final.jar.9186195290256057980.jar:5.9.0.Final (revision: f0935)]
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
6 years, 10 months