]
Ondra Chaloupka updated JBTM-2759:
----------------------------------
Status: Resolved (was: Pull Request Sent)
Resolution: Done
The fix which came from static code analysis tooling were already merged.
Static code analysis: potential lock collisions
BaseTransactionManagerDelegate#findLock - interned string used as a lock
------------------------------------------------------------------------------------------------------------------------
Key: JBTM-2759
URL:
https://issues.jboss.org/browse/JBTM-2759
Project: JBoss Transaction Manager
Issue Type: Bug
Components: JTS
Affects Versions: 5.3.4.Final
Reporter: Ondra Chaloupka
Assignee: Ondra Chaloupka
Priority: Minor
_CID-17577_: Bad choice of lock object - Potential lock collisions
at class {{BaseTransactionManagerDelegate}}[9] at method {{findLock}}.
{quote}
string_literal: The string literal "__LOCKS_MAP" is an interned string.
interned_string_lock: Locking on an interned string can cause unexpected locking
collisions with third party code.
Instead of using "__LOCKS_MAP" as a lock, create a final field of type Object
which is only used as a lock.
{quote}
Explanation at description of JBTM-2758
[9]
https://github.com/jbosstm/narayana/blob/master/ArjunaJTS/integration/src...