Invalid warning when committing STM optimistic records ------------------------------------------------------ Key: JBTM-2896 URL: https://issues.jboss.org/browse/JBTM-2896 Project: JBoss Transaction Manager Issue Type: Bug Components: STM Affects Versions: 5.5.24.Final Reporter: Michael Musgrove Assignee: Michael Musgrove Fix For: 5.next There is some code in OptimisticLockRecord#topLevelCommit that generates an invalid warning bq. WARN: ARJUNA015051: OptimisticLockRecord.topLevelCommit state check failed for org.jboss.stm.internal.proxy.OptimisticLockManagerProxy@7f058cfa will force rollback. when in fact there is no rollback. The offending code is: {code} public int topLevelCommit () { boolean stateOK = checkState(); if (stateOK) { txojLogger.i18NLogger.warn_OptimisticLockRecord_2((LockManager) value()); } {code} The condition was intended to be if (!stateOK)