[
https://issues.jboss.org/browse/JBTM-1695?page=com.atlassian.jira.plugin....
]
Paul Gier commented on JBTM-1695:
---------------------------------
I created a new PR (
https://github.com/jbosstm/narayana/pull/296) because the one from
Weinan included some extra merge commits, and didn't account for other modules which
depend on the source path.
{quote}
can you clarify if there is an EAP issue with the code
{quote}
It's not a serious issue, it just makes the build a bit easier to read and maintain.
There is also sometimes a risk that certain plugins depend on the standard layout instead
of reading the configured directory from the pom (although I think this is pretty rare
now). Since the newer modules already use the Maven directory standards, it seems like it
makes sense to make them all the same. But it's ok to reject this if it causes
problems for people who are familiar with the old layout.
{quote}
It also makes the history a lot harder to navigate, if you re-name the directory
structure.
{quote}
This shouldn't be as much of an issue now that the project uses git. You just have to
use "git log --follow" or have an IDE that supports that option.
Change the 'common' module to use the normal maven convention
for source layout.
--------------------------------------------------------------------------------
Key: JBTM-1695
URL:
https://issues.jboss.org/browse/JBTM-1695
Project: JBoss Transaction Manager
Issue Type: Feature Request
Security Level: Public(Everyone can see)
Affects Versions: 4.17.4
Reporter: Weinan Li
Assignee: Weinan Li
The common module doesn't use the normal maven convention for source layout.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira