Static code analysis - check report and fix issues -------------------------------------------------- Key: JBTM-2847 URL: https://issues.jboss.org/browse/JBTM-2847 Project: JBoss Transaction Manager Issue Type: Task Affects Versions: 5.5.1.Final Reporter: Ondra Chaloupka Assignee: Ondra Chaloupka Priority: Minor Fix For: 5.5.2.Final By going through static code analysis report of changes done during last a half year there are few issues that would be fine to be adjusted. They are following # at com.arjuna.ats.internal.jta.transaction.arjunacore.jca.XATerminatorImple, L614; com.arjuna.ats.internal.jta.transaction.jts.jca, L471 (https://github.com/jbosstm/narayana/blob/master/ArjunaJTA/jta/classes/com...) the calling method getCurrentTransactionId() potentially could end with NullPointerException (caused by TransactionImple#getTransaction when `final BasicAction current = BasicAction.Current()` is null) # possible resource leak - connection was ommitted to be closed ## org.jboss.narayana.tomcat.jta.integration.TestExecutor ## TestCommitMarkableResourceFailAfterCommitOrphan # inner class SampleLockable of org.jboss.stm.STMVerticle could be static (http://station5.brq.redhat.com:8080/docs/en/findbugs/fb_checker_ref.html#...)