Author: alessio.soldano(a)jboss.com Date: 2012-12-11 06:13:27 -0500 (Tue, 11 Dec 2012) New Revision: 17064 Modified: common/trunk/src/main/java/org/jboss/ws/common/JavaUtils.java common/trunk/src/main/java/org/jboss/ws/common/configuration/ConfigDelegateHandler.java common/trunk/src/main/java/org/jboss/ws/common/configuration/ConfigDelegateHandlerComparator.java common/trunk/src/main/java/org/jboss/ws/common/deployment/EndpointAddressDeploymentAspect.java Log: Fixing few minor bugs / leaks Modified: common/trunk/src/main/java/org/jboss/ws/common/JavaUtils.java =================================================================== --- common/trunk/src/main/java/org/jboss/ws/common/JavaUtils.java 2012-12-10 18:19:30 UTC (rev 17063) +++ common/trunk/src/main/java/org/jboss/ws/common/JavaUtils.java 2012-12-11 11:13:27 UTC (rev 17064) @@ -523,15 +523,15 @@ if (! type.isArray()) return type.getName(); - String arrayNotation = ""; + StringBuilder arrayNotation = new StringBuilder(); Class<?> component = type; while(component.isArray()) { component = component.getComponentType(); - arrayNotation += "[]"; + arrayNotation.append("[]"); } - return component.getName() + arrayNotation; + return component.getName() + arrayNotation.toString(); } public static String capitalize(String source) Modified: common/trunk/src/main/java/org/jboss/ws/common/configuration/ConfigDelegateHandler.java =================================================================== --- common/trunk/src/main/java/org/jboss/ws/common/configuration/ConfigDelegateHandler.java 2012-12-10 18:19:30 UTC (rev 17063) +++ common/trunk/src/main/java/org/jboss/ws/common/configuration/ConfigDelegateHandler.java 2012-12-11 11:13:27 UTC (rev 17064) @@ -51,7 +51,7 @@ @Override public boolean handleFault(T context) { - return handleFault(context); + return delegate.handleFault(context); } @Override Modified: common/trunk/src/main/java/org/jboss/ws/common/configuration/ConfigDelegateHandlerComparator.java =================================================================== --- common/trunk/src/main/java/org/jboss/ws/common/configuration/ConfigDelegateHandlerComparator.java 2012-12-10 18:19:30 UTC (rev 17063) +++ common/trunk/src/main/java/org/jboss/ws/common/configuration/ConfigDelegateHandlerComparator.java 2012-12-11 11:13:27 UTC (rev 17064) @@ -21,6 +21,7 @@ */ package org.jboss.ws.common.configuration; +import java.io.Serializable; import java.util.Comparator; import javax.xml.ws.handler.Handler; @@ -33,8 +34,10 @@ * */ @SuppressWarnings("rawtypes") -public final class ConfigDelegateHandlerComparator<T extends Handler> implements Comparator<T> +public final class ConfigDelegateHandlerComparator<T extends Handler> implements Comparator<T>, Serializable { + static final long serialVersionUID = 5045492270035185007L; + @Override public int compare(Handler o1, Handler o2) { Modified: common/trunk/src/main/java/org/jboss/ws/common/deployment/EndpointAddressDeploymentAspect.java =================================================================== --- common/trunk/src/main/java/org/jboss/ws/common/deployment/EndpointAddressDeploymentAspect.java 2012-12-10 18:19:30 UTC (rev 17063) +++ common/trunk/src/main/java/org/jboss/ws/common/deployment/EndpointAddressDeploymentAspect.java 2012-12-11 11:13:27 UTC (rev 17064) @@ -182,7 +182,7 @@ return "CONFIDENTIAL".equals(transportGuarantee); } - private class PortValue { + private static class PortValue { private ServerConfig config; private Integer port; private Integer securePort;